HomePhabricator

dh: plug pubkey_blob leak in ssh_server_dh_process_init

Authored by simonsj on Wed, Jan 30, 2:17 AM.

Description

dh: plug pubkey_blob leak in ssh_server_dh_process_init

Ensure to SSH_STRING_FREE the pubkey_blob local in
ssh_server_dh_process_init. The leak can be seen with
valgrind and the pkd tests with:

valgrind \
  --leak-check=full \
  --show-leak-kinds=definite \
  ./pkd_hello -i1 -t torture_pkd_openssh_rsa_rsa_diffie_hellman_group14_sha1

Signed-off-by: Jon Simons <jon@jonsimons.org>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>

Details

Committed
asnWed, Jan 30, 1:22 PM
Parents
rLIBSSHb44987a164c6: dh-gex: fix double-ssh_dh_init_common memory leak
Branches
Unknown
Tags
Unknown