Page MenuHomePhabricator

martinpitt (Martin Pitt)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2018, 11:33 AM (107 w, 9 h)

Recent Activity

Jun 24 2019

martinpitt added a comment to T151: curve25519-sha256 problems under Valgrind on i386.

@Jakuje : FTR, we test this in i386 chroots or containers, the base system is 64 bit everywhere. It could be specific to the Debian/Ubuntu valgrind version or toolchain of course.

Jun 24 2019, 8:28 AM · Restricted Project

May 27 2019

martinpitt added a comment to T151: curve25519-sha256 problems under Valgrind on i386.

For the record, this also happens with the latest 0.8.7. I added a reproducer to the Debian package, to be able to track this easily.

May 27 2019, 12:28 PM · Restricted Project

Oct 21 2018

martinpitt added a comment to T117: 0.8.4 ssh server regression with interactive keyboard auth: message callback only called once.

I can confirm that with libssh master, both the reproducer and cockpit's unit tests work. Thanks! As this blocks releasing new cockpit versions, and fixes a regression, do you plan to fix this in Fedora soon? I'll file a bug for the next RHEL devel version.

Oct 21 2018, 10:27 PM · Restricted Project

Oct 19 2018

martinpitt added a comment to T117: 0.8.4 ssh server regression with interactive keyboard auth: message callback only called once.

reproducer code and script:

Oct 19 2018, 5:02 PM · Restricted Project
martinpitt added a project to T117: 0.8.4 ssh server regression with interactive keyboard auth: message callback only called once: Restricted Project.
Oct 19 2018, 5:00 PM · Restricted Project
martinpitt created T117: 0.8.4 ssh server regression with interactive keyboard auth: message callback only called once.
Oct 19 2018, 4:59 PM · Restricted Project

Oct 10 2018

martinpitt added a comment to T107: ssh_session_has_known_hosts_entry doesn't seem to check in opts.global_knownhosts.

IMHO the expected behaviour would be to check both the global and user file, like ssh_session_is_known_server(). Otherwise, actually checking the global file on the caller side would be rather ugly: You would first need to temporarily set the *user* known hosts to the global one (/etc/ssh/ssh_known_hosts), check ssh_session_has_known_hosts_entry(), then reset the user known hosts file to the default again, and check again.

Oct 10 2018, 11:51 AM · Restricted Project