jvijtiuk (Juraj Vijtiuk)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 9 2017, 10:51 AM (49 w, 9 h)

Recent Activity

Dec 27 2017

jvijtiuk updated the diff for D1: add mbedtls crypto support.

I have rebased onto master again, and fixed the new conflicts that appeared.

Dec 27 2017, 4:24 PM
jvijtiuk added a comment to T80: torture_config_new test fails due to invalid session time out value caused by int pointer to long pointer cast.

I see you are referencing that the fail was introduced by my commit, but it was just adding a test that uncovered this problem that existed for longer time (from 484564261?).

Yes, you are right, I should have worded that better, the torture_config_new test only made the bug visible.

Dec 27 2017, 4:07 PM

Dec 22 2017

jvijtiuk added a reviewer for D13: pki: Fix accidental ECC switch case fallthroughs into ed25119 cases when built without ECC: asn.
Dec 22 2017, 5:50 PM
jvijtiuk updated the summary of D13: pki: Fix accidental ECC switch case fallthroughs into ed25119 cases when built without ECC.
Dec 22 2017, 5:44 PM
jvijtiuk created T80: torture_config_new test fails due to invalid session time out value caused by int pointer to long pointer cast.
Dec 22 2017, 5:01 PM

Dec 21 2017

jvijtiuk updated the diff for D1: add mbedtls crypto support.

Rebased onto master and fixed conflicts that appeared.

Dec 21 2017, 1:39 PM

Dec 11 2017

jvijtiuk updated the diff for D1: add mbedtls crypto support.
  • Add mbedtls drbg reseeding
  • Update README.mbedtls with info for ssh_key_cmp
Dec 11 2017, 1:22 PM

Nov 17 2017

jvijtiuk updated the diff for D1: add mbedtls crypto support.

I've fixed the memory leaks and config.h issues. README.mbedtls has also been added.
However, maybe the comparison code for ECDSA could be written with what mbedTLS already provides, the private and public curve points and the group can be accessed through the ECDSA context, however a function similar to EC_POINT_cmp doesn't exist, so I will have to look further into that when I find some time as I'm not sure what effect the curve group has on point comparison. The gcrypt code just compares the private and public points.

Nov 17 2017, 6:14 PM

Sep 18 2017

jvijtiuk abandoned D12: pki: Fix accidental ECC switch case fallthroughs into ed25119 cases when built without ECC.

This still misses a default case in pki_crypto and one of the pki switch cases. I accidentaly opened another diff https://bugs.libssh.org/D13, with the default case added, so i am closing this one

Sep 18 2017, 4:33 PM
jvijtiuk created D13: pki: Fix accidental ECC switch case fallthroughs into ed25119 cases when built without ECC.
Sep 18 2017, 4:28 PM
jvijtiuk created D12: pki: Fix accidental ECC switch case fallthroughs into ed25119 cases when built without ECC.
Sep 18 2017, 1:32 PM

Sep 12 2017

jvijtiuk updated the diff for D1: add mbedtls crypto support.

Add accidentaly removed o in mbedtls_info, introduced in revision 22.

Sep 12 2017, 3:30 PM
jvijtiuk updated the diff for D1: add mbedtls crypto support.

Remove formatting errors/hunks.
Remove unnecessary HAVE_LIBMBEDCRYPTO DSA check in pki_crypto.c

Sep 12 2017, 3:18 PM
jvijtiuk updated the diff for D1: add mbedtls crypto support.

Remove formatting errors.
Initialize uninitialized pointers to null in mbedTLS files.

Sep 12 2017, 2:52 PM

Aug 10 2017

jvijtiuk updated the diff for D1: add mbedtls crypto support.
  • Remove HAVE_DSA ifdefs where possible
  • Remove HAVE_DSA checks from public headers, libssh.h and server.h
  • Remove HAVE_DSA from private headers and most .c files.
  • Instead of checking for HAVE_DSA, handle DSA similarly to how ECC is handled, by failing when dsa keys are used with mbedtls.
  • Add dsa elements to structs which use dsa as void pointers, when mbedtls is used.
Aug 10 2017, 3:54 PM

Aug 9 2017

jvijtiuk added a reviewer for D1: add mbedtls crypto support: asn.
Aug 9 2017, 1:11 PM
jvijtiuk created D1: add mbedtls crypto support.
Aug 9 2017, 11:24 AM