Page MenuHomePhabricator

cortana63 (Sarah Magliocca)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 9 2018, 10:26 PM (14 w, 3 d)

Recent Activity

Dec 11 2018

cortana63 added a comment to T47: sftp_write waits infinitely when connection to target server is lost.

Hi Andreas, the issue still persists. Looking at this commit: https://git.libssh.org/users/asn/libssh.git/commit/?h=master-poll&id=917ced39e0c8aaae4d2c22bcdbcb767f6355e62d

Dec 11 2018, 9:25 PM · Restricted Project

Dec 5 2018

cortana63 added a comment to T47: sftp_write waits infinitely when connection to target server is lost.

The remaining issue is that the only time bsd_socket_compute_revents is called is when FD_ISSET(fds[i].fd, &readfds) returns true. However, with some instances of the application, FD_ISSET(fds[i].fd, &readfds) will consistently return false, resulting in the infinite loop since bsd_socket_compute_revents doesn't get called.

Dec 5 2018, 3:06 PM · Restricted Project
cortana63 added a comment to T47: sftp_write waits infinitely when connection to target server is lost.

It's not clear to me why FD_ISSET() is needed. WSAGetLastError() does correctly return WSAECONNRESET.

Dec 5 2018, 2:44 PM · Restricted Project

Nov 29 2018

cortana63 added a comment to T47: sftp_write waits infinitely when connection to target server is lost.

I think we are getting closer to fixing this issue. The timeout is correctly being propagated to the winsock select() function. WSAGetLastError() is returning WSAECONNRESET.

Nov 29 2018, 9:09 PM · Restricted Project

Nov 28 2018

cortana63 added a comment to T47: sftp_write waits infinitely when connection to target server is lost.

Hi Andreas,

Nov 28 2018, 8:15 PM · Restricted Project

Nov 27 2018

cortana63 added a comment to T47: sftp_write waits infinitely when connection to target server is lost.

It looks like bsd_socket_disconnected() isn't even getting called.

Nov 27 2018, 8:36 PM · Restricted Project

Nov 26 2018

cortana63 added a comment to T47: sftp_write waits infinitely when connection to target server is lost.

I pulled the latest master-poll and am no longer seeing a seg fault. However, I'm seeing the same infinite poll issue as before. It happens maybe 75% of the time.

Nov 26 2018, 4:21 PM · Restricted Project

Nov 21 2018

cortana63 added a comment to T47: sftp_write waits infinitely when connection to target server is lost.

Thanks again for working with me on this issue.

Nov 21 2018, 10:01 PM · Restricted Project
cortana63 added a comment to T47: sftp_write waits infinitely when connection to target server is lost.

Hi Andreas,

Nov 21 2018, 2:50 PM · Restricted Project

Nov 20 2018

cortana63 added a comment to F66937: 0001-ssh-poll-timeout-fix.patch.

Thank you for your feedback Andreas. I have attached the updated patch.

Nov 20 2018, 10:09 PM
cortana63 added a comment to T47: sftp_write waits infinitely when connection to target server is lost.

Thanks for spending time on this Andreas.

Nov 20 2018, 5:02 PM · Restricted Project
cortana63 added a comment to F66937: 0001-ssh-poll-timeout-fix.patch.

Before the fix: On Windows, during a successful download, ssh_poll() returns > 0. When there is a disconnect that occurs in the middle of the download, ssh_poll() returns 0.

Nov 20 2018, 2:58 PM
cortana63 added a comment to T47: sftp_write waits infinitely when connection to target server is lost.

Thanks Andreas. I have attached an updated patch for the sftp.c file using sftp->session->opts.timeout instead of SSH_OPTIONS_TIMEOUT:

Nov 20 2018, 2:43 PM · Restricted Project

Nov 19 2018

cortana63 added a comment to T33: SSH_OPTIONS_TIMEOUT not used in non-blocking sockets.

See https://bugs.libssh.org/T47 for two patches that address part of this problem.

Nov 19 2018, 8:57 PM · Restricted Project
cortana63 added a comment to T47: sftp_write waits infinitely when connection to target server is lost.

This is still occurring as of release 0.8.4. This issue is related: https://bugs.libssh.org/T33

Nov 19 2018, 8:56 PM · Restricted Project

Nov 13 2018

cortana63 added a comment to T33: SSH_OPTIONS_TIMEOUT not used in non-blocking sockets.

I am seeing this issue with sftp_read(). The sftp_read() function call was getting hung when there was a disconnect. I traced it to ssh_channel_read() which isn't using the user defined timeout.

Nov 13 2018, 4:46 PM · Restricted Project
cortana63 added a comment to T33: SSH_OPTIONS_TIMEOUT not used in non-blocking sockets.

I have tested with 0.8.4. It looks like SSH_TIMEOUT_DEFAULT is always -1 even if I set SSH_OPTIONS_TIMEOUT.

Nov 13 2018, 2:18 PM · Restricted Project

Nov 9 2018

cortana63 added a comment to T33: SSH_OPTIONS_TIMEOUT not used in non-blocking sockets.

This is related to this issue discussed here: https://www.libssh.org/archive/libssh/2016-02/0000010.html

Nov 9 2018, 10:35 PM · Restricted Project