Page MenuHomePhabricator

aris (Aris Adamantiadis)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jun 12 2017, 2:50 PM (129 w, 5 d)
Roles
Administrator

Recent Activity

Fri, Nov 22

aris updated subscribers of T200: Test torture_proxycommand fails on ubuntu 18.04.

@asn mentioned on IRC a bug in libuidwrapper that was caused by a particular/weird implementation of libpam. I have no clue how to debug this problem.

Fri, Nov 22, 9:46 AM · Unknown Object (Project)

Thu, Nov 21

aris added a comment to T180: tests: "bind: address already in use".

Thanks for your comments. I saw the rekey test fail in other pipelines too, I think we have a probabilistic bug there, unrelated to this issue.

Thu, Nov 21, 4:57 PM · Unknown Object (Project)
aris added a comment to T180: tests: "bind: address already in use".

hi @Jakuje, I have updated the branch and I think I fixed all your concerns. I opened a separate ticket T200 for the remaining problems. I haven't tried the new CI image, I don't understand yet how to run the gitlab CI tests locally.

Thu, Nov 21, 4:23 PM · Unknown Object (Project)
aris created T200: Test torture_proxycommand fails on ubuntu 18.04.
Thu, Nov 21, 4:14 PM · Unknown Object (Project)

Nov 4 2019

aris added a comment to T180: tests: "bind: address already in use".

Hi @Jakuje, thanks for your review. All your comments are directly actionable so I'll fix them asap.
the two pkd tests that failed are related to my changes and bug T191 that I discovered this way, so I think we should merge it and acknowledge that there are unfixed bugs on our tree.
A few CI targets have two more failing tests. I didn't manage to reproduce them, I'm not sure if they did not exist before.
I'll see what I should do to have ubuntu as part of the CI targets. It makes totally sense because ubuntu is breaking every time I want to catch up on libssh dev :)

Nov 4 2019, 1:52 PM · Unknown Object (Project)
aris added a comment to T180: tests: "bind: address already in use".

Could you please review my patches from https://gitlab.com/arisada/libssh-mirror/tree/fix-tests-ubuntu-tomerge ? There are fixes to this issue but also a testcase for T191.

Nov 4 2019, 10:47 AM · Unknown Object (Project)

Oct 27 2019

aris created T191: Server incorrectly assumes rsa-sha2-256 when client meant standard ssh-rsa.
Oct 27 2019, 11:01 PM · Unknown Object (Project)

Oct 20 2019

aris claimed T180: tests: "bind: address already in use".

I found the cause of the problem. The snprintf used to build the configuration file was reaching the maximum size of the buffer and was truncated, effectively removing the pidfile from the sshd configuration.
I'll push the commit on my review branch tomorrow.

Oct 20 2019, 12:58 AM · Unknown Object (Project)

Oct 16 2019

aris created T180: tests: "bind: address already in use".
Oct 16 2019, 10:16 PM · Unknown Object (Project)

Sep 15 2019

aris added a comment to T137: Difference between sftp_new() and sftp_init() is not clear.
In T137#2665, @adelton wrote:

I like the proposed wording, @Jakuje.
If the semantics get changed later, the documentation will change with it. But I'd prefer not waiting for the refactoring and just update the description now, as the first step.

Sep 15 2019, 9:11 PM · Unknown Object (Project)

Sep 13 2019

aris added a comment to T137: Difference between sftp_new() and sftp_init() is not clear.

That code is awfully old (probably 2004-2005). The idea was probably separating the SSH part and the SFTP parts. Today it makes little sense. Also both calls are synchronous and blocking. Your proposed patch describes well what it does today. Given the time I'd improve the actual implementation and move everything that handles network into sftp_init() and leave sftp_new() to memory allocation only like it's standard in the rest of the library.

Sep 13 2019, 6:37 PM · Unknown Object (Project)
aris added a comment to T142: torture_proxycommand failing.

Hi Jakub,

Sep 13 2019, 6:08 PM · Unknown Object (Project)
aris triaged T174: pkd_hello fails for some host key types as Low priority.
Sep 13 2019, 5:22 PM · Unknown Object (Project)
aris reopened T142: torture_proxycommand failing as "Open".

Closed it by mistake

Sep 13 2019, 5:12 PM · Unknown Object (Project)
aris closed T142: torture_proxycommand failing as Resolved.

cc @Jakuje, git blame says you touched that code last :)

Sep 13 2019, 5:11 PM · Unknown Object (Project)
aris added a comment to T142: torture_proxycommand failing.

I found this problem too when trying to set up the test environment on Ubuntu 18.04. The root cause is that the test calls the ssh binary from the fake root user. It fails because ssh can't find uid 0 in /etc/passwd, then fails because of missing known hosts keys and authentication keys. I don't know how that test could work elsewhere.
I made a patch that assumes it's running as root and create the missing keys. A better way would be to force the test cases to run as bob but I haven't found the proper way of doing this.

Sep 13 2019, 5:10 PM · Unknown Object (Project)

Feb 7 2019

aris committed rLIBSSHf890b09edbed: cmake: fix build problem on ubuntu 18.04 (authored by aris).
cmake: fix build problem on ubuntu 18.04
Feb 7 2019, 7:17 PM

Feb 5 2019

aris claimed T124: Connector interface does not work correctly in SSH server environment.

Thanks for your contribution!
I'll review this patch asap.

Feb 5 2019, 1:27 PM · Unknown Object (Project)

Feb 2 2019

aris closed T51: Add Diffie-Hellman Group Exchange as Resolved.
Feb 2 2019, 5:31 PM · Unknown Object (Project)
aris added a comment to T51: Add Diffie-Hellman Group Exchange.

dh-gex kex was implemented and pushed to master.

Feb 2 2019, 5:31 PM · Unknown Object (Project)