Page MenuHomePhabricator

aris (Aris Adamantiadis)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jun 12 2017, 2:50 PM (122 w, 3 h)
Roles
Administrator

Recent Activity

Sun, Sep 15

aris added a comment to T137: Difference between sftp_new() and sftp_init() is not clear.
In T137#2665, @adelton wrote:

I like the proposed wording, @Jakuje.
If the semantics get changed later, the documentation will change with it. But I'd prefer not waiting for the refactoring and just update the description now, as the first step.

Sun, Sep 15, 9:11 PM · Unknown Object (Project)

Sep 13 2019

aris added a comment to T137: Difference between sftp_new() and sftp_init() is not clear.

That code is awfully old (probably 2004-2005). The idea was probably separating the SSH part and the SFTP parts. Today it makes little sense. Also both calls are synchronous and blocking. Your proposed patch describes well what it does today. Given the time I'd improve the actual implementation and move everything that handles network into sftp_init() and leave sftp_new() to memory allocation only like it's standard in the rest of the library.

Sep 13 2019, 6:37 PM · Unknown Object (Project)
aris added a comment to T142: torture_proxycommand failing.

Hi Jakub,

Sep 13 2019, 6:08 PM · Unknown Object (Project)
aris triaged T174: pkd_hello fails for some host key types as Low priority.
Sep 13 2019, 5:22 PM · Unknown Object (Project)
aris reopened T142: torture_proxycommand failing as "Open".

Closed it by mistake

Sep 13 2019, 5:12 PM · Unknown Object (Project)
aris closed T142: torture_proxycommand failing as Resolved.

cc @Jakuje, git blame says you touched that code last :)

Sep 13 2019, 5:11 PM · Unknown Object (Project)
aris added a comment to T142: torture_proxycommand failing.

I found this problem too when trying to set up the test environment on Ubuntu 18.04. The root cause is that the test calls the ssh binary from the fake root user. It fails because ssh can't find uid 0 in /etc/passwd, then fails because of missing known hosts keys and authentication keys. I don't know how that test could work elsewhere.
I made a patch that assumes it's running as root and create the missing keys. A better way would be to force the test cases to run as bob but I haven't found the proper way of doing this.

Sep 13 2019, 5:10 PM · Unknown Object (Project)

Feb 7 2019

aris committed rLIBSSHf890b09edbed: cmake: fix build problem on ubuntu 18.04 (authored by aris).
cmake: fix build problem on ubuntu 18.04
Feb 7 2019, 7:17 PM

Feb 5 2019

aris claimed T124: Connector interface does not work correctly in SSH server environment.

Thanks for your contribution!
I'll review this patch asap.

Feb 5 2019, 1:27 PM · Unknown Object (Project)

Feb 2 2019

aris closed T51: Add Diffie-Hellman Group Exchange as Resolved.
Feb 2 2019, 5:31 PM · Unknown Object (Project)
aris added a comment to T51: Add Diffie-Hellman Group Exchange.

dh-gex kex was implemented and pushed to master.

Feb 2 2019, 5:31 PM · Unknown Object (Project)