Page MenuHomePhabricator

ZhaoGuangYue1986 (ZhaoGuangYue)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 30 2019, 4:16 AM (60 w, 4 d)

Recent Activity

Dec 15 2019

ZhaoGuangYue1986 closed T206: Should we duplicate the sshkey when we use SSH_BIND_OPTIONS_IMPORT_KEY? as Resolved.
Dec 15 2019, 12:16 PM · Unknown Object (Project)
ZhaoGuangYue1986 added a comment to T207: move ssh_key_dup() from pki.h to libssh.h?.
In T207#3531, @Jakuje wrote:

To my opinion, even we move ssh_key_dup() to libssh.h ,we also should duplicate ssh_key in function ssh_bind_options_set() , it is better to free memory apply by itself , not free memory applied by others

This would be changing behavior so for any program written with older libssh, new versions would leak this memory, because they would be expecting it will be freed with the bind. So better solution would really be to use the ssh_key_dup() yourself (easiest by including the pki.h yourself for now as suggested in the other issue).

Dec 15 2019, 11:54 AM · Unknown Object (Project)
ZhaoGuangYue1986 added a comment to T207: move ssh_key_dup() from pki.h to libssh.h?.

This issue is relatate to https://bugs.libssh.org/T206

Dec 15 2019, 11:13 AM · Unknown Object (Project)
ZhaoGuangYue1986 renamed T207: move ssh_key_dup() from pki.h to libssh.h? from remove ssh_key_dup() from pki.h to libssh.h? to move ssh_key_dup() from pki.h to libssh.h?.
Dec 15 2019, 2:06 AM · Unknown Object (Project)

Dec 14 2019

ZhaoGuangYue1986 created T207: move ssh_key_dup() from pki.h to libssh.h?.
Dec 14 2019, 12:59 PM · Unknown Object (Project)
ZhaoGuangYue1986 created T206: Should we duplicate the sshkey when we use SSH_BIND_OPTIONS_IMPORT_KEY?.
Dec 14 2019, 12:57 PM · Unknown Object (Project)

Jan 30 2019

ZhaoGuangYue1986 updated the task description for T131: [queestion]-[libssh]-When physical link is down(for example:the network cable is pull out by people) ,the channel can not detect broken timely.
Jan 30 2019, 7:26 AM
ZhaoGuangYue1986 renamed T131: [queestion]-[libssh]-When physical link is down(for example:the network cable is pull out by people) ,the channel can not detect broken timely from [queestion]-[libssh]-When physical link is down(for example:the network cable is pull out by people) ,the channel can not detect timely to [queestion]-[libssh]-When physical link is down(for example:the network cable is pull out by people) ,the channel can not detect broken timely.
Jan 30 2019, 7:26 AM
ZhaoGuangYue1986 renamed T131: [queestion]-[libssh]-When physical link is down(for example:the network cable is pull out by people) ,the channel can not detect broken timely from When physical link is down(for example:the network cable is pull out by people) ,the channel can not detect timely to [queestion]-[libssh]-When physical link is down(for example:the network cable is pull out by people) ,the channel can not detect timely.
Jan 30 2019, 7:11 AM
ZhaoGuangYue1986 created T131: [queestion]-[libssh]-When physical link is down(for example:the network cable is pull out by people) ,the channel can not detect broken timely.
Jan 30 2019, 7:08 AM