Page MenuHomePhabricator

Jakuje (Jakub Jelen)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 7 2017, 9:55 AM (49 w, 2 d)

Recent Activity

Yesterday

Jakuje added a comment to T107: ssh_session_has_known_hosts_entry doesn't seem to check in opts.global_knownhosts.

This issue is mostly related to the parallel work on the config parsing by me and rewrite of the knownhosts api by Andreas. The global knownhosts file was a new thing at this time and therefore I am not very surprised this slipped through.

Thu, Oct 18, 5:27 PM · Unknown Object (Project)
Jakuje added a comment to T105: HostKeyAlgorithms: Check if there is an entry in known_hosts and prefer that.

The following changes should settle the behavior to more sane that follows openssh and does not cause problems if there are more host keys stored in the known_hosts files:

Thu, Oct 18, 4:33 PM · Unknown Object (Project)
Jakuje added a comment to T105: HostKeyAlgorithms: Check if there is an entry in known_hosts and prefer that.

This is actually implemented by the function ssh_known_hosts_get_algorithms(), but behaves a bit differently than a similar function in OpenSSH client:

Thu, Oct 18, 11:57 AM · Unknown Object (Project)

Tue, Oct 9

Jakuje added a comment to T98: [sftp] Add support for posix-rename@openssh.com.

This landed in 6c56c1e0d72670da274f3e77c51a7b4e078d59c6

Tue, Oct 9, 2:51 PM · Unknown Object (Project)
Jakuje added a comment to T99: [sftp] Add support for hardlink@openssh.com.

This landed in 6c56c1e0d72670da274f3e77c51a7b4e078d59c6

Tue, Oct 9, 2:49 PM · Unknown Object (Project)
Jakuje added a comment to T60: Server hostkey: allow ed25519 only.

If I am right, this should be fixed with c8429113faddce47db2f5cabd6f544564c2c3770

Tue, Oct 9, 2:41 PM · Unknown Object (Project)

Fri, Oct 5

Jakuje committed rLIBSSH1eeeace97505: cmake: Configure nss_wrapper and uid_wrapper (authored by asn).
cmake: Configure nss_wrapper and uid_wrapper
Fri, Oct 5, 12:13 PM
Jakuje committed rLIBSSHbd7b509278a9: torture: Enable old host key algos for testing (authored by asn).
torture: Enable old host key algos for testing
Fri, Oct 5, 12:13 PM
Jakuje committed rLIBSSH73ebcb3ab885: torture: Start sshd as root (authored by asn).
torture: Start sshd as root
Fri, Oct 5, 12:13 PM
Jakuje committed rLIBSSH652acbeb2118: torture: Enable old cipher and kex algos in sshd (authored by asn).
torture: Enable old cipher and kex algos in sshd
Fri, Oct 5, 12:12 PM
Jakuje committed rLIBSSH96e04d469126: torture: Create a torture_terminate_process() function (authored by asn).
torture: Create a torture_terminate_process() function
Fri, Oct 5, 12:12 PM
Jakuje committed rLIBSSH2db325eb74db: torture: Restrict files to we write to our user. (authored by asn).
torture: Restrict files to we write to our user.
Fri, Oct 5, 12:12 PM
Jakuje committed rLIBSSH7113074ae4cf: torture: Add torture_teardown_sshd_server(). (authored by asn).
torture: Add torture_teardown_sshd_server().
Fri, Oct 5, 12:12 PM
Jakuje committed rLIBSSH9937d0b55212: torture: Add function to setup sshd server (authored by asn).
torture: Add function to setup sshd server
Fri, Oct 5, 12:12 PM
Jakuje committed rLIBSSHae3e2a19c8eb: torture: Add torture_teardown_socket_dir(). (authored by asn).
torture: Add torture_teardown_socket_dir().
Fri, Oct 5, 12:12 PM
Jakuje committed rLIBSSH4814c188ebf9: tests: Add ssh host keys for test environment. (authored by asn).
tests: Add ssh host keys for test environment.
Fri, Oct 5, 12:12 PM
Jakuje committed rLIBSSHa317188cb7e7: cmake: Search for cwrap and sshd. (authored by asn).
cmake: Search for cwrap and sshd.
Fri, Oct 5, 12:12 PM
Jakuje committed rLIBSSH3567524fb2ff: torture: Add torture_setup_socket_dir(). (authored by asn).
torture: Add torture_setup_socket_dir().
Fri, Oct 5, 12:12 PM

Sep 17 2018

Jakuje added a comment to T97: libssh sftp client is using unreasonable amount of memory.

The above valgrind report was for direct comparison with the data from original report in description. In that case, we got to 50 % of memory usage since we started, which is a good progress and what was my point. The patches looked good to me as already discussed.

Sep 17 2018, 6:43 PM · Unknown Object (Project)

Sep 12 2018

Jakuje added a comment to T97: libssh sftp client is using unreasonable amount of memory.

I added my review to gitlab.

Sep 12 2018, 4:28 PM · Unknown Object (Project)

Aug 28 2018

Jakuje created T97: libssh sftp client is using unreasonable amount of memory.
Aug 28 2018, 5:14 PM · Unknown Object (Project)

Dec 24 2017

Jakuje added a comment to T80: torture_config_new test fails due to invalid session time out value caused by int pointer to long pointer cast.

Thank you for the bug report with verbose analysis of the problem. I see you are referencing that the fail was introduced by my commit, but it was just adding a test that uncovered this problem that existed for longer time (from 484564261?). Fortunately, this is not very common configuration option from my experience so there was probably not a lot harm caused so far.

Dec 24 2017, 12:16 AM