Page MenuHomePhabricator

Jakuje (Jakub Jelen)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 7 2017, 9:55 AM (118 w, 6 d)

Recent Activity

Thu, Feb 13

Jakuje added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

Thank you for confirmation that this combination works. But lets clarify what you do -- you are sending every X minutes the ignore or keepalive messages to keep the channel open, but even though you are getting disconnects after 30 minutes. I do not think this is anything in libssh. What are you running in the channels? Port forwarding? Some long-running commands transmitting or not transmitting data? Shells? How does this disconnect look like? Could it be the default value of $TMOUT in bash? Or something on the network layer terminating long-running connections?

Thu, Feb 13, 1:56 PM · Restricted Project

Tue, Feb 11

Jakuje committed rLIBSSH0dd71375e7fe: pki: fix `pki_key_ecdsa_to_key_type` thread-safety (authored by simonsj).
pki: fix `pki_key_ecdsa_to_key_type` thread-safety
Tue, Feb 11, 10:45 AM
Jakuje committed rLIBSSH3664ba2800ea: pki: fix `pki_key_ecdsa_to_key_type` thread-safety (authored by simonsj).
pki: fix `pki_key_ecdsa_to_key_type` thread-safety
Tue, Feb 11, 10:45 AM
Jakuje committed rLIBSSH17b518a677c9: pki: add support for sk-ecdsa and sk-ed25519 (authored by Sebastian Kinne <skinne@google.com>).
pki: add support for sk-ecdsa and sk-ed25519
Tue, Feb 11, 10:45 AM
Jakuje triaged T215: Implement client side support for u2f keys (including tests) as Normal priority.
Tue, Feb 11, 10:44 AM · Restricted Project
Jakuje added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

I am sorry for a delay.

Tue, Feb 11, 10:44 AM · Restricted Project

Wed, Jan 29

Jakuje added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

Hi @Jakuje ,
ssh_handle_packets() is not an exposed api .

Wed, Jan 29, 1:13 PM · Restricted Project
Jakuje added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

Hi,
the ssh_send_keepalive() does really only the sending. But the return value is ignored since 59ada799. But if the sending failed, the session state should be modified to reflect this if I am right. The response is handled as any other message in ssh_handle_packets() if I am right. The response is anyway SSH_MSG_REQUEST_FAILURE.

Wed, Jan 29, 11:11 AM · Restricted Project

Tue, Jan 28

Jakuje added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

Please, check the RFC 4253 describing this message: https://tools.ietf.org/html/rfc4253#section-11.2

Tue, Jan 28, 9:14 PM · Restricted Project

Mon, Jan 27

Jakuje triaged T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0 as Wishlist priority.
Mon, Jan 27, 11:50 AM · Restricted Project

Thu, Jan 23

Jakuje added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

One other possibility that could work would be TCPKeepAlive configuration option (from OpenSSH), which could handle this on TCP level (but might not work on all the networks configurations). So still, the first advice holds.

Thu, Jan 23, 11:38 AM · Restricted Project
Jakuje added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

This is not implemented inside of libssh now, but it can be simply implemented by your application that will send some data in your defined time intervals, for example using ssh_send_ignore().

Thu, Jan 23, 10:43 AM · Restricted Project
Jakuje committed rLIBSSH07f571f1c0db: Implement chacha20-poly1305 in mbedTLS (authored by Jakuje).
Implement chacha20-poly1305 in mbedTLS
Thu, Jan 23, 9:49 AM
Jakuje committed rLIBSSHac1c31bda162: tests: Skip chacha20-poly1305 tests in FIPS mode (authored by Jakuje).
tests: Skip chacha20-poly1305 tests in FIPS mode
Thu, Jan 23, 9:49 AM
Jakuje committed rLIBSSH60a987fd172f: Implement ChaCha20-poly1305 cipher using native OpenSSL (authored by Jakuje).
Implement ChaCha20-poly1305 cipher using native OpenSSL
Thu, Jan 23, 9:49 AM
Jakuje committed rLIBSSH94fe7634e13f: Do not build in internal chacha implementation if gcrypt supports that (authored by Jakuje).
Do not build in internal chacha implementation if gcrypt supports that
Thu, Jan 23, 9:49 AM
Jakuje committed rLIBSSH8670fb101bcb: chacha: Create common file to avoid code duplication (authored by Jakuje).
chacha: Create common file to avoid code duplication
Thu, Jan 23, 9:49 AM
Jakuje committed rLIBSSHe31e7b0406f4: packet_crypt: Check return values from AEAD deciphering (authored by Jakuje).
packet_crypt: Check return values from AEAD deciphering
Thu, Jan 23, 9:49 AM
Jakuje committed rLIBSSH6644f8ca3bab: curve25519: Avoid memory leaks (authored by Jakuje).
curve25519: Avoid memory leaks
Thu, Jan 23, 9:49 AM

Wed, Jan 22

Jakuje added a comment to T211: Regression introduced in commit e0e3636c60dd28fd358e47da2be132702ff8edc9 breaks libnetconf2.

This is follow-up from the mailing list [1], where we addressed one issue, but the second got lost and slipped from my radar.

Wed, Jan 22, 8:34 PM

Dec 28 2019

Jakuje added a comment to T210: Crash in libssh in canonical multipass due to certain entries in `~/.ssh/config`.

The backtrace in the attached issue points to the match block parsing:

0   libsystem_c.dylib             	0x00007fff6acc7b44 strcasecmp_l + 92
1   libssh.4.dylib                	0x0000000107d27bbe ssh_config_get_match_opcode + 78
2   libssh.4.dylib                	0x0000000107d2608b ssh_config_parse_line + 763
3   libssh.4.dylib                	0x0000000107d25cfa ssh_config_parse_file + 266
4   libssh.4.dylib                	0x0000000107d40806 ssh_options_parse_config + 262
5   libssh.4.dylib                	0x0000000107d248e4 ssh_connect + 292

if you have some other crash report, please let us know.

Dec 28 2019, 2:13 PM

Dec 27 2019

Jakuje added a comment to T210: Crash in libssh in canonical multipass due to certain entries in `~/.ssh/config`.

Without information about the libssh version, what configuration file was used (at least the offending match line), more verbose libssh logs (there is quite a lot of tracing logs around), it is hard to guess what went wrong with the parsing.

Dec 27 2019, 9:56 PM

Dec 19 2019

Jakuje added a comment to T200: Test torture_proxycommand fails on ubuntu 18.04.

OK, OpenSSH is using the $SHELL environment variable and since the CI runs in bash, this should be simple fix.

Dec 19 2019, 6:40 PM · Restricted Project
Jakuje added a comment to T200: Test torture_proxycommand fails on ubuntu 18.04.

ugh ... so I finally got down to the root cause of this issue. The proxycommand is executed in /bin/sh of the current user. In Fedora we have this symlinked to /bin/bash, while in Ubuntu, this is /bin/dash (sic ,,,). These two differ in a way how they handle environment variables. It looks like they are just ignored in dash. So the poor-man fix is the following in src/socket.c:

-    const char *args[] = {"/bin/sh", "-c", command, NULL};
+    const char *args[] = {"/bin/bash", "-c", command, NULL};

Better would be though to be able to

  • run the proxy command also in bash (very friendly)
  • run the proxy command in the users shell from passwd and set bash in passwd of tests (I think OpenSSH does that in cases where commands are executed) -- I like this one most
  • make sure the environment variables are passed through the shells in some more compatible way
Dec 19 2019, 6:35 PM · Restricted Project

Dec 18 2019

Jakuje added a comment to T200: Test torture_proxycommand fails on ubuntu 18.04.

The whole proxy_command test is mess ... in clean image it hangs for me also in Fedora.

Dec 18 2019, 5:02 PM · Restricted Project

Dec 17 2019

Jakuje added a comment to T200: Test torture_proxycommand fails on ubuntu 18.04.

reverting the previous comment -- it still fails with Ubuntu. But at least some of the bugs are fixed.

Dec 17 2019, 4:58 PM · Restricted Project

Dec 16 2019

Jakuje added a comment to T200: Test torture_proxycommand fails on ubuntu 18.04.

Back to the original issue. I just did clean build directory and I see also some issues with proxy command. And these are that ssh is prompting for hostkey verification. I think this is just because I did not run the rest of the tests (which accidentally create the known_hosts in the users directories). So using -o StrictHostKeyChecking=no in the ssh commandline as you propose might be the correct solution for this issue. I will check whether there will be more issues afterward.

Dec 16 2019, 3:59 PM · Restricted Project
Jakuje closed T180: tests: "bind: address already in use" as Resolved.

Closing as these symptoms really look like the same. If not, please reopen.

Dec 16 2019, 3:55 PM · Restricted Project
Jakuje added a comment to T180: tests: "bind: address already in use".

FYI, I think you might have been hitting also this issue which I recently fixed in master: https://gitlab.com/libssh/libssh-mirror/commit/d2a32ca6 It would be nice if you could check if the original issue got addressed.

Dec 16 2019, 3:47 PM · Restricted Project
Jakuje added a comment to T200: Test torture_proxycommand fails on ubuntu 18.04.

@aris Your test does not call session_setup() so that is the reason for this particular case failing to you. I think using the following will make it working for you:

Dec 16 2019, 2:46 PM · Restricted Project
Jakuje committed rLIBSSH251f60c031b2: curve25519: fix uninitialized arg to EVP_PKEY_derive (authored by simonsj).
curve25519: fix uninitialized arg to EVP_PKEY_derive
Dec 16 2019, 1:26 PM
Jakuje closed T205: ssh_curve25519_build_k: uninitialized input to `EVP_PKEY_derive` for HAVE_OPENSSL_X25519 builds can cause sporadic failure as Resolved.

Merged as b94ecf18 (before the phabricator will pick up the changeset).

Dec 16 2019, 1:25 PM

Dec 15 2019

Jakuje added a comment to T207: move ssh_key_dup() from pki.h to libssh.h?.

To my opinion, even we move ssh_key_dup() to libssh.h ,we also should duplicate ssh_key in function ssh_bind_options_set() , it is better to free memory apply by itself , not free memory applied by others

Dec 15 2019, 11:35 AM · Restricted Project
Jakuje added a comment to T206: Should we duplicate the sshkey when we use SSH_BIND_OPTIONS_IMPORT_KEY?.

The ssh_bind_options_set() does not duplicate the ssh_key structure as the server host key should not really be used for anything else than server key in normal use cases. Where else would you like to use the ssh server private key and what for?

Dec 15 2019, 10:22 AM · Restricted Project
Jakuje added a comment to T207: move ssh_key_dup() from pki.h to libssh.h?.

What is the use case where you needed the ssh_key_dup()?

Dec 15 2019, 10:05 AM · Restricted Project
Jakuje closed T209: SPAM as Invalid.

Sounds like a spam here recently. @asn Can we delete this one?

Dec 15 2019, 8:31 AM
Jakuje closed T208: SPAM as Invalid.

Sounds like a spam here recently. @asn Can we delete this one?

Dec 15 2019, 8:30 AM

Dec 11 2019

Jakuje closed T203: Contradictory Source Code Documentation: Return Code for libssh_destructor as Resolved by committing rLIBSSHb03818aaedf2: init: Fix documentation about return values of void functions.
Dec 11 2019, 11:15 AM
Jakuje committed rLIBSSHb03818aaedf2: init: Fix documentation about return values of void functions (authored by Jakuje).
init: Fix documentation about return values of void functions
Dec 11 2019, 11:15 AM

Dec 10 2019

Jakuje added a comment to T203: Contradictory Source Code Documentation: Return Code for libssh_destructor.

Thank you for the bug report. The same issue is here also with the constructor. It will be fixed with the following MR:

Dec 10 2019, 9:17 PM

Nov 25 2019

Jakuje closed T89: SFTP transfers handled by kio_sftp are much slower than those handled by scp as Resolved.

Thank you for testing the latest change. The throughput looks good now. Closing the issue.

Nov 25 2019, 1:24 PM · Restricted Project

Nov 21 2019

Jakuje added a comment to T200: Test torture_proxycommand fails on ubuntu 18.04.

Congratulation to the issue #200 :)

Nov 21 2019, 6:29 PM · Restricted Project
Jakuje added a comment to T180: tests: "bind: address already in use".

You are probably right. I was not able to reproduce it locally even from repetitive runs in the same container image with the same code.

Nov 21 2019, 6:15 PM · Restricted Project
Jakuje added a comment to T180: tests: "bind: address already in use".

Thanks. There are just a few nits I pointed out in the comments. The changes generally look good to me now and ready to merge (after the freeze -- see the email).

Nov 21 2019, 4:54 PM · Restricted Project

Nov 20 2019

Jakuje added a comment to T180: tests: "bind: address already in use".

Update: Your branch passes for me locally in container with OpenSSL now with last fix. But the commits still need some love before we can merge them. Will you have some time to touch that in coming days so we can add the ubuntu targets?

Nov 20 2019, 4:23 PM · Restricted Project
Jakuje added a comment to T180: tests: "bind: address already in use".

@aris I added the Ubuntu CI image, where I can successfully build libssh now:

Nov 20 2019, 4:07 PM · Restricted Project

Nov 11 2019

Jakuje closed T197: Putty cannot negotiate when the SSH Server adds an ED25519 key as Resolved.

This should be addressed in the latest release 0.9.2. Not sure why it was not auto-closed with the commit referenced above.

Nov 11 2019, 3:08 PM · Restricted Project

Nov 4 2019

Jakuje updated subscribers of T197: Putty cannot negotiate when the SSH Server adds an ED25519 key.

@ansasaki This looks directly related to the ed25519 support you modified to use OpenSSL. Can you check what might have gone wrong?

Nov 4 2019, 12:34 PM · Restricted Project
Jakuje added a comment to T180: tests: "bind: address already in use".

@aris your commits are missing Sign-off. I added my review. I also see many failed pkd tests in the last CI run with Fedora. Are they related to your changes?

Nov 4 2019, 12:33 PM · Restricted Project

Nov 1 2019

Jakuje added a comment to T191: Server incorrectly assumes rsa-sha2-256 when client meant standard ssh-rsa.

Sounds like an issue with the ed25519 keys then. Can you open a separate issue, since this is indeed different one than the reported above (RSA keys). Clarifying what openssl version are you using and whether it has enable support for ED25519 keys would help.

Nov 1 2019, 10:06 AM · Restricted Project

Oct 31 2019

Jakuje added a comment to T191: Server incorrectly assumes rsa-sha2-256 when client meant standard ssh-rsa.

This should be handled by the code in kex.c. It correctly sets the session->extensions bit field based on what is supported by the client in the key exchange. The problem here is that it informs only about the support of these extensions, but not about their priority and whether to prefer the SHA1 hash or the SHA2 ones. There is already attempt to detect whether the SHA256 or SHA519 was preferred, but this particular use case is not handled (what is the point in signaling that I know stronger algorithms, but prefer the SHA1?).

Oct 31 2019, 1:08 PM · Restricted Project

Oct 25 2019

Jakuje committed rLIBSSHe9e8292370ca: packet: On failure, do not use uninitialized crypto (authored by Jakuje).
packet: On failure, do not use uninitialized crypto
Oct 25 2019, 3:09 PM
Jakuje committed rLIBSSH5a0177def02d: packet_crypt: Avoid out of bounds access in debug functions (authored by Jakuje).
packet_crypt: Avoid out of bounds access in debug functions
Oct 25 2019, 3:08 PM
Jakuje committed rLIBSSH17952c495380: tests: Let shell resolve the absolute path to binaries in Exec tests (authored by Jakuje).
tests: Let shell resolve the absolute path to binaries in Exec tests
Oct 25 2019, 3:08 PM

Oct 10 2019

Jakuje added a comment to T178: Getting unexpected `remote channel is closed` after executing remote command.

Theory sounds right. Were you able to confirm this theory and fix your code to handle empty responses?

Oct 10 2019, 11:59 AM

Oct 1 2019

Jakuje committed rLIBSSH689f1b0a6b8a: callbacks: Improve documentation about callbacks handling (authored by Jakuje).
callbacks: Improve documentation about callbacks handling
Oct 1 2019, 10:29 AM
Jakuje committed rLIBSSHa22367fbe193: tests: Verify multiple match conditions can be present on a line (authored by Jakuje).
tests: Verify multiple match conditions can be present on a line
Oct 1 2019, 10:29 AM
Jakuje committed rLIBSSH46c3563da9a4: tests: Verify match exec keyword works on itself (authored by Jakuje).
tests: Verify match exec keyword works on itself
Oct 1 2019, 10:28 AM
Jakuje closed T103: ssh_set_channel_callbacks() does not create a copy of ssh_channel_callbacks_struct, while documentation implies otherwise as Resolved by committing rLIBSSH689f1b0a6b8a: callbacks: Improve documentation about callbacks handling.
Oct 1 2019, 10:28 AM · Restricted Project
Jakuje committed rLIBSSH349abe594290: config_parser: Implement more useful variant of get_token() (authored by Jakuje).
config_parser: Implement more useful variant of get_token()
Oct 1 2019, 10:28 AM
Jakuje committed rLIBSSHc7da113f1d27: tests: Verify functionality of low-level config parser functions (authored by Jakuje).
tests: Verify functionality of low-level config parser functions
Oct 1 2019, 10:28 AM
Jakuje committed rLIBSSHc983c994a2de: config: Implement match exec keyword (authored by Jakuje).
config: Implement match exec keyword
Oct 1 2019, 10:28 AM
Jakuje closed T169: Support multi-criteria Match like Match host `hostname` exec `statement` as Resolved by committing rLIBSSHc983c994a2de: config: Implement match exec keyword.
Oct 1 2019, 10:28 AM · Restricted Project

Sep 25 2019

Jakuje added a comment to T158: Use curve25519-sha256 from crypto libs if available.

I think this was addressed by https://gitlab.com/libssh/libssh-mirror/merge_requests/63 for OpenSSL.

Sep 25 2019, 4:19 PM · Restricted Project
Jakuje added a project to T174: pkd_hello fails for some host key types: Restricted Project.
Sep 25 2019, 4:09 PM · Restricted Project
Jakuje added a project to T103: ssh_set_channel_callbacks() does not create a copy of ssh_channel_callbacks_struct, while documentation implies otherwise: Restricted Project.

I think we should update the documentation so it is clear that the structure needs to be valid as long as the channel/session is valid.

Sep 25 2019, 4:00 PM · Restricted Project
Jakuje added a project to T177: Build error. Version 0.9.0 / 0.8.5: Restricted Project.
Sep 25 2019, 10:51 AM · Restricted Project

Sep 24 2019

Jakuje committed rLIBSSHaff7c500d572: buffer: Avoid use of uninitialized values (authored by Jakuje).
buffer: Avoid use of uninitialized values
Sep 24 2019, 4:50 PM
Jakuje committed rLIBSSHe72429f205bd: buffer: Simplify handling of the return codes (authored by Jakuje).
buffer: Simplify handling of the return codes
Sep 24 2019, 4:50 PM
Jakuje committed rLIBSSHaac682f60ea8: dh-gex: Correctly free modulus and generator with openssl (authored by Jakuje).
dh-gex: Correctly free modulus and generator with openssl
Sep 24 2019, 4:50 PM
Jakuje committed rLIBSSH2f05243a4a7b: channels: Correctly reports failed channels opening (authored by Jakuje).
channels: Correctly reports failed channels opening
Sep 24 2019, 4:50 PM
Jakuje closed T176: I have upgraded libssh from 0.7.6 to 0.9.0 to use diffie-hellman-group-exchange-sha256 kex algo both in client and server, but I found that memory leak , see details as Resolved by committing rLIBSSHaac682f60ea8: dh-gex: Correctly free modulus and generator with openssl.
Sep 24 2019, 4:50 PM · Restricted Project
Jakuje committed rLIBSSH89a9eb8811da: Reformat channel_open() (authored by Jakuje).
Reformat channel_open()
Sep 24 2019, 4:49 PM
Jakuje closed T75: OpenSSH : ssh_channel_new and ssh_channel_open_session blocks when we reach MaxSessions limit as Resolved by committing rLIBSSH2f05243a4a7b: channels: Correctly reports failed channels opening.
Sep 24 2019, 4:49 PM · Restricted Project
Jakuje committed rLIBSSH3cf2b41f5eaf: channels: Do not use deprecated functions in the example code (authored by Jakuje).
channels: Do not use deprecated functions in the example code
Sep 24 2019, 4:49 PM
Jakuje committed rLIBSSH223cc9623992: options: Do not attempt to expand percents in PKCS#11 URIs (authored by Jakuje).
options: Do not attempt to expand percents in PKCS#11 URIs
Sep 24 2019, 4:49 PM
Jakuje committed rLIBSSH61b1e0e7e99e: tests: Verify the localuser match works (authored by Jakuje).
tests: Verify the localuser match works
Sep 24 2019, 4:49 PM
Jakuje committed rLIBSSH6500134259c4: config: Support match localuser (authored by Jakuje).
config: Support match localuser
Sep 24 2019, 4:49 PM
Jakuje committed rLIBSSH9b8b312b88ee: config: Make the matching case sensitive as documented in ssh_config manual… (authored by Jakuje).
config: Make the matching case sensitive as documented in ssh_config manual…
Sep 24 2019, 4:49 PM
Jakuje added a comment to T177: Build error. Version 0.9.0 / 0.8.5.

The first issue was fixed in 65bc24d8 which is already in libssh 0.9 release. The second is probably fixed by 58113d48, which is also part of 0.9 release. Can you retest with 0.9?

Sep 24 2019, 1:03 PM · Restricted Project

Sep 20 2019

Jakuje added a comment to T175: Building v9.0.0 with gcc 7.4.0 fails..

Can you clarify on what platform you are experiencing these issues?

Sep 20 2019, 3:05 PM · Restricted Project
Jakuje updated subscribers of T176: I have upgraded libssh from 0.7.6 to 0.9.0 to use diffie-hellman-group-exchange-sha256 kex algo both in client and server, but I found that memory leak , see details.

Thank you for the bug report. Indeed, the handling of the modulus and generator is wrong. These bignums are copied in the ssh_dh_set_parameters() into the keypair structures (when using openssl backend), but the calling function did not free them as expected. Also the handling of errors was wrong in case of some failures checking them.

Sep 20 2019, 1:26 PM · Restricted Project

Sep 19 2019

Jakuje added a comment to T174: pkd_hello fails for some host key types.

The tests/pkd/pkd_util.c already parses the openssh version so it can be used with a bit of refactoring. Or you can adjust the tests/CMakeLists.txt to expose the already-collected versions also the pkd tests and allow these alogirhtms only on the newer openssh.

Sep 19 2019, 5:32 PM · Restricted Project

Sep 18 2019

Jakuje updated subscribers of T75: OpenSSH : ssh_channel_new and ssh_channel_open_session blocks when we reach MaxSessions limit.

Thank you for testing. Whether and where to list your perl bindings in the main page, that is more up to @asn, but I do not think it should be a problem.

Sep 18 2019, 10:43 AM · Restricted Project

Sep 17 2019

Jakuje added a comment to T75: OpenSSH : ssh_channel_new and ssh_channel_open_session blocks when we reach MaxSessions limit.

Thank you for the reproducer. I can confirm and reproduce with your attached code. This is the backtrace:

#0  0x00007f8df8576c10 in __poll_nocancel () from /lib64/libc.so.6
#1  0x00007f8df14d58c0 in ssh_poll () from /lib64/libssh.so.4
#2  0x00007f8df14d6033 in ssh_poll_ctx_dopoll () from /lib64/libssh.so.4
#3  0x00007f8df14d798c in ssh_handle_packets () from /lib64/libssh.so.4
#4  0x00007f8df14d7a93 in ssh_handle_packets_termination () from /lib64/libssh.so.4
#5  0x00007f8df14ae889 in channel_request () from /lib64/libssh.so.4
#6  0x00007f8df14afa6b in ssh_channel_request_exec () from /lib64/libssh.so.4
#7  0x00007f8df1740837 in XS_Libssh__Session_ssh_channel_request_exec ()
   from /usr/lib64/perl5/vendor_perl/auto/Libssh/Session/Session.so
#8  0x00007f8df989c41f in Perl_pp_entersub () from /usr/lib64/perl5/CORE/libperl.so
#9  0x00007f8df9894b96 in Perl_runops_standard () from /usr/lib64/perl5/CORE/libperl.so
#10 0x00007f8df9831985 in perl_run () from /usr/lib64/perl5/CORE/libperl.so
#11 0x0000000000400ce9 in main ()

In the server, log the event of failed session opening is visible here:

Sep 17 14:59:42 jjelen-rhel-7.3 sshd[1553]: debug1: channel 10: new [server-session]
Sep 17 14:59:42 jjelen-rhel-7.3 sshd[1553]: debug1: session_open: channel 10
Sep 17 14:59:42 jjelen-rhel-7.3 sshd[1553]: error: no more sessions
Sep 17 14:59:42 jjelen-rhel-7.3 sshd[1553]: debug1: session open failed, free channel 10
Sep 17 14:59:42 jjelen-rhel-7.3 sshd[1553]: debug1: channel 10: free: server-session, nchannels 11
Sep 17 14:59:42 jjelen-rhel-7.3 sshd[1553]: debug3: channel 10: status: The following connections are open:\r\n ...
Sep 17 14:59:42 jjelen-rhel-7.3 sshd[1553]: debug1: server_input_channel_open: failure session
Sep 17 2019, 4:46 PM · Restricted Project

Sep 16 2019

Jakuje claimed T169: Support multi-criteria Match like Match host `hostname` exec `statement`.

I implemented the match exec. Can you try if it works for you as expected in your use case? There are several commits adjusting the tests and as well as I had to implement new token parsing function, but my basic tests looked good. This code also does not work on windows since I am not Windows developer, but if interested, I believe there will be somebody who could implement that.

Sep 16 2019, 6:11 PM · Restricted Project
Jakuje closed T165: 0.9.0 gcc compiler warnings deprecated-declarations as Resolved.
Sep 16 2019, 12:56 PM · Restricted Project
Jakuje closed T137: Difference between sftp_new() and sftp_init() is not clear as Resolved.
Sep 16 2019, 12:56 PM · Restricted Project
Jakuje closed T142: torture_proxycommand failing as Resolved.

The original issue should be resolved in master now.

Sep 16 2019, 12:56 PM · Restricted Project
Jakuje committed rLIBSSH4900ab6ca9a0: Skip the proxycommand test in case the netcat is not avaliable (authored by Jakuje).
Skip the proxycommand test in case the netcat is not avaliable
Sep 16 2019, 12:44 PM
Jakuje committed rLIBSSH83fa060cec0f: known_hosts: Avoid using deprecated functions (even from deprecated functions) (authored by Jakuje).
known_hosts: Avoid using deprecated functions (even from deprecated functions)
Sep 16 2019, 12:44 PM
Jakuje committed rLIBSSH618b858e49ce: sftp: Improve the documentation of sftp_init() and sftp_new() (authored by Jakuje).
sftp: Improve the documentation of sftp_init() and sftp_new()
Sep 16 2019, 12:44 PM
Jakuje added a project to T172: libssh 0.8.7 failed to build in debug mode with openssl 1.1.1c: Restricted Project.
Sep 16 2019, 9:49 AM · Restricted Project
Jakuje added a project to T175: Building v9.0.0 with gcc 7.4.0 fails.: Restricted Project.
Sep 16 2019, 9:47 AM · Restricted Project
Jakuje added a comment to T142: torture_proxycommand failing.

Aris, can you open a new bug for this, ideally with more debug information as proposed by @ansasaki?

Sep 16 2019, 9:42 AM · Restricted Project

Sep 13 2019

Jakuje added a comment to T142: torture_proxycommand failing.

Can you check the following patch if t addresses the issue for you?

Sep 13 2019, 5:41 PM · Restricted Project
Jakuje added a comment to T142: torture_proxycommand failing.

I am getting exactly the same result as the OP when I remove the /usr/bin/nc, which is used in the respective failing test so I assume that this is the issue, but the error should be more properly reported and the test probably skipped in case the netcat is not in place. I will submit a patch.

Sep 13 2019, 5:30 PM · Restricted Project
Jakuje added a comment to T142: torture_proxycommand failing.

Thank you for having a look into that. In that case, I am wondering why it did work for me and for the CI we run, but I think most of that is on Fedora, which might be a difference. Can you check whether the netcat (nc) is installed in your system?

Sep 13 2019, 5:23 PM · Restricted Project
Jakuje added a comment to T75: OpenSSH : ssh_channel_new and ssh_channel_open_session blocks when we reach MaxSessions limit.

I just tested the ssh-client from examples, which is using channel_open with sshd configured with MaxSessions 0 and it is correctly failing and not hanging for me. Can you test with current libssh master or 0.9 and provide more ellaborate reproducer?

Sep 13 2019, 2:59 PM · Restricted Project
Jakuje added a comment to T137: Difference between sftp_new() and sftp_init() is not clear.

The file doc/sftp.dox contains the following information (not sure whether it is rendered somewhere on the web):

Sep 13 2019, 2:47 PM · Restricted Project