Page MenuHomePhabricator

Jakuje (Jakub Jelen)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 7 2017, 9:55 AM (139 w, 6 d)

Recent Activity

Sat, Jul 11

Jakuje added a comment to T237: ssh_packet_disconnect_callback: Received SSH_MSG_DISCONNECT 3:invalid DH value.

We test interoperability with OpenSSH so our implementation is compatible with OpenSSH one. So either we both are wrong or the srtSSHServer_11.00 is wrong. I would recommend you either check the server side for more logs or errors and/or contact the vendor/support of the server that you have this issue. It should be trivial for them to reproduce/debug the issue as libssh and openssh are opensource and they can reliably reproduce the issue. From just this log, we can hardly guess what the blackbox server does not like on this key exchange method implementation.

Sat, Jul 11, 10:09 AM

Wed, Jul 8

Jakuje added a comment to T237: ssh_packet_disconnect_callback: Received SSH_MSG_DISCONNECT 3:invalid DH value.

Thanks for confirmation. Even though you can not change the server settings, there might be something useful in the logs pointing out what is the issue. It could be bug in srtSSHServer implementation or libssh implementation of the new diffie-hellman-group18-sha512 so it is worth investigating.

Wed, Jul 8, 8:01 AM

Tue, Jul 7

Jakuje added a comment to T237: ssh_packet_disconnect_callback: Received SSH_MSG_DISCONNECT 3:invalid DH value.

This is an issue of key exchange, not ciphres. The original trace is using probably diffie-hellman-group14-sha1 and the new one diffie-hellman-group18-sha512. The error invalid DH value comes from the server so I would suggest continuing some investigation there, figuring out what it does not like on the provided DH value.

Tue, Jul 7, 5:02 PM

Wed, Jul 1

Jakuje created T236: Disable *-cbc ciphers by default.
Wed, Jul 1, 6:45 PM · Restricted Project

Tue, Jun 30

Jakuje added a comment to T235: Consider libsodium as an alternative to nacl.

I do not think nacl is used for anything at this moment when libssh is built against current openssl, which already supports X25519 curve for all we need. At least in Fedora, nacl is not listed as dependency of libssh at all.

Tue, Jun 30, 12:55 PM

Thu, Jun 18

Jakuje added a comment to T231: ssh_channel_read() incorrectly returns -1 (SSH_ERROR).

Thank you for checking. It looks like I was too fast guessing the fix.

Thu, Jun 18, 4:17 PM

Jun 10 2020

Jakuje added a comment to T234: SCP pull wildcard returns No such file or directory.

Sounds like a mitigation to some of the security issues fixed in 0.9.3. See the announcement message for more details:

Jun 10 2020, 7:40 PM

Jun 9 2020

Jakuje updated subscribers of T233: With libssh 0.9.4 the open session hangs when the maxAuthtries is reached.

Playing a bit more with that, it looks like a version 8.7.0 returns SSH_AUTH_AGAIN from ssh_userauth_none(), even though it is in blocking mode. It is certainly not correct, but better than not returning at all. But only after a timeout, which it spends in busy-loop wait.

Jun 9 2020, 4:33 PM

Jun 8 2020

Jakuje added a comment to T233: With libssh 0.9.4 the open session hangs when the maxAuthtries is reached.

I am able to reproduce this locally. The server sends SSH_MSG_DISCONNECT to the client, but in the ssh_userauth_get_response(), this message is not accepted to terminate waiting for answer from server in ssh_auth_response_termination() so it hangs forever in the poll -- I think this is a bug in poll implementation, which should stop waiting after receiving disconnect.

Jun 8 2020, 1:10 PM

May 25 2020

Jakuje added a comment to T231: ssh_channel_read() incorrectly returns -1 (SSH_ERROR).

Right. It affects only 0.9.x versions. The above commit mentions which revision introduced this issue. The commit is already backported in the stable-0.9 branch so it will be in the next 0.9.5 release

May 25 2020, 6:56 PM
Jakuje committed rLIBSSH39bb93a53b77: options: Do not reference non-existing function (authored by Jakuje).
options: Do not reference non-existing function
May 25 2020, 2:00 PM
Jakuje committed rLIBSSH866e4442b529: Removed old, 10 years unused test files (authored by Jakuje).
Removed old, 10 years unused test files
May 25 2020, 2:00 PM
Jakuje closed T227: `ssh_options_parse_config()` mentions non-existent `ssh_options_set_host()` as Resolved by committing rLIBSSH39bb93a53b77: options: Do not reference non-existing function.
May 25 2020, 2:00 PM · Restricted Project
Jakuje added a comment to T231: ssh_channel_read() incorrectly returns -1 (SSH_ERROR).

Could it be a duplicate of an issue described and fixed in this commit [1]? It was also discussed in mailing list recently. Does it work with current master?

May 25 2020, 12:44 PM

May 21 2020

Jakuje claimed T227: `ssh_options_parse_config()` mentions non-existent `ssh_options_set_host()`.
May 21 2020, 1:30 PM · Restricted Project
Jakuje closed T223: libssh crashes when ecdsa pkcs #11 private keys are imported without importing ecdsa pkcs #11 public keys as Resolved.

Merged as 4e4711d2 and friends.

May 21 2020, 11:51 AM · Restricted Project
Jakuje closed T225: Missing #include makes that compiling example fails as Resolved.

Fixed in previously mentioned commits.

May 21 2020, 11:29 AM · Restricted Project

May 7 2020

Jakuje closed T85: missing cipher 'none' as Resolved.

FYI, this landed as e6aee24a

May 7 2020, 6:53 PM · Restricted Project

May 6 2020

Jakuje triaged T230: OpenSSL memory sanity check as Wishlist priority.
May 6 2020, 11:51 AM · Restricted Project

Apr 24 2020

Jakuje committed rLIBSSH99e0ad75a6d1: tests: add testcases for ssh_channel_poll_timeout() (authored by Heiko Thiery <heiko.thiery@gmail.com>).
tests: add testcases for ssh_channel_poll_timeout()
Apr 24 2020, 4:17 PM
Jakuje committed rLIBSSHe76332bbd617: session: add missing return value documentation (authored by Heiko Thiery <heiko.thiery@gmail.com>).
session: add missing return value documentation
Apr 24 2020, 4:17 PM

Apr 22 2020

Jakuje added a comment to T227: `ssh_options_parse_config()` mentions non-existent `ssh_options_set_host()`.

It is still needed as the configuration parsing requires the hostname to evaluate conditional match blocks. But the new API ssh_options_set() should be used and documentation updated accordingly. The documentation should also mention that if it is not called, it is called automatically on connect.

Apr 22 2020, 9:05 PM · Restricted Project

Apr 21 2020

Jakuje closed T218: Disable ssh-rsa (sha1) keys by default as Resolved.

The previously mentioned commit disables the RSA-SHA1 and DSA algorithms by default.

Apr 21 2020, 5:18 PM · Restricted Project

Apr 20 2020

Jakuje committed rLIBSSH154765ae8ca5: config: Check null deref (authored by Jakuje).
config: Check null deref
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH6417f5a3cac8: channels: Avoid returning SSH_AGAIN from ssh_channel_poll_timeout() (authored by Jakuje).
channels: Avoid returning SSH_AGAIN from ssh_channel_poll_timeout()
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSHfe0fcbbc67e3: channels: reformat (authored by Jakuje).
channels: reformat
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSHc2f64108a152: examples: Avoid unused parameter warnings and reformat (authored by Jakuje).
examples: Avoid unused parameter warnings and reformat
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH59ac79c4dcdf: gitlab-ci: Avoid passing artifacts between completely unrelated stages (authored by Jakuje).
gitlab-ci: Avoid passing artifacts between completely unrelated stages
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH7f57717f84f0: gitlab-ci: Fix typo (authored by Jakuje).
gitlab-ci: Fix typo
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSHdb948bdac87e: tests: Enable RSA SHA1 certs for testing against older OpenSSH (authored by Jakuje).
tests: Enable RSA SHA1 certs for testing against older OpenSSH
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH6941958b4954: tests: Update coverage of config_parser (authored by Jakuje).
tests: Update coverage of config_parser
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH1ba6ef689fe7: config_parser: Allow equal sign as a separator and eat up trailing whitespace (authored by Jakuje).
config_parser: Allow equal sign as a separator and eat up trailing whitespace
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSHfecdc3cc0e6d: Disable RSA and DSA keys with sha1 by default (authored by Jakuje).
Disable RSA and DSA keys with sha1 by default
Apr 20 2020, 2:43 PM
Jakuje closed T210: Crash in libssh in canonical multipass due to certain entries in `~/.ssh/config` as Resolved by committing rLIBSSH1ba6ef689fe7: config_parser: Allow equal sign as a separator and eat up trailing whitespace.
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH04ae110c612f: pkd: Enable all hostkeys (authored by Jakuje).
pkd: Enable all hostkeys
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH9ac2d1470763: tests: Enable all host key algorithms in testing client (authored by Jakuje).
tests: Enable all host key algorithms in testing client
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSHbab2c775da62: Make the testing ping use all supported algorithms (authored by Jakuje).
Make the testing ping use all supported algorithms
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH58d53f1397c9: examples: Add missing includes (authored by Jakuje).
examples: Add missing includes
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH945829a5dd3d: Reformat ssh_bind_accept() (authored by Jakuje).
Reformat ssh_bind_accept()
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSHeebb02fff52c: libcrypto-compat: Fix indentation and return value (authored by Jakuje).
libcrypto-compat: Fix indentation and return value
Apr 20 2020, 2:42 PM
Jakuje committed rLIBSSH70478619cec7: libcrypto-compat: add extra functions (authored by Rosen Penev <rosenp@gmail.com>).
libcrypto-compat: add extra functions
Apr 20 2020, 2:42 PM
Jakuje committed rLIBSSH54296787a79e: libcrypto: remove deprecated API usage (authored by Rosen Penev <rosenp@gmail.com>).
libcrypto: remove deprecated API usage
Apr 20 2020, 2:42 PM

Apr 16 2020

Jakuje closed T174: pkd_hello fails for some host key types as Resolved.

AFAIK this was already addressed by using ssh -Q to query openssh supported algorithms and we have ubuntu 18.04 in CI to prevent similar issues in future.

Apr 16 2020, 12:41 PM · Restricted Project
Jakuje added a project to T92: Usage of `strerror` is not thread-safe: Restricted Project.
Apr 16 2020, 12:37 PM · Restricted Project
Jakuje triaged T171: Allow specifiying algorithms in configuration file by adding or removing algorithms from default as Wishlist priority.
Apr 16 2020, 12:18 PM
Jakuje added a comment to T172: libssh 0.8.7 failed to build in debug mode with openssl 1.1.1c.

Looks like the CI is running VS2017, which has still openssl 1.0.2. Would be nice to run against something supported.

Apr 16 2020, 12:12 PM · Restricted Project
Jakuje claimed T173: v9.0 example and cpp wrappers returning -1 on ssh_channel_read and ssh_channel_read_timeout.

This sounds like an issue discussed in [1]. Can you check if it still happens with the current master + proposed fixes?

Apr 16 2020, 11:21 AM · Restricted Project
Jakuje added a comment to T175: Building v9.0.0 with gcc 7.4.0 fails..

This has changed recently in master with commit 742d81ec. Can you check if you can still reproduce the issue with the referenced commit/master/

Apr 16 2020, 10:12 AM · Restricted Project
Jakuje closed T177: Build error. Version 0.9.0 / 0.8.5 as Resolved.

I believe this is fixed in current versions. If not, please reopen.

Apr 16 2020, 10:07 AM · Restricted Project
Jakuje added a comment to T192: Reusing a session results in timeout at user_auth_password.

AFAIK, this was fixed with T194. Can you recheck if you can still reproduce the issue with latest release/master?

Apr 16 2020, 10:01 AM · Restricted Project
Jakuje added a project to T201: compiling libssh 0.9.2 on Solaris 11: Restricted Project.
Apr 16 2020, 9:59 AM · Restricted Project
Jakuje added a comment to T201: compiling libssh 0.9.2 on Solaris 11.

The example is missing the includes as mentioned in T225:

Apr 16 2020, 9:58 AM · Restricted Project
Jakuje added a comment to T221: Access violation crash in static build in windows.

Some backtrace of the crash would be useful.

Apr 16 2020, 9:50 AM

Apr 15 2020

Jakuje committed rLIBSSHa881c318ac27: Fix FTBFS on hurd-i386 (authored by bigon).
Fix FTBFS on hurd-i386
Apr 15 2020, 2:56 PM
Jakuje committed rLIBSSH5f1d0c4795ed: Make the documentation reproducible (authored by bigon).
Make the documentation reproducible
Apr 15 2020, 2:56 PM
Jakuje committed rLIBSSH1ff6dda616ec: Correctly parse v4 subsecond timestamps (authored by StefanBruens).
Correctly parse v4 subsecond timestamps
Apr 15 2020, 2:56 PM
Jakuje closed T219: Parsing of SUBSECOND_TIMES wrong as Resolved by committing rLIBSSH1ff6dda616ec: Correctly parse v4 subsecond timestamps.
Apr 15 2020, 2:56 PM

Apr 14 2020

Jakuje claimed T210: Crash in libssh in canonical multipass due to certain entries in `~/.ssh/config`.

Seems like the linked multipass issue is fixed now. I am wondering why it was done by the change of the SSH_OPTIONS_SSH_DIR instead of SSH_OPTIONS_PROCESS_CONFIG which would prevent configuration parsing altogether.

Apr 14 2020, 6:49 PM

Apr 9 2020

Jakuje added a comment to T219: Parsing of SUBSECOND_TIMES wrong.

Can you submit the merge request on gitlab, where we can see results of the CI run?

Apr 9 2020, 7:03 PM
Jakuje triaged T220: Opening sftp fails in non-blocking mode as Low priority.

Thank you for the report. You are right, this does not look like covered by any existing test case. The only one covered is the blocking mode in tests/client/torture_sftp_read.c. Contributions are always welcomed.

Apr 9 2020, 6:56 PM · Restricted Project
Jakuje added a comment to T224: Unable to distinguish between real error and child-process interrupts when ssh_bind_accept() returns.
In T224#3742, @orionltd wrote:
fd = accept(sshbind->bindfd, NULL, NULL);
if (fd == SSH_INVALID_SOCKET) {
  if (errno == EINTR) {
    ssh_set_error(sshbind, SSH_EINTR,
        "Accepting a new connection (child signal error): %s",
        strerror(errno));
Apr 9 2020, 12:26 PM · Restricted Project
Jakuje claimed T225: Missing #include makes that compiling example fails.

Can you check the following commit solves your problems:

Apr 9 2020, 11:49 AM · Restricted Project

Feb 18 2020

Jakuje closed T214: pki_key_ecdsa_to_key_type helpers use thread-unsafe static local as Resolved.

The above commits from @simonsj fixed this issue.

Feb 18 2020, 12:53 PM

Feb 13 2020

Jakuje added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

Thank you for confirmation that this combination works. But lets clarify what you do -- you are sending every X minutes the ignore or keepalive messages to keep the channel open, but even though you are getting disconnects after 30 minutes. I do not think this is anything in libssh. What are you running in the channels? Port forwarding? Some long-running commands transmitting or not transmitting data? Shells? How does this disconnect look like? Could it be the default value of $TMOUT in bash? Or something on the network layer terminating long-running connections?

Feb 13 2020, 1:56 PM · Restricted Project

Feb 11 2020

Jakuje committed rLIBSSH0dd71375e7fe: pki: fix `pki_key_ecdsa_to_key_type` thread-safety (authored by simonsj).
pki: fix `pki_key_ecdsa_to_key_type` thread-safety
Feb 11 2020, 10:45 AM
Jakuje committed rLIBSSH3664ba2800ea: pki: fix `pki_key_ecdsa_to_key_type` thread-safety (authored by simonsj).
pki: fix `pki_key_ecdsa_to_key_type` thread-safety
Feb 11 2020, 10:45 AM
Jakuje committed rLIBSSH17b518a677c9: pki: add support for sk-ecdsa and sk-ed25519 (authored by Sebastian Kinne <skinne@google.com>).
pki: add support for sk-ecdsa and sk-ed25519
Feb 11 2020, 10:45 AM
Jakuje triaged T215: Implement client side support for u2f keys (including tests) as Normal priority.
Feb 11 2020, 10:44 AM · Restricted Project
Jakuje added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

I am sorry for a delay.

Feb 11 2020, 10:44 AM · Restricted Project

Jan 29 2020

Jakuje added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

Hi @Jakuje ,
ssh_handle_packets() is not an exposed api .

Jan 29 2020, 1:13 PM · Restricted Project
Jakuje added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

Hi,
the ssh_send_keepalive() does really only the sending. But the return value is ignored since 59ada799. But if the sending failed, the session state should be modified to reflect this if I am right. The response is handled as any other message in ssh_handle_packets() if I am right. The response is anyway SSH_MSG_REQUEST_FAILURE.

Jan 29 2020, 11:11 AM · Restricted Project

Jan 28 2020

Jakuje added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

Please, check the RFC 4253 describing this message: https://tools.ietf.org/html/rfc4253#section-11.2

Jan 28 2020, 9:14 PM · Restricted Project

Jan 27 2020

Jakuje triaged T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0 as Wishlist priority.
Jan 27 2020, 11:50 AM · Restricted Project

Jan 23 2020

Jakuje added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

One other possibility that could work would be TCPKeepAlive configuration option (from OpenSSH), which could handle this on TCP level (but might not work on all the networks configurations). So still, the first advice holds.

Jan 23 2020, 11:38 AM · Restricted Project
Jakuje added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

This is not implemented inside of libssh now, but it can be simply implemented by your application that will send some data in your defined time intervals, for example using ssh_send_ignore().

Jan 23 2020, 10:43 AM · Restricted Project
Jakuje committed rLIBSSH07f571f1c0db: Implement chacha20-poly1305 in mbedTLS (authored by Jakuje).
Implement chacha20-poly1305 in mbedTLS
Jan 23 2020, 9:49 AM
Jakuje committed rLIBSSHac1c31bda162: tests: Skip chacha20-poly1305 tests in FIPS mode (authored by Jakuje).
tests: Skip chacha20-poly1305 tests in FIPS mode
Jan 23 2020, 9:49 AM
Jakuje committed rLIBSSH60a987fd172f: Implement ChaCha20-poly1305 cipher using native OpenSSL (authored by Jakuje).
Implement ChaCha20-poly1305 cipher using native OpenSSL
Jan 23 2020, 9:49 AM
Jakuje committed rLIBSSH94fe7634e13f: Do not build in internal chacha implementation if gcrypt supports that (authored by Jakuje).
Do not build in internal chacha implementation if gcrypt supports that
Jan 23 2020, 9:49 AM
Jakuje committed rLIBSSH8670fb101bcb: chacha: Create common file to avoid code duplication (authored by Jakuje).
chacha: Create common file to avoid code duplication
Jan 23 2020, 9:49 AM
Jakuje committed rLIBSSHe31e7b0406f4: packet_crypt: Check return values from AEAD deciphering (authored by Jakuje).
packet_crypt: Check return values from AEAD deciphering
Jan 23 2020, 9:49 AM
Jakuje committed rLIBSSH6644f8ca3bab: curve25519: Avoid memory leaks (authored by Jakuje).
curve25519: Avoid memory leaks
Jan 23 2020, 9:49 AM

Jan 22 2020

Jakuje added a comment to T211: Regression introduced in commit e0e3636c60dd28fd358e47da2be132702ff8edc9 breaks libnetconf2.

This is follow-up from the mailing list [1], where we addressed one issue, but the second got lost and slipped from my radar.

Jan 22 2020, 8:34 PM

Dec 28 2019

Jakuje added a comment to T210: Crash in libssh in canonical multipass due to certain entries in `~/.ssh/config`.

The backtrace in the attached issue points to the match block parsing:

0   libsystem_c.dylib             	0x00007fff6acc7b44 strcasecmp_l + 92
1   libssh.4.dylib                	0x0000000107d27bbe ssh_config_get_match_opcode + 78
2   libssh.4.dylib                	0x0000000107d2608b ssh_config_parse_line + 763
3   libssh.4.dylib                	0x0000000107d25cfa ssh_config_parse_file + 266
4   libssh.4.dylib                	0x0000000107d40806 ssh_options_parse_config + 262
5   libssh.4.dylib                	0x0000000107d248e4 ssh_connect + 292

if you have some other crash report, please let us know.

Dec 28 2019, 2:13 PM

Dec 27 2019

Jakuje added a comment to T210: Crash in libssh in canonical multipass due to certain entries in `~/.ssh/config`.

Without information about the libssh version, what configuration file was used (at least the offending match line), more verbose libssh logs (there is quite a lot of tracing logs around), it is hard to guess what went wrong with the parsing.

Dec 27 2019, 9:56 PM

Dec 19 2019

Jakuje added a comment to T200: Test torture_proxycommand fails on ubuntu 18.04.

OK, OpenSSH is using the $SHELL environment variable and since the CI runs in bash, this should be simple fix.

Dec 19 2019, 6:40 PM · Restricted Project
Jakuje added a comment to T200: Test torture_proxycommand fails on ubuntu 18.04.

ugh ... so I finally got down to the root cause of this issue. The proxycommand is executed in /bin/sh of the current user. In Fedora we have this symlinked to /bin/bash, while in Ubuntu, this is /bin/dash (sic ,,,). These two differ in a way how they handle environment variables. It looks like they are just ignored in dash. So the poor-man fix is the following in src/socket.c:

-    const char *args[] = {"/bin/sh", "-c", command, NULL};
+    const char *args[] = {"/bin/bash", "-c", command, NULL};

Better would be though to be able to

  • run the proxy command also in bash (very friendly)
  • run the proxy command in the users shell from passwd and set bash in passwd of tests (I think OpenSSH does that in cases where commands are executed) -- I like this one most
  • make sure the environment variables are passed through the shells in some more compatible way
Dec 19 2019, 6:35 PM · Restricted Project

Dec 18 2019

Jakuje added a comment to T200: Test torture_proxycommand fails on ubuntu 18.04.

The whole proxy_command test is mess ... in clean image it hangs for me also in Fedora.

Dec 18 2019, 5:02 PM · Restricted Project

Dec 17 2019

Jakuje added a comment to T200: Test torture_proxycommand fails on ubuntu 18.04.

reverting the previous comment -- it still fails with Ubuntu. But at least some of the bugs are fixed.

Dec 17 2019, 4:58 PM · Restricted Project

Dec 16 2019

Jakuje added a comment to T200: Test torture_proxycommand fails on ubuntu 18.04.

Back to the original issue. I just did clean build directory and I see also some issues with proxy command. And these are that ssh is prompting for hostkey verification. I think this is just because I did not run the rest of the tests (which accidentally create the known_hosts in the users directories). So using -o StrictHostKeyChecking=no in the ssh commandline as you propose might be the correct solution for this issue. I will check whether there will be more issues afterward.

Dec 16 2019, 3:59 PM · Restricted Project
Jakuje closed T180: tests: "bind: address already in use" as Resolved.

Closing as these symptoms really look like the same. If not, please reopen.

Dec 16 2019, 3:55 PM · Restricted Project
Jakuje added a comment to T180: tests: "bind: address already in use".

FYI, I think you might have been hitting also this issue which I recently fixed in master: https://gitlab.com/libssh/libssh-mirror/commit/d2a32ca6 It would be nice if you could check if the original issue got addressed.

Dec 16 2019, 3:47 PM · Restricted Project
Jakuje added a comment to T200: Test torture_proxycommand fails on ubuntu 18.04.

@aris Your test does not call session_setup() so that is the reason for this particular case failing to you. I think using the following will make it working for you:

Dec 16 2019, 2:46 PM · Restricted Project
Jakuje committed rLIBSSH251f60c031b2: curve25519: fix uninitialized arg to EVP_PKEY_derive (authored by simonsj).
curve25519: fix uninitialized arg to EVP_PKEY_derive
Dec 16 2019, 1:26 PM
Jakuje closed T205: ssh_curve25519_build_k: uninitialized input to `EVP_PKEY_derive` for HAVE_OPENSSL_X25519 builds can cause sporadic failure as Resolved.

Merged as b94ecf18 (before the phabricator will pick up the changeset).

Dec 16 2019, 1:25 PM

Dec 15 2019

Jakuje added a comment to T207: move ssh_key_dup() from pki.h to libssh.h?.

To my opinion, even we move ssh_key_dup() to libssh.h ,we also should duplicate ssh_key in function ssh_bind_options_set() , it is better to free memory apply by itself , not free memory applied by others

Dec 15 2019, 11:35 AM · Restricted Project
Jakuje added a comment to T206: Should we duplicate the sshkey when we use SSH_BIND_OPTIONS_IMPORT_KEY?.

The ssh_bind_options_set() does not duplicate the ssh_key structure as the server host key should not really be used for anything else than server key in normal use cases. Where else would you like to use the ssh server private key and what for?

Dec 15 2019, 10:22 AM · Restricted Project
Jakuje added a comment to T207: move ssh_key_dup() from pki.h to libssh.h?.

What is the use case where you needed the ssh_key_dup()?

Dec 15 2019, 10:05 AM · Restricted Project
Jakuje closed T209: SPAM as Invalid.

Sounds like a spam here recently. @asn Can we delete this one?

Dec 15 2019, 8:31 AM
Jakuje closed T208: SPAM as Invalid.

Sounds like a spam here recently. @asn Can we delete this one?

Dec 15 2019, 8:30 AM