Page MenuHomePhabricator
Feed All Stories

May 7 2020

davidwed renamed T228: Access violation with MinGW-W64 from Access violation with MinGW64 to Access violation with MinGW-W64.
May 7 2020, 4:52 PM · Restricted Project
davidwed renamed T228: Access violation with MinGW-W64 from Access violation with MinGW to Access violation with MinGW64.
May 7 2020, 4:49 PM · Restricted Project
asn committed rLIBSSHb1bbd20dfa8a: cmake: Add autogenerated libssh_version.h (authored by Heiko Thiery <heiko.thiery@gmail.com>).
cmake: Add autogenerated libssh_version.h
May 7 2020, 12:01 PM
asn committed rLIBSSHbee8ed82abbc: cmake: Add autogenerated libssh_version.h (authored by Heiko Thiery <heiko.thiery@gmail.com>).
cmake: Add autogenerated libssh_version.h
May 7 2020, 11:59 AM

May 6 2020

Jakuje triaged T230: OpenSSL memory sanity check as Wishlist priority.
May 6 2020, 11:51 AM · Restricted Project

May 5 2020

davidwed updated the task description for T228: Access violation with MinGW-W64.
May 5 2020, 3:02 PM · Restricted Project
davidwed created T228: Access violation with MinGW-W64.
May 5 2020, 2:57 PM · Restricted Project
asn committed rLIBSSH4149cebd64a9: fuzz: Avoid warnings from csbuild in fuzzers (authored by Jakuje).
fuzz: Avoid warnings from csbuild in fuzzers
May 5 2020, 2:40 PM
asn committed rLIBSSH425c02cb9437: fuzz: Add instructions for corpus creation and first corpus files (authored by Jakuje).
fuzz: Add instructions for corpus creation and first corpus files
May 5 2020, 2:40 PM
asn committed rLIBSSHad8dedd4a481: fuzz: Allow to increase log level from server fuzzer (authored by Jakuje).
fuzz: Allow to increase log level from server fuzzer
May 5 2020, 2:40 PM
asn committed rLIBSSHe26e98e59f93: fuzz: Do not parse configuration files (authored by Jakuje).
fuzz: Do not parse configuration files
May 5 2020, 2:40 PM
asn committed rLIBSSHae184db913ae: fuzz: Use none cipher and MAC (authored by Jakuje).
fuzz: Use none cipher and MAC
May 5 2020, 2:40 PM
asn committed rLIBSSHb88aa98550dc: Allow example client and server to process different configuration files (authored by Jakuje).
Allow example client and server to process different configuration files
May 5 2020, 2:40 PM
asn committed rLIBSSH08a70bb4745c: tests: Cover ssh_options_getopt with unit tests (authored by Jakuje).
tests: Cover ssh_options_getopt with unit tests
May 5 2020, 2:40 PM
asn committed rLIBSSH3d0ecd37fe6b: options: Avoid memory leaks during modification of argv (authored by Jakuje).
options: Avoid memory leaks during modification of argv
May 5 2020, 2:40 PM
asn committed rLIBSSH2e7ca3e8a6e1: options: Properly handle unknown options with arguments (authored by Jakuje).
options: Properly handle unknown options with arguments
May 5 2020, 2:39 PM
asn committed rLIBSSHb90131dfe696: tests: Verify functionality of none cipher and mac (authored by Jakuje).
tests: Verify functionality of none cipher and mac
May 5 2020, 2:39 PM
asn committed rLIBSSH4f976ce5c4a3: packet: Skip HMAC handling if none is selected (authored by Jakuje).
packet: Skip HMAC handling if none is selected
May 5 2020, 2:39 PM
asn committed rLIBSSH239eef6322d1: packet: Check if set_*_key functions exists before calling it (authored by Jakuje).
packet: Check if set_*_key functions exists before calling it
May 5 2020, 2:39 PM
asn committed rLIBSSHe6aee24a1e3b: Add basic support for none cipher and MACs (authored by Jakuje).
Add basic support for none cipher and MACs
May 5 2020, 2:39 PM
asn committed rLIBSSH201fd661767f: packet: Use temporary variables to avoid long lines (authored by Jakuje).
packet: Use temporary variables to avoid long lines
May 5 2020, 2:39 PM
asn committed rLIBSSH46499b1b9090: Drop none cipher and MAC as they are not implemented (authored by Jakuje).
Drop none cipher and MAC as they are not implemented
May 5 2020, 2:39 PM
asn committed rLIBSSH62a0229f16cd: fuzz: Simplify definition of fuzzing targets and build them also with gcc (authored by Jakuje).
fuzz: Simplify definition of fuzzing targets and build them also with gcc
May 5 2020, 2:39 PM
asn committed rLIBSSH5411e0821fdd: fuzz: Correctly sort members initialization to prevent GCC warnings (authored by Jakuje).
fuzz: Correctly sort members initialization to prevent GCC warnings
May 5 2020, 2:39 PM
asn committed rLIBSSH44de453b2271: tests: Enable all CASignatureAlgorithms as SHA1 certificates are now disabled… (authored by Jakuje).
tests: Enable all CASignatureAlgorithms as SHA1 certificates are now disabled…
May 5 2020, 2:39 PM
asn committed rLIBSSH7c2087589122: pki: Mark explicit fall through (authored by Jakuje).
pki: Mark explicit fall through
May 5 2020, 2:39 PM
asn committed rLIBSSH0c7a772301cb: external: Do not confuse new gcc (authored by Jakuje).
external: Do not confuse new gcc
May 5 2020, 2:39 PM
asn committed rLIBSSHc45cfce166f3: client: Properly indicate fall through (authored by Jakuje).
client: Properly indicate fall through
May 5 2020, 2:39 PM
asn committed rLIBSSH929a6b7d501b: pki: Mark explicit fall through (authored by Jakuje).
pki: Mark explicit fall through
May 5 2020, 2:39 PM
asn committed rLIBSSH88d676cf1a1d: external: Do not confuse new gcc (authored by Jakuje).
external: Do not confuse new gcc
May 5 2020, 2:39 PM
asn committed rLIBSSHb93c9ae641a1: client: Properly indicate fall through (authored by Jakuje).
client: Properly indicate fall through
May 5 2020, 2:38 PM
asn committed rLIBSSHa77d89d3ea73: session: add missing return value documentation (authored by Heiko Thiery <heiko.thiery@gmail.com>).
session: add missing return value documentation
May 5 2020, 2:38 PM
asn committed rLIBSSH4276560680f0: channels: Avoid returning SSH_AGAIN from ssh_channel_poll_timeout() (authored by Jakuje).
channels: Avoid returning SSH_AGAIN from ssh_channel_poll_timeout()
May 5 2020, 2:38 PM
asn committed rLIBSSHa7ce241652b2: channels: reformat (authored by Jakuje).
channels: reformat
May 5 2020, 2:38 PM
asn committed rLIBSSH98c91e68fa8c: examples: Add missing includes (authored by Jakuje).
examples: Add missing includes
May 5 2020, 2:38 PM
asn committed rLIBSSH1c7cfaba9cda: examples: Avoid unused parameter warnings and reformat (authored by Jakuje).
examples: Avoid unused parameter warnings and reformat
May 5 2020, 2:38 PM
asn committed rLIBSSH078cb4c6f359: libcrypto-compat: Fix indentation and return value (authored by Jakuje).
libcrypto-compat: Fix indentation and return value
May 5 2020, 2:38 PM
asn committed rLIBSSHd35fdfbdb417: libcrypto-compat: add extra functions (authored by Rosen Penev <rosenp@gmail.com>).
libcrypto-compat: add extra functions
May 5 2020, 2:38 PM
asn committed rLIBSSH5972d7a98e10: libcrypto: remove deprecated API usage (authored by Rosen Penev <rosenp@gmail.com>).
libcrypto: remove deprecated API usage
May 5 2020, 2:38 PM
asn committed rLIBSSH7ee7ff94ba31: Fix FTBFS on hurd-i386 (authored by bigon).
Fix FTBFS on hurd-i386
May 5 2020, 2:38 PM
asn committed rLIBSSH69e97057c7ed: Correctly parse v4 subsecond timestamps (authored by StefanBruens).
Correctly parse v4 subsecond timestamps
May 5 2020, 2:37 PM
asn committed rLIBSSHc42aab0122c7: Make the documentation reproducible (authored by bigon).
Make the documentation reproducible
May 5 2020, 2:37 PM
asn committed rLIBSSH3025eeace355: client: Check if the library is initialized in ssh_connect() (authored by ansasaki).
client: Check if the library is initialized in ssh_connect()
May 5 2020, 2:37 PM
asn committed rLIBSSHffb000776819: client: Reformat ssh_connect() (authored by ansasaki).
client: Reformat ssh_connect()
May 5 2020, 2:37 PM
asn committed rLIBSSH0a450f02513d: init: Clarify the need to call ssh_{init, finalize}() (authored by ansasaki).
init: Clarify the need to call ssh_{init, finalize}()
May 5 2020, 2:37 PM
asn committed rLIBSSHa99b8a397973: init: Introduce internal is_ssh_initialized() (authored by ansasaki).
init: Introduce internal is_ssh_initialized()
May 5 2020, 2:37 PM

Apr 30 2020

bonnysmith9090 updated bonnysmith9090.
Apr 30 2020, 1:41 PM
bonnysmith9090 updated bonnysmith9090.
Apr 30 2020, 1:41 PM

Apr 24 2020

Jakuje committed rLIBSSH99e0ad75a6d1: tests: add testcases for ssh_channel_poll_timeout() (authored by Heiko Thiery <heiko.thiery@gmail.com>).
tests: add testcases for ssh_channel_poll_timeout()
Apr 24 2020, 4:17 PM
Jakuje committed rLIBSSHe76332bbd617: session: add missing return value documentation (authored by Heiko Thiery <heiko.thiery@gmail.com>).
session: add missing return value documentation
Apr 24 2020, 4:17 PM

Apr 22 2020

Jakuje added a comment to T227: `ssh_options_parse_config()` mentions non-existent `ssh_options_set_host()`.

It is still needed as the configuration parsing requires the hostname to evaluate conditional match blocks. But the new API ssh_options_set() should be used and documentation updated accordingly. The documentation should also mention that if it is not called, it is called automatically on connect.

Apr 22 2020, 9:05 PM · Restricted Project
ansasaki created T227: `ssh_options_parse_config()` mentions non-existent `ssh_options_set_host()`.
Apr 22 2020, 11:35 AM · Restricted Project

Apr 21 2020

Jakuje closed T218: Disable ssh-rsa (sha1) keys by default as Resolved.

The previously mentioned commit disables the RSA-SHA1 and DSA algorithms by default.

Apr 21 2020, 5:18 PM · Restricted Project

Apr 20 2020

Jakuje committed rLIBSSH154765ae8ca5: config: Check null deref (authored by Jakuje).
config: Check null deref
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH6417f5a3cac8: channels: Avoid returning SSH_AGAIN from ssh_channel_poll_timeout() (authored by Jakuje).
channels: Avoid returning SSH_AGAIN from ssh_channel_poll_timeout()
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSHfe0fcbbc67e3: channels: reformat (authored by Jakuje).
channels: reformat
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSHc2f64108a152: examples: Avoid unused parameter warnings and reformat (authored by Jakuje).
examples: Avoid unused parameter warnings and reformat
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH59ac79c4dcdf: gitlab-ci: Avoid passing artifacts between completely unrelated stages (authored by Jakuje).
gitlab-ci: Avoid passing artifacts between completely unrelated stages
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH7f57717f84f0: gitlab-ci: Fix typo (authored by Jakuje).
gitlab-ci: Fix typo
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSHdb948bdac87e: tests: Enable RSA SHA1 certs for testing against older OpenSSH (authored by Jakuje).
tests: Enable RSA SHA1 certs for testing against older OpenSSH
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH6941958b4954: tests: Update coverage of config_parser (authored by Jakuje).
tests: Update coverage of config_parser
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH1ba6ef689fe7: config_parser: Allow equal sign as a separator and eat up trailing whitespace (authored by Jakuje).
config_parser: Allow equal sign as a separator and eat up trailing whitespace
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSHfecdc3cc0e6d: Disable RSA and DSA keys with sha1 by default (authored by Jakuje).
Disable RSA and DSA keys with sha1 by default
Apr 20 2020, 2:43 PM
Jakuje closed T210: Crash in libssh in canonical multipass due to certain entries in `~/.ssh/config` as Resolved by committing rLIBSSH1ba6ef689fe7: config_parser: Allow equal sign as a separator and eat up trailing whitespace.
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH04ae110c612f: pkd: Enable all hostkeys (authored by Jakuje).
pkd: Enable all hostkeys
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH9ac2d1470763: tests: Enable all host key algorithms in testing client (authored by Jakuje).
tests: Enable all host key algorithms in testing client
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSHbab2c775da62: Make the testing ping use all supported algorithms (authored by Jakuje).
Make the testing ping use all supported algorithms
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH58d53f1397c9: examples: Add missing includes (authored by Jakuje).
examples: Add missing includes
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH945829a5dd3d: Reformat ssh_bind_accept() (authored by Jakuje).
Reformat ssh_bind_accept()
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSHeebb02fff52c: libcrypto-compat: Fix indentation and return value (authored by Jakuje).
libcrypto-compat: Fix indentation and return value
Apr 20 2020, 2:42 PM
Jakuje committed rLIBSSH70478619cec7: libcrypto-compat: add extra functions (authored by Rosen Penev <rosenp@gmail.com>).
libcrypto-compat: add extra functions
Apr 20 2020, 2:42 PM
Jakuje committed rLIBSSH54296787a79e: libcrypto: remove deprecated API usage (authored by Rosen Penev <rosenp@gmail.com>).
libcrypto: remove deprecated API usage
Apr 20 2020, 2:42 PM

Apr 16 2020

adelton added a comment to T226: Version number of LIBSSH_VERSION_MICRO for 0.9.4 and 0.8.9 release not updated.

This also breaks my python-libssh testing: https://travis-ci.org/github/adelton/python-libssh/jobs/675211702 in Fedora rawhide as I'm testing that the versions reported by the library and by the rpm match. Is there a plan to bring the LIBSSH_VERSION in sync with the library version?

Apr 16 2020, 6:40 PM · Restricted Project
Jakuje closed T174: pkd_hello fails for some host key types as Resolved.

AFAIK this was already addressed by using ssh -Q to query openssh supported algorithms and we have ubuntu 18.04 in CI to prevent similar issues in future.

Apr 16 2020, 12:41 PM · Restricted Project
Jakuje added a project to T92: Usage of `strerror` is not thread-safe: Restricted Project.
Apr 16 2020, 12:37 PM · Restricted Project
Jakuje triaged T171: Allow specifiying algorithms in configuration file by adding or removing algorithms from default as Wishlist priority.
Apr 16 2020, 12:18 PM · Restricted Project
Jakuje added a comment to T172: libssh 0.8.7 failed to build in debug mode with openssl 1.1.1c.

Looks like the CI is running VS2017, which has still openssl 1.0.2. Would be nice to run against something supported.

Apr 16 2020, 12:12 PM · Restricted Project
Jakuje claimed T173: v9.0 example and cpp wrappers returning -1 on ssh_channel_read and ssh_channel_read_timeout.

This sounds like an issue discussed in [1]. Can you check if it still happens with the current master + proposed fixes?

Apr 16 2020, 11:21 AM · Restricted Project
Jakuje added a comment to T175: Building v9.0.0 with gcc 7.4.0 fails..

This has changed recently in master with commit 742d81ec. Can you check if you can still reproduce the issue with the referenced commit/master/

Apr 16 2020, 10:12 AM · Restricted Project
Jakuje closed T177: Build error. Version 0.9.0 / 0.8.5 as Resolved.

I believe this is fixed in current versions. If not, please reopen.

Apr 16 2020, 10:07 AM · Restricted Project
Jakuje added a comment to T192: Reusing a session results in timeout at user_auth_password.

AFAIK, this was fixed with T194. Can you recheck if you can still reproduce the issue with latest release/master?

Apr 16 2020, 10:01 AM · Restricted Project
Jakuje added a project to T201: compiling libssh 0.9.2 on Solaris 11: Restricted Project.
Apr 16 2020, 9:59 AM · Restricted Project
Jakuje added a comment to T201: compiling libssh 0.9.2 on Solaris 11.

The example is missing the includes as mentioned in T225:

Apr 16 2020, 9:58 AM · Restricted Project
Jakuje added a comment to T221: Access violation crash in static build in windows.

Some backtrace of the crash would be useful.

Apr 16 2020, 9:50 AM

Apr 15 2020

Jakuje committed rLIBSSHa881c318ac27: Fix FTBFS on hurd-i386 (authored by bigon).
Fix FTBFS on hurd-i386
Apr 15 2020, 2:56 PM
Jakuje committed rLIBSSH5f1d0c4795ed: Make the documentation reproducible (authored by bigon).
Make the documentation reproducible
Apr 15 2020, 2:56 PM
Jakuje committed rLIBSSH1ff6dda616ec: Correctly parse v4 subsecond timestamps (authored by StefanBruens).
Correctly parse v4 subsecond timestamps
Apr 15 2020, 2:56 PM
Jakuje closed T219: Parsing of SUBSECOND_TIMES wrong as Resolved by committing rLIBSSH1ff6dda616ec: Correctly parse v4 subsecond timestamps.
Apr 15 2020, 2:56 PM

Apr 14 2020

Jakuje claimed T210: Crash in libssh in canonical multipass due to certain entries in `~/.ssh/config`.

Seems like the linked multipass issue is fixed now. I am wondering why it was done by the change of the SSH_OPTIONS_SSH_DIR instead of SSH_OPTIONS_PROCESS_CONFIG which would prevent configuration parsing altogether.

Apr 14 2020, 6:49 PM

Apr 11 2020

keilhauiteecce added a comment to T122: Running the sftp_read test for the second time fails.
Apr 11 2020, 1:24 PM · Restricted Project

Apr 10 2020

chcg renamed T226: Version number of LIBSSH_VERSION_MICRO for 0.9.4 and 0.8.9 release not updated from Version number of LIBSSH_VERSION_MICRO for 0.9.4 and 0.8.9 release to Version number of LIBSSH_VERSION_MICRO for 0.9.4 and 0.8.9 release not updated.
Apr 10 2020, 6:28 PM · Restricted Project
chcg created T226: Version number of LIBSSH_VERSION_MICRO for 0.9.4 and 0.8.9 release not updated.
Apr 10 2020, 6:27 PM · Restricted Project

Apr 9 2020

Jakuje added a comment to T219: Parsing of SUBSECOND_TIMES wrong.

Can you submit the merge request on gitlab, where we can see results of the CI run?

Apr 9 2020, 7:03 PM
Jakuje triaged T220: Opening sftp fails in non-blocking mode as Low priority.

Thank you for the report. You are right, this does not look like covered by any existing test case. The only one covered is the blocking mode in tests/client/torture_sftp_read.c. Contributions are always welcomed.

Apr 9 2020, 6:56 PM · Restricted Project
rhialto added a comment to T225: Missing #include makes that compiling example fails.

Yes, that compiles perfectly. I just cloned the whole tree.

Apr 9 2020, 3:34 PM · Restricted Project
Jakuje added a comment to T224: Unable to distinguish between real error and child-process interrupts when ssh_bind_accept() returns.
In T224#3742, @orionltd wrote:
fd = accept(sshbind->bindfd, NULL, NULL);
if (fd == SSH_INVALID_SOCKET) {
  if (errno == EINTR) {
    ssh_set_error(sshbind, SSH_EINTR,
        "Accepting a new connection (child signal error): %s",
        strerror(errno));
Apr 9 2020, 12:26 PM · Restricted Project
Jakuje claimed T225: Missing #include makes that compiling example fails.

Can you check the following commit solves your problems:

Apr 9 2020, 11:49 AM · Restricted Project
asn committed rLIBSSHe3e3a2786362: client: Check if the library is initialized in ssh_connect() (authored by ansasaki).
client: Check if the library is initialized in ssh_connect()
Apr 9 2020, 11:27 AM
asn committed rLIBSSH0f33eecc0166: client: Reformat ssh_connect() (authored by ansasaki).
client: Reformat ssh_connect()
Apr 9 2020, 11:27 AM
asn committed rLIBSSHdba2114ed787: init: Introduce internal is_ssh_initialized() (authored by ansasaki).
init: Introduce internal is_ssh_initialized()
Apr 9 2020, 11:27 AM