Connector descriptions which are mention in coding. I will wait for the time because connector add checks all descriptions which are here with perfect essayshark. I start to do work for connector and make it more perfect.

The backtrace in the attached issue points to the match block parsing:

0   libsystem_c.dylib             	0x00007fff6acc7b44 strcasecmp_l + 92
1   libssh.4.dylib                	0x0000000107d27bbe ssh_config_get_match_opcode + 78
2   libssh.4.dylib                	0x0000000107d2608b ssh_config_parse_line + 763
3   libssh.4.dylib                	0x0000000107d25cfa ssh_config_parse_file + 266
4   libssh.4.dylib                	0x0000000107d40806 ssh_options_parse_config + 262
5   libssh.4.dylib                	0x0000000107d248e4 ssh_connect + 292

if you have some other crash report, please let us know.

Indeed. For the time being, I have opened the bug to follow the multipass issue, where I hope that this data shall be made available. In the meantime, proxyjump as in ProxyJump = myhost seems to be a trigger for the issue.

Without information about the libssh version, what configuration file was used (at least the offending match line), more verbose libssh logs (there is quite a lot of tracing logs around), it is hard to guess what went wrong with the parsing.

OK, OpenSSH is using the $SHELL environment variable and since the CI runs in bash, this should be simple fix.

ugh ... so I finally got down to the root cause of this issue. The proxycommand is executed in /bin/sh of the current user. In Fedora we have this symlinked to /bin/bash, while in Ubuntu, this is /bin/dash (sic ,,,). These two differ in a way how they handle environment variables. It looks like they are just ignored in dash. So the poor-man fix is the following in src/socket.c:

-    const char *args[] = {"/bin/sh", "-c", command, NULL};
+    const char *args[] = {"/bin/bash", "-c", command, NULL};

Better would be though to be able to

• run the proxy command also in bash (very friendly)
• run the proxy command in the users shell from passwd and set bash in passwd of tests (I think OpenSSH does that in cases where commands are executed) -- I like this one most
• make sure the environment variables are passed through the shells in some more compatible way

The whole proxy_command test is mess ... in clean image it hangs for me also in Fedora.

reverting the previous comment -- it still fails with Ubuntu. But at least some of the bugs are fixed.

Back to the original issue. I just did clean build directory and I see also some issues with proxy command. And these are that ssh is prompting for hostkey verification. I think this is just because I did not run the rest of the tests (which accidentally create the known_hosts in the users directories). So using -o StrictHostKeyChecking=no in the ssh commandline as you propose might be the correct solution for this issue. I will check whether there will be more issues afterward.

Closing as these symptoms really look like the same. If not, please reopen.

FYI, I think you might have been hitting also this issue which I recently fixed in master: https://gitlab.com/libssh/libssh-mirror/commit/d2a32ca6 It would be nice if you could check if the original issue got addressed.

@aris Your test does not call session_setup() so that is the reason for this particular case failing to you. I think using the following will make it working for you:

Merged as b94ecf18 (before the phabricator will pick up the changeset).

We can't delete it, but close it and I will disable the user.

In T207#3531, @Jakuje wrote:

In T207#3529, @ZhaoGuangYue1986 wrote:

To my opinion, even we move ssh_key_dup() to libssh.h ,we also should duplicate ssh_key in function ssh_bind_options_set() , it is better to free memory apply by itself , not free memory applied by others

This would be changing behavior so for any program written with older libssh, new versions would leak this memory, because they would be expecting it will be freed with the bind. So better solution would really be to use the ssh_key_dup() yourself (easiest by including the pki.h yourself for now as suggested in the other issue).

In T207#3529, @ZhaoGuangYue1986 wrote:

To my opinion, even we move ssh_key_dup() to libssh.h ,we also should duplicate ssh_key in function ssh_bind_options_set() , it is better to free memory apply by itself , not free memory applied by others

This issue is relatate to https://bugs.libssh.org/T206

The ssh_bind_options_set() does not duplicate the ssh_key structure as the server host key should not really be used for anything else than server key in normal use cases. Where else would you like to use the ssh server private key and what for?

What is the use case where you needed the ssh_key_dup()?

Sounds like a spam here recently. @asn Can we delete this one?

Sounds like a spam here recently. @asn Can we delete this one?

Proposed fix: https://gitlab.com/libssh/libssh-mirror/merge_requests/79.