Page MenuHomePhabricator
Feed All Stories

Yesterday

asn committed rLIBSSH7f5e14698fe1: gitlab-ci: Create obj directory for Windows builds (authored by ansasaki).
gitlab-ci: Create obj directory for Windows builds
Mon, Jan 20, 2:33 PM

Wed, Jan 15

asn committed rLIBSSH1fe5f03fff4d: gitlab-ci: Re-enable client testing on Tumbleweed (authored by asn).
gitlab-ci: Re-enable client testing on Tumbleweed
Wed, Jan 15, 5:48 PM

Tue, Jan 14

Gersstenre added a comment to F57769: 0001-connector-Add-checks-if-file-descriptor-is-socket-or_v2.patch.

Connector descriptions which are mention in coding. I will wait for the time because connector add checks all descriptions which are here with perfect essayshark. I start to do work for connector and make it more perfect.

Tue, Jan 14, 7:23 AM

Sat, Dec 28

Jakuje added a comment to T210: Crash in libssh in canonical multipass due to certain entries in `~/.ssh/config`.

The backtrace in the attached issue points to the match block parsing:

0   libsystem_c.dylib             	0x00007fff6acc7b44 strcasecmp_l + 92
1   libssh.4.dylib                	0x0000000107d27bbe ssh_config_get_match_opcode + 78
2   libssh.4.dylib                	0x0000000107d2608b ssh_config_parse_line + 763
3   libssh.4.dylib                	0x0000000107d25cfa ssh_config_parse_file + 266
4   libssh.4.dylib                	0x0000000107d40806 ssh_options_parse_config + 262
5   libssh.4.dylib                	0x0000000107d248e4 ssh_connect + 292

if you have some other crash report, please let us know.

Sat, Dec 28, 2:13 PM
callegar added a comment to T210: Crash in libssh in canonical multipass due to certain entries in `~/.ssh/config`.

Indeed. For the time being, I have opened the bug to follow the multipass issue, where I hope that this data shall be made available. In the meantime, proxyjump as in ProxyJump = myhost seems to be a trigger for the issue.

Sat, Dec 28, 10:06 AM

Fri, Dec 27

Jakuje added a comment to T210: Crash in libssh in canonical multipass due to certain entries in `~/.ssh/config`.

Without information about the libssh version, what configuration file was used (at least the offending match line), more verbose libssh logs (there is quite a lot of tracing logs around), it is hard to guess what went wrong with the parsing.

Fri, Dec 27, 9:56 PM
callegar created T210: Crash in libssh in canonical multipass due to certain entries in `~/.ssh/config`.
Fri, Dec 27, 10:40 AM

Mon, Dec 23

asn committed rLIBSSHdf1f64d4351f: gitlab-ci: Unbreak Freebsd build (authored by Jakuje).
gitlab-ci: Unbreak Freebsd build
Mon, Dec 23, 3:35 PM
asn committed rLIBSSH94846b1d155d: Update ChangeLog (authored by asn).
Update ChangeLog
Mon, Dec 23, 3:34 PM
asn committed rLIBSSH4d493c4da5e4: gitlab-ci: Add csbuilds for gcrypt and mbedtls (authored by Jakuje).
gitlab-ci: Add csbuilds for gcrypt and mbedtls
Mon, Dec 23, 2:49 PM
asn committed rLIBSSHee2fa29798e6: gitlab-ci: Simplify the targets definitions using inheritance (authored by Jakuje).
gitlab-ci: Simplify the targets definitions using inheritance
Mon, Dec 23, 2:49 PM
asn committed rLIBSSH6d3941e71b33: gitlab-ci: Add Ubuntu target (based on Fedora one) (authored by Jakuje).
gitlab-ci: Add Ubuntu target (based on Fedora one)
Mon, Dec 23, 2:49 PM
asn committed rLIBSSHe5553a92d9ed: socket: Use the users shell for running proxy command (authored by Jakuje).
socket: Use the users shell for running proxy command
Mon, Dec 23, 2:49 PM
asn committed rLIBSSH3a6751f3d231: socket: Fix the error message (authored by Jakuje).
socket: Fix the error message
Mon, Dec 23, 2:49 PM
asn committed rLIBSSHdd6498066234: socket: Kill the proxy command if it still runs on disconnect (authored by Jakuje).
socket: Kill the proxy command if it still runs on disconnect
Mon, Dec 23, 2:49 PM
asn closed T200: Test torture_proxycommand fails on ubuntu 18.04 as Resolved by committing rLIBSSHe5553a92d9ed: socket: Use the users shell for running proxy command.
Mon, Dec 23, 2:49 PM · Unknown Object (Project)
asn committed rLIBSSH24f450fed16b: pki_gcrypt: Warn about unsupported PEM export in gcrypt (authored by Jakuje).
pki_gcrypt: Warn about unsupported PEM export in gcrypt
Mon, Dec 23, 2:49 PM
asn committed rLIBSSH9d5616a18c20: tests: Unbreak strict builds on Ubuntu (authored by Jakuje).
tests: Unbreak strict builds on Ubuntu
Mon, Dec 23, 2:49 PM
asn committed rLIBSSHc106cd1f8365: CMakeLists: Shorten the keys lists passed to the ssh command (authored by Jakuje).
CMakeLists: Shorten the keys lists passed to the ssh command
Mon, Dec 23, 2:49 PM
asn committed rLIBSSH7e692ee1b6f0: libgcrypt: Do not leak memory with invalid key lengths (authored by Jakuje).
libgcrypt: Do not leak memory with invalid key lengths
Mon, Dec 23, 2:49 PM
asn committed rLIBSSHdd54ffb2f1bc: pki_gcrypt: Do not confuse static analyzers (authored by Jakuje).
pki_gcrypt: Do not confuse static analyzers
Mon, Dec 23, 2:49 PM
asn committed rLIBSSH3642224ee516: legacy,keys: Fix the macro conditions (authored by Jakuje).
legacy,keys: Fix the macro conditions
Mon, Dec 23, 2:49 PM
asn committed rLIBSSH9b858f57c507: mbedcrypto_missing: Always check return values (authored by Jakuje).
mbedcrypto_missing: Always check return values
Mon, Dec 23, 2:49 PM
asn committed rLIBSSH13c88a2e0a7a: mbedcrypto_missing: Avoid potential memory leaks as reported by csbuild (authored by Jakuje).
mbedcrypto_missing: Avoid potential memory leaks as reported by csbuild
Mon, Dec 23, 2:48 PM
asn committed rLIBSSH059b6851dc0d: pki_mbedtls: Avoid potential memory leaks (authored by Jakuje).
pki_mbedtls: Avoid potential memory leaks
Mon, Dec 23, 2:48 PM
asn committed rLIBSSH8eda4165cf43: tests: Do not require strict host key checking in openssh (authored by Jakuje).
tests: Do not require strict host key checking in openssh
Mon, Dec 23, 2:48 PM
asn committed rLIBSSH30cc1568f402: options: Avoid needless assignment as reported by csbuild (authored by Jakuje).
options: Avoid needless assignment as reported by csbuild
Mon, Dec 23, 2:48 PM
asn committed rLIBSSH71ba61cc5bda: pki_mbedtls: Do not warn about unused arguments (authored by Jakuje).
pki_mbedtls: Do not warn about unused arguments
Mon, Dec 23, 2:48 PM
asn committed rLIBSSHe2841908fbe5: kex: Avoid always-false comparisons as reported by csbuild (authored by Jakuje).
kex: Avoid always-false comparisons as reported by csbuild
Mon, Dec 23, 2:48 PM
asn committed rLIBSSH2892b49a37e7: tests: Use the path to SSH executable consistently (authored by Jakuje).
tests: Use the path to SSH executable consistently
Mon, Dec 23, 2:48 PM
asn committed rLIBSSH4b85934198ff: examples: Enable strict build (authored by Jakuje).
examples: Enable strict build
Mon, Dec 23, 2:48 PM
asn committed rLIBSSH1563bddf88c2: tests: Avoid needless assignment as reported by csbuild (authored by Jakuje).
tests: Avoid needless assignment as reported by csbuild
Mon, Dec 23, 2:48 PM
asn committed rLIBSSH9e7de14d5936: pkd client run user executable (authored by aris).
pkd client run user executable
Mon, Dec 23, 2:48 PM
asn committed rLIBSSHbba5fa18ed81: pkd: fix snprintf compiler warning (authored by aris).
pkd: fix snprintf compiler warning
Mon, Dec 23, 2:48 PM
asn committed rLIBSSH108994834664: tests: use detected sshd path (authored by aris).
tests: use detected sshd path
Mon, Dec 23, 2:48 PM
asn committed rLIBSSH7ec67011c5bb: tests: use OpenSSH-provided ciphers (authored by aris).
tests: use OpenSSH-provided ciphers
Mon, Dec 23, 2:48 PM
asn committed rLIBSSH3d2570ff5ffa: pkd: use detected OpenSSH supported key types (authored by aris).
pkd: use detected OpenSSH supported key types
Mon, Dec 23, 2:48 PM
asn committed rLIBSSH3063a57fc8ac: tests: detect OpenSSH supported ciphers (authored by aris).
tests: detect OpenSSH supported ciphers
Mon, Dec 23, 2:48 PM
asn committed rLIBSSH177e76f7539a: tests: search for netcat binary (authored by aris).
tests: search for netcat binary
Mon, Dec 23, 2:48 PM
asn committed rLIBSSH23c529c888fd: tests: fix typos (authored by aris).
tests: fix typos
Mon, Dec 23, 2:48 PM

Dec 20 2019

asn committed rLIBSSH2b76abb74c75: clienttest: Adds a client test that authenticates to the ssh server using… (authored by Sahana Prasad <sahana@redhat.com>).
clienttest: Adds a client test that authenticates to the ssh server using…
Dec 20 2019, 4:42 PM
asn committed rLIBSSHfa95fe3e1b93: unittests: Adds unitests for ecdsa and rsa with PKCS11 URIs. (authored by Sahana Prasad <sahana@redhat.com>).
unittests: Adds unitests for ecdsa and rsa with PKCS11 URIs.
Dec 20 2019, 4:42 PM
asn committed rLIBSSH4ea09256f67c: src: Implements PKCS11 URI support (authored by Sahana Prasad <sahana@redhat.com>).
src: Implements PKCS11 URI support
Dec 20 2019, 4:42 PM
asn committed rLIBSSHcc1175a9af8d: torture: Add a helper function to setup tokens using softhsm. (authored by Sahana Prasad <sahana@redhat.com>).
torture: Add a helper function to setup tokens using softhsm.
Dec 20 2019, 4:42 PM
asn committed rLIBSSH6bf4ada240f3: src: Helper funtions to detect PKCS #11 URIs (authored by Sahana Prasad <sahana@redhat.com>).
src: Helper funtions to detect PKCS #11 URIs
Dec 20 2019, 4:42 PM
asn committed rLIBSSHbbc72ed3b6d1: tests/CMakeLists: Adds keys to authorized hosts list. copies script used to… (authored by Sahana Prasad <sahana@redhat.com>).
tests/CMakeLists: Adds keys to authorized hosts list. copies script used to…
Dec 20 2019, 4:42 PM
asn committed rLIBSSH86a0dfa65b55: src: Adds the Engine header file and invokes cleanup of the engine (authored by Sahana Prasad <sahana@redhat.com>).
src: Adds the Engine header file and invokes cleanup of the engine
Dec 20 2019, 4:42 PM
asn committed rLIBSSH89ec52f5b106: torture_key: Adds public keys in PEM format - as required by p11tool. (authored by Sahana Prasad <sahana@redhat.com>).
torture_key: Adds public keys in PEM format - as required by p11tool.
Dec 20 2019, 4:42 PM
asn committed rLIBSSH843052dd23e4: etc: Adds a new user Charlie (authored by Sahana Prasad <sahana@redhat.com>).
etc: Adds a new user Charlie
Dec 20 2019, 4:42 PM
asn committed rLIBSSH105e6f05bad5: gitlab-ci: adds the PKCS11 URI option to build options (authored by Sahana Prasad <sahana@redhat.com>).
gitlab-ci: adds the PKCS11 URI option to build options
Dec 20 2019, 4:41 PM
asn committed rLIBSSH317cf070e2e9: tests/pkcs11: Adds a script to setup PKCS11 tokens using softhsm and p11tool. (authored by Sahana Prasad <sahana@redhat.com>).
tests/pkcs11: Adds a script to setup PKCS11 tokens using softhsm and p11tool.
Dec 20 2019, 4:41 PM
asn committed rLIBSSHac22e51e5a53: cmake: Add cmake module to find softhsm (authored by Sahana Prasad <sahana@redhat.com>).
cmake: Add cmake module to find softhsm
Dec 20 2019, 4:41 PM
asn committed rLIBSSH2a22211e7fb8: keys: Adds new keys to generate PKCS11 URIs used to authenticate with the ssh… (authored by Sahana Prasad <sahana@redhat.com>).
keys: Adds new keys to generate PKCS11 URIs used to authenticate with the ssh…
Dec 20 2019, 4:41 PM
asn committed rLIBSSHfa6fb83c87b5: cmake: Add new option for PKCS11 URI support (authored by Sahana Prasad <sahana@redhat.com>).
cmake: Add new option for PKCS11 URI support
Dec 20 2019, 4:41 PM
asn committed rLIBSSH314448786e47: unittest: Adds unit tests for ssh_strreplace(). (authored by Sahana Prasad <sahana@redhat.com>).
unittest: Adds unit tests for ssh_strreplace().
Dec 20 2019, 4:41 PM
asn committed rLIBSSH35216e7254d7: misc: Add ssh_strreplace() (authored by asn).
misc: Add ssh_strreplace()
Dec 20 2019, 4:41 PM
asn committed rLIBSSH5317ebf0fcf9: misc: Add ssh_tmpname() (authored by asn).
misc: Add ssh_tmpname()
Dec 20 2019, 4:41 PM

Dec 19 2019

Jakuje added a comment to T200: Test torture_proxycommand fails on ubuntu 18.04.

OK, OpenSSH is using the $SHELL environment variable and since the CI runs in bash, this should be simple fix.

Dec 19 2019, 6:40 PM · Unknown Object (Project)
Jakuje added a comment to T200: Test torture_proxycommand fails on ubuntu 18.04.

ugh ... so I finally got down to the root cause of this issue. The proxycommand is executed in /bin/sh of the current user. In Fedora we have this symlinked to /bin/bash, while in Ubuntu, this is /bin/dash (sic ,,,). These two differ in a way how they handle environment variables. It looks like they are just ignored in dash. So the poor-man fix is the following in src/socket.c:

-    const char *args[] = {"/bin/sh", "-c", command, NULL};
+    const char *args[] = {"/bin/bash", "-c", command, NULL};

Better would be though to be able to

  • run the proxy command also in bash (very friendly)
  • run the proxy command in the users shell from passwd and set bash in passwd of tests (I think OpenSSH does that in cases where commands are executed) -- I like this one most
  • make sure the environment variables are passed through the shells in some more compatible way
Dec 19 2019, 6:35 PM · Unknown Object (Project)

Dec 18 2019

Jakuje added a comment to T200: Test torture_proxycommand fails on ubuntu 18.04.

The whole proxy_command test is mess ... in clean image it hangs for me also in Fedora.

Dec 18 2019, 5:02 PM · Unknown Object (Project)
davidwed closed T202: cmake: Bump API version to 4.8.3 as Invalid.
Dec 18 2019, 10:21 AM · Unknown Object (Project)

Dec 17 2019

Jakuje added a comment to T200: Test torture_proxycommand fails on ubuntu 18.04.

reverting the previous comment -- it still fails with Ubuntu. But at least some of the bugs are fixed.

Dec 17 2019, 4:58 PM · Unknown Object (Project)
jukivili committed rLIBSSH08f4469e2198: libgcrypt: fix cipher handle leaks on setkey error paths (authored by jukivili).
libgcrypt: fix cipher handle leaks on setkey error paths
Dec 17 2019, 10:34 AM
jukivili committed rLIBSSHde4b8f88a292: libgcrypt: Implement chacha20-poly1305@openssh.com cipher using libgcrypt (authored by jukivili).
libgcrypt: Implement chacha20-poly1305@openssh.com cipher using libgcrypt
Dec 17 2019, 10:34 AM
jukivili committed rLIBSSHaf5de2d37e7c: tests: add crypto unittest for chacha20poly1305 (authored by jukivili).
tests: add crypto unittest for chacha20poly1305
Dec 17 2019, 10:34 AM

Dec 16 2019

Jakuje added a comment to T200: Test torture_proxycommand fails on ubuntu 18.04.

Back to the original issue. I just did clean build directory and I see also some issues with proxy command. And these are that ssh is prompting for hostkey verification. I think this is just because I did not run the rest of the tests (which accidentally create the known_hosts in the users directories). So using -o StrictHostKeyChecking=no in the ssh commandline as you propose might be the correct solution for this issue. I will check whether there will be more issues afterward.

Dec 16 2019, 3:59 PM · Unknown Object (Project)
Jakuje closed T180: tests: "bind: address already in use" as Resolved.

Closing as these symptoms really look like the same. If not, please reopen.

Dec 16 2019, 3:55 PM · Unknown Object (Project)
Jakuje added a comment to T180: tests: "bind: address already in use".

FYI, I think you might have been hitting also this issue which I recently fixed in master: https://gitlab.com/libssh/libssh-mirror/commit/d2a32ca6 It would be nice if you could check if the original issue got addressed.

Dec 16 2019, 3:47 PM · Unknown Object (Project)
Jakuje added a comment to T200: Test torture_proxycommand fails on ubuntu 18.04.

@aris Your test does not call session_setup() so that is the reason for this particular case failing to you. I think using the following will make it working for you:

Dec 16 2019, 2:46 PM · Unknown Object (Project)
Jakuje committed rLIBSSH251f60c031b2: curve25519: fix uninitialized arg to EVP_PKEY_derive (authored by simonsj).
curve25519: fix uninitialized arg to EVP_PKEY_derive
Dec 16 2019, 1:26 PM
simonsj committed rLIBSSHb94ecf18bd2b: curve25519: fix uninitialized arg to EVP_PKEY_derive (authored by simonsj).
curve25519: fix uninitialized arg to EVP_PKEY_derive
Dec 16 2019, 1:26 PM
Jakuje closed T205: ssh_curve25519_build_k: uninitialized input to `EVP_PKEY_derive` for HAVE_OPENSSL_X25519 builds can cause sporadic failure as Resolved.

Merged as b94ecf18 (before the phabricator will pick up the changeset).

Dec 16 2019, 1:25 PM

Dec 15 2019

asn renamed T208: SPAM from Bump API version to 4.8.5 to SPAM.
Dec 15 2019, 12:21 PM
asn renamed T209: SPAM from upgrade to lib32gm.io to SPAM.
Dec 15 2019, 12:21 PM
asn added a comment to T208: SPAM.

We can't delete it, but close it and I will disable the user.

Dec 15 2019, 12:20 PM
ZhaoGuangYue1986 closed T206: Should we duplicate the sshkey when we use SSH_BIND_OPTIONS_IMPORT_KEY? as Resolved.
Dec 15 2019, 12:16 PM · Unknown Object (Project)
ZhaoGuangYue1986 added a comment to T207: move ssh_key_dup() from pki.h to libssh.h?.
In T207#3531, @Jakuje wrote:

To my opinion, even we move ssh_key_dup() to libssh.h ,we also should duplicate ssh_key in function ssh_bind_options_set() , it is better to free memory apply by itself , not free memory applied by others

This would be changing behavior so for any program written with older libssh, new versions would leak this memory, because they would be expecting it will be freed with the bind. So better solution would really be to use the ssh_key_dup() yourself (easiest by including the pki.h yourself for now as suggested in the other issue).

Dec 15 2019, 11:54 AM · Unknown Object (Project)
Jakuje added a comment to T207: move ssh_key_dup() from pki.h to libssh.h?.

To my opinion, even we move ssh_key_dup() to libssh.h ,we also should duplicate ssh_key in function ssh_bind_options_set() , it is better to free memory apply by itself , not free memory applied by others

Dec 15 2019, 11:35 AM · Unknown Object (Project)
ZhaoGuangYue1986 added a comment to T207: move ssh_key_dup() from pki.h to libssh.h?.

This issue is relatate to https://bugs.libssh.org/T206

Dec 15 2019, 11:13 AM · Unknown Object (Project)
Jakuje added a comment to T206: Should we duplicate the sshkey when we use SSH_BIND_OPTIONS_IMPORT_KEY?.

The ssh_bind_options_set() does not duplicate the ssh_key structure as the server host key should not really be used for anything else than server key in normal use cases. Where else would you like to use the ssh server private key and what for?

Dec 15 2019, 10:22 AM · Unknown Object (Project)
Jakuje added a comment to T207: move ssh_key_dup() from pki.h to libssh.h?.

What is the use case where you needed the ssh_key_dup()?

Dec 15 2019, 10:05 AM · Unknown Object (Project)
Jakuje closed T209: SPAM as Invalid.

Sounds like a spam here recently. @asn Can we delete this one?

Dec 15 2019, 8:31 AM
Jakuje closed T208: SPAM as Invalid.

Sounds like a spam here recently. @asn Can we delete this one?

Dec 15 2019, 8:30 AM
johnwhite triaged T209: SPAM as Wishlist priority.
Dec 15 2019, 2:21 AM
amandaj triaged T208: SPAM as Low priority.
Dec 15 2019, 2:09 AM
ZhaoGuangYue1986 renamed T207: move ssh_key_dup() from pki.h to libssh.h? from remove ssh_key_dup() from pki.h to libssh.h? to move ssh_key_dup() from pki.h to libssh.h?.
Dec 15 2019, 2:06 AM · Unknown Object (Project)

Dec 14 2019

ZhaoGuangYue1986 created T207: move ssh_key_dup() from pki.h to libssh.h?.
Dec 14 2019, 12:59 PM · Unknown Object (Project)
ZhaoGuangYue1986 created T206: Should we duplicate the sshkey when we use SSH_BIND_OPTIONS_IMPORT_KEY?.
Dec 14 2019, 12:57 PM · Unknown Object (Project)
Kylannton added a comment to T2: allow external io.
Dec 14 2019, 12:06 PM · Unknown Object (Project)
simonsj added a comment to T205: ssh_curve25519_build_k: uninitialized input to `EVP_PKEY_derive` for HAVE_OPENSSL_X25519 builds can cause sporadic failure.

Proposed fix: https://gitlab.com/libssh/libssh-mirror/merge_requests/79.

Dec 14 2019, 2:23 AM
simonsj created T205: ssh_curve25519_build_k: uninitialized input to `EVP_PKEY_derive` for HAVE_OPENSSL_X25519 builds can cause sporadic failure.
Dec 14 2019, 1:58 AM

Dec 11 2019

asn committed rLIBSSHd2a32ca6d3c4: torture: Accept whole pid_t range (authored by Jakuje).
torture: Accept whole pid_t range
Dec 11 2019, 11:40 AM
asn committed rLIBSSHe42307bbe392: tests: bigger sshd config buffer (fixes #T180) (authored by aris).
tests: bigger sshd config buffer (fixes #T180)
Dec 11 2019, 11:40 AM
asn committed rLIBSSH742d81ec5d96: include: Rename __unused__ to __attr_unused__ (authored by asn).
include: Rename __unused__ to __attr_unused__
Dec 11 2019, 11:40 AM
asn committed rLIBSSHb33dcda94d31: torture: Accept whole pid_t range (authored by Jakuje).
torture: Accept whole pid_t range
Dec 11 2019, 11:40 AM
asn committed rLIBSSHf0335d1b5949: tests: bigger sshd config buffer (fixes #T180) (authored by aris).
tests: bigger sshd config buffer (fixes #T180)
Dec 11 2019, 11:40 AM
asn committed rLIBSSHed87c2221c07: include: Rename __unused__ to __attr_unused__ (authored by asn).
include: Rename __unused__ to __attr_unused__
Dec 11 2019, 11:39 AM
asn committed rLIBSSHac2f4853bb6b: init: Fix documentation about return values of void functions (authored by Jakuje).
init: Fix documentation about return values of void functions
Dec 11 2019, 11:39 AM
Jakuje closed T203: Contradictory Source Code Documentation: Return Code for libssh_destructor as Resolved by committing rLIBSSHb03818aaedf2: init: Fix documentation about return values of void functions.
Dec 11 2019, 11:15 AM
Jakuje committed rLIBSSHb03818aaedf2: init: Fix documentation about return values of void functions (authored by Jakuje).
init: Fix documentation about return values of void functions
Dec 11 2019, 11:15 AM