Page MenuHomePhabricator
Feed All Stories

Today

Jakuje added a comment to T200: Test torture_proxycommand fails on ubuntu 18.04.

Congratulation to the issue #200 :)

Thu, Nov 21, 6:29 PM · Restricted Project
Jakuje added a comment to T180: tests: "bind: address already in use".

You are probably right. I was not able to reproduce it locally even from repetitive runs in the same container image with the same code.

Thu, Nov 21, 6:15 PM · Restricted Project
aris added a comment to T180: tests: "bind: address already in use".

Thanks for your comments. I saw the rekey test fail in other pipelines too, I think we have a probabilistic bug there, unrelated to this issue.

Thu, Nov 21, 4:57 PM · Restricted Project
Jakuje added a comment to T180: tests: "bind: address already in use".

Thanks. There are just a few nits I pointed out in the comments. The changes generally look good to me now and ready to merge (after the freeze -- see the email).

Thu, Nov 21, 4:54 PM · Restricted Project
aris added a comment to T180: tests: "bind: address already in use".

hi @Jakuje, I have updated the branch and I think I fixed all your concerns. I opened a separate ticket T200 for the remaining problems. I haven't tried the new CI image, I don't understand yet how to run the gitlab CI tests locally.

Thu, Nov 21, 4:23 PM · Restricted Project
aris created T200: Test torture_proxycommand fails on ubuntu 18.04.
Thu, Nov 21, 4:14 PM · Restricted Project

Yesterday

Jakuje added a comment to T180: tests: "bind: address already in use".

Update: Your branch passes for me locally in container with OpenSSL now with last fix. But the commits still need some love before we can merge them. Will you have some time to touch that in coming days so we can add the ubuntu targets?

Wed, Nov 20, 4:23 PM · Restricted Project
Jakuje added a comment to T180: tests: "bind: address already in use".

@aris I added the Ubuntu CI image, where I can successfully build libssh now:

Wed, Nov 20, 4:07 PM · Restricted Project

Mon, Nov 18

asn committed rLIBSSHc54fd03e50e2: cmake: Fix building libssh as a static lib on Windows (authored by asn).
cmake: Fix building libssh as a static lib on Windows
Mon, Nov 18, 12:07 PM
asn committed rLIBSSH7851f216afb7: cmake: Fix building libssh as a static lib on Windows (authored by asn).
cmake: Fix building libssh as a static lib on Windows
Mon, Nov 18, 12:07 PM
asn closed T198: MSVC issue with 0.9.2 static lib as Resolved by committing rLIBSSH7851f216afb7: cmake: Fix building libssh as a static lib on Windows.
Mon, Nov 18, 12:06 PM · Restricted Project

Sun, Nov 17

kostenre added a comment to T108: setting knownhost option to NULL crashes, at least before connecting.

who invented the internet come and get.

Sun, Nov 17, 6:51 AM · Restricted Project

Thu, Nov 14

asn added a comment to T198: MSVC issue with 0.9.2 static lib.

Could you try with https://gitlab.com/libssh/libssh-mirror/merge_requests/73 ?

Thu, Nov 14, 9:04 PM · Restricted Project

Tue, Nov 12

chcg updated the task description for T198: MSVC issue with 0.9.2 static lib.
Tue, Nov 12, 11:49 PM · Restricted Project
chcg updated the task description for T198: MSVC issue with 0.9.2 static lib.
Tue, Nov 12, 11:47 PM · Restricted Project
chcg created T198: MSVC issue with 0.9.2 static lib.
Tue, Nov 12, 11:44 PM · Restricted Project
chcg added a comment to T165: 0.9.0 gcc compiler warnings deprecated-declarations.

Fixed with 0.9.1 (https://travis-ci.org/ashkulz/NppFTP/jobs/611025905)
Thanks

Tue, Nov 12, 11:38 PM · Restricted Project
chcg added a comment to T164: 0.9.0 gcc compiler warnings incompatible-pointer-types.

Fixed with 0.9.1 (https://travis-ci.org/ashkulz/NppFTP/jobs/611025905)
Thanks

Tue, Nov 12, 11:35 PM · Restricted Project

Mon, Nov 11

Jakuje closed T197: Putty cannot negotiate when the SSH Server adds an ED25519 key as Resolved.

This should be addressed in the latest release 0.9.2. Not sure why it was not auto-closed with the commit referenced above.

Mon, Nov 11, 3:08 PM · Restricted Project

Fri, Nov 8

asn committed rLIBSSH9b316fe8b9a9: gitlab-ci: Make sure we have enough git commits for csbuild (authored by asn).
gitlab-ci: Make sure we have enough git commits for csbuild
Fri, Nov 8, 3:44 PM
asn committed rLIBSSHdb632015be44: gitlab-ci: Make sure we have enough git commits for csbuild (authored by asn).
gitlab-ci: Make sure we have enough git commits for csbuild
Fri, Nov 8, 2:37 PM

Thu, Nov 7

asn committed rLIBSSH389efc234b2d: src: Add missing ABI files (authored by asn).
src: Add missing ABI files
Thu, Nov 7, 4:21 PM
asn committed rLIBSSH54cf7b92edf8: server: Use really the negotiated signature type (authored by Jakuje).
server: Use really the negotiated signature type
Thu, Nov 7, 4:20 PM
asn committed rLIBSSHf1e44a79a995: Bump version to 0.9.2 (authored by asn).
Bump version to 0.9.2
Thu, Nov 7, 4:20 PM
asn committed rLIBSSHf0b676a9f00a: gitlab-ci: Disable client testing as pam_wrapper is broken on TW (authored by asn).
gitlab-ci: Disable client testing as pam_wrapper is broken on TW
Thu, Nov 7, 4:20 PM
asn committed rLIBSSH9de970160d82: cmake: Create ssh library directly as libssh (authored by asn).
cmake: Create ssh library directly as libssh
Thu, Nov 7, 4:20 PM
asn committed rLIBSSHcc190b21b286: cmake: Fix setting up cwrap for server testing (authored by asn).
cmake: Fix setting up cwrap for server testing
Thu, Nov 7, 4:20 PM
asn committed rLIBSSHa775324c35a1: cmake: Do not use cached LIBSSH_PUBLIC_INCLUDE_DIRS (authored by asn).
cmake: Do not use cached LIBSSH_PUBLIC_INCLUDE_DIRS
Thu, Nov 7, 4:20 PM
asn committed rLIBSSH5de765ebd506: cmake: Rename static library (authored by asn).
cmake: Rename static library
Thu, Nov 7, 4:20 PM
asn committed rLIBSSHc0fa85a43d05: cmake: Don't cache LIBSSH_LINK_LIBRARIES (authored by asn).
cmake: Don't cache LIBSSH_LINK_LIBRARIES
Thu, Nov 7, 4:20 PM
asn committed rLIBSSH8a7abf248011: cmake: Add option to build shared libs (authored by asn).
cmake: Add option to build shared libs
Thu, Nov 7, 4:20 PM
asn committed rLIBSSH920c08eaf8fc: cmake: Remove WITH_STATIC_LIB (authored by asn).
cmake: Remove WITH_STATIC_LIB
Thu, Nov 7, 4:20 PM
asn committed rLIBSSHbe16481be21a: cmake:pkd: Don't use LIBSSH_LINK_LIBRARIES (authored by asn).
cmake:pkd: Don't use LIBSSH_LINK_LIBRARIES
Thu, Nov 7, 4:20 PM
asn committed rLIBSSHc4ac07660747: cmake: Remove libsocket (authored by asn).
cmake: Remove libsocket
Thu, Nov 7, 4:19 PM
asn committed rLIBSSH27096c3c0f21: cmake: Only use OpenSSL Ed25519 implementation when possible (authored by ansasaki).
cmake: Only use OpenSSL Ed25519 implementation when possible
Thu, Nov 7, 4:19 PM
asn committed rLIBSSHff534bc2fe9a: cmake: Use target_include_directories() (authored by asn).
cmake: Use target_include_directories()
Thu, Nov 7, 4:19 PM
asn committed rLIBSSH1ebf50691349: server: Use really the negotiated signature type (authored by Jakuje).
server: Use really the negotiated signature type
Thu, Nov 7, 3:56 PM
asn closed T191: Server incorrectly assumes rsa-sha2-256 when client meant standard ssh-rsa as Resolved by committing rLIBSSH1ebf50691349: server: Use really the negotiated signature type.
Thu, Nov 7, 3:56 PM · Restricted Project
asn committed rLIBSSHfbc2912ddeb2: gitlab-ci: Disable client testing as pam_wrapper is broken on TW (authored by asn).
gitlab-ci: Disable client testing as pam_wrapper is broken on TW
Thu, Nov 7, 2:23 PM
asn committed rLIBSSHea4f71721fc4: cmake: Fix setting up cwrap for server testing (authored by asn).
cmake: Fix setting up cwrap for server testing
Thu, Nov 7, 2:23 PM
asn committed rLIBSSH8c36a865f267: cmake: Rename static library (authored by asn).
cmake: Rename static library
Thu, Nov 7, 2:23 PM
asn committed rLIBSSH4ab0fb2b48f3: cmake: Do not use cached LIBSSH_PUBLIC_INCLUDE_DIRS (authored by asn).
cmake: Do not use cached LIBSSH_PUBLIC_INCLUDE_DIRS
Thu, Nov 7, 2:23 PM
asn committed rLIBSSHc2c354539112: cmake: Add option to build shared libs (authored by asn).
cmake: Add option to build shared libs
Thu, Nov 7, 2:23 PM
asn committed rLIBSSH82c57c1f3656: cmake: Create ssh library directly as libssh (authored by asn).
cmake: Create ssh library directly as libssh
Thu, Nov 7, 2:23 PM
asn committed rLIBSSH729c92606c88: cmake: Remove WITH_STATIC_LIB (authored by asn).
cmake: Remove WITH_STATIC_LIB
Thu, Nov 7, 2:23 PM
asn committed rLIBSSH498b63949ef7: cmake: Don't cache LIBSSH_LINK_LIBRARIES (authored by asn).
cmake: Don't cache LIBSSH_LINK_LIBRARIES
Thu, Nov 7, 2:23 PM
asn committed rLIBSSH39f7ddaa06c5: cmake:pkd: Don't use LIBSSH_LINK_LIBRARIES (authored by asn).
cmake:pkd: Don't use LIBSSH_LINK_LIBRARIES
Thu, Nov 7, 2:22 PM
asn committed rLIBSSH29d360dc702c: examples: Build keygen2 only if argp is available (authored by ansasaki).
examples: Build keygen2 only if argp is available
Thu, Nov 7, 2:22 PM
asn committed rLIBSSH2fcc15c5dcf7: cmake: Remove libsocket (authored by asn).
cmake: Remove libsocket
Thu, Nov 7, 2:22 PM
asn committed rLIBSSH5e2788d4c54d: cmake: Use target_include_directories() (authored by asn).
cmake: Use target_include_directories()
Thu, Nov 7, 2:22 PM
asn committed rLIBSSHb30875c6c743: examples: Added keygen2 example (authored by ansasaki).
examples: Added keygen2 example
Thu, Nov 7, 12:15 PM
asn committed rLIBSSH21655e396c8d: cmake: Only use OpenSSL Ed25519 implementation when possible (authored by ansasaki).
cmake: Only use OpenSSL Ed25519 implementation when possible
Thu, Nov 7, 12:15 PM

Wed, Nov 6

fcharlie added a comment to T197: Putty cannot negotiate when the SSH Server adds an ED25519 key.

I applied the changes to ConfigureChecks.cmake to libssh 0.9.1. After testing, putty can connect to my SSH server. Thank you for fixing this problem.

Wed, Nov 6, 2:35 AM · Restricted Project

Tue, Nov 5

ansasaki added a comment to T197: Putty cannot negotiate when the SSH Server adds an ED25519 key.

Could you try to apply the patch from this pull request and check if it fixes the issue for you?

Tue, Nov 5, 4:42 PM · Restricted Project

Mon, Nov 4

aris added a comment to T180: tests: "bind: address already in use".

Hi @Jakuje, thanks for your review. All your comments are directly actionable so I'll fix them asap.
the two pkd tests that failed are related to my changes and bug T191 that I discovered this way, so I think we should merge it and acknowledge that there are unfixed bugs on our tree.
A few CI targets have two more failing tests. I didn't manage to reproduce them, I'm not sure if they did not exist before.
I'll see what I should do to have ubuntu as part of the CI targets. It makes totally sense because ubuntu is breaking every time I want to catch up on libssh dev :)

Mon, Nov 4, 1:52 PM · Restricted Project
ansasaki added a comment to T197: Putty cannot negotiate when the SSH Server adds an ED25519 key.

The problem is that the used OpenSSL has the EVP_PKEY_ED25519 type in openssl/evp.h, but does not support the single shot EVP_DigestSign(). When I wrote the detection to switch to the OpenSSL implementation, I thought this combination would be impossible since ed25519 can only be used in single shot operations. The solution is to require both HAVE_OPENSSL_ED25519 and HAVE_OPENSSL_EVP_DIGESTSIGN to switch to OpenSSL implementation.

Mon, Nov 4, 1:08 PM · Restricted Project
Jakuje updated subscribers of T197: Putty cannot negotiate when the SSH Server adds an ED25519 key.

@ansasaki This looks directly related to the ed25519 support you modified to use OpenSSL. Can you check what might have gone wrong?

Mon, Nov 4, 12:34 PM · Restricted Project
Jakuje added a comment to T180: tests: "bind: address already in use".

@aris your commits are missing Sign-off. I added my review. I also see many failed pkd tests in the last CI run with Fedora. Are they related to your changes?

Mon, Nov 4, 12:33 PM · Restricted Project
aris added a comment to T180: tests: "bind: address already in use".

Could you please review my patches from https://gitlab.com/arisada/libssh-mirror/tree/fix-tests-ubuntu-tomerge ? There are fixes to this issue but also a testcase for T191.

Mon, Nov 4, 10:47 AM · Restricted Project
asn committed rLIBSSHd02c06268eae: gitlab-ci: Mips is dead (authored by asn).
gitlab-ci: Mips is dead
Mon, Nov 4, 9:56 AM
asn committed rLIBSSHe5767bf0b778: channel: Document ssh_channel_request_sftp() (authored by asn).
channel: Document ssh_channel_request_sftp()
Mon, Nov 4, 9:56 AM
asn committed rLIBSSH4a113159b2f3: auth: Add missing include for explicit_bzero() (authored by asn).
auth: Add missing include for explicit_bzero()
Mon, Nov 4, 9:56 AM
asn committed rLIBSSH8a6ddc0a4892: gitlab-ci: Mips is dead (authored by asn).
gitlab-ci: Mips is dead
Mon, Nov 4, 9:56 AM
asn committed rLIBSSH0c951b9f27ac: channel: Document ssh_channel_request_sftp() (authored by asn).
channel: Document ssh_channel_request_sftp()
Mon, Nov 4, 9:56 AM
asn committed rLIBSSH2fbeb2ac885f: gitlab-ci: Mips is dead (authored by asn).
gitlab-ci: Mips is dead
Mon, Nov 4, 9:56 AM
asn committed rLIBSSH37529f16a8b7: auth: Add missing include for explicit_bzero() (authored by asn).
auth: Add missing include for explicit_bzero()
Mon, Nov 4, 9:56 AM
fcharlie updated the task description for T197: Putty cannot negotiate when the SSH Server adds an ED25519 key.
Mon, Nov 4, 3:50 AM · Restricted Project
fcharlie updated the task description for T197: Putty cannot negotiate when the SSH Server adds an ED25519 key.
Mon, Nov 4, 3:39 AM · Restricted Project
fcharlie updated the task description for T197: Putty cannot negotiate when the SSH Server adds an ED25519 key.
Mon, Nov 4, 3:33 AM · Restricted Project
fcharlie renamed T197: Putty cannot negotiate when the SSH Server adds an ED25519 key from Putty cannot negotiate when the SSH Server adds an ECDSA key to Putty cannot negotiate when the SSH Server adds an ED25519 key.
Mon, Nov 4, 3:30 AM · Restricted Project
fcharlie added a comment to T191: Server incorrectly assumes rsa-sha2-256 when client meant standard ssh-rsa.

@Jakuje New Task: https://bugs.libssh.org/T197

Mon, Nov 4, 2:36 AM · Restricted Project
fcharlie created T197: Putty cannot negotiate when the SSH Server adds an ED25519 key.
Mon, Nov 4, 2:34 AM · Restricted Project

Fri, Nov 1

Jakuje added a comment to T191: Server incorrectly assumes rsa-sha2-256 when client meant standard ssh-rsa.

Sounds like an issue with the ed25519 keys then. Can you open a separate issue, since this is indeed different one than the reported above (RSA keys). Clarifying what openssl version are you using and whether it has enable support for ED25519 keys would help.

Fri, Nov 1, 10:06 AM · Restricted Project
fcharlie added a comment to T191: Server incorrectly assumes rsa-sha2-256 when client meant standard ssh-rsa.

@Jakuje Thanks for your code, but I found it seems that EVP_DigestSignUpdate reported an error

Fri, Nov 1, 2:40 AM · Restricted Project

Thu, Oct 31

Jakuje added a comment to T191: Server incorrectly assumes rsa-sha2-256 when client meant standard ssh-rsa.

This should be handled by the code in kex.c. It correctly sets the session->extensions bit field based on what is supported by the client in the key exchange. The problem here is that it informs only about the support of these extensions, but not about their priority and whether to prefer the SHA1 hash or the SHA2 ones. There is already attempt to detect whether the SHA256 or SHA519 was preferred, but this particular use case is not handled (what is the point in signaling that I know stronger algorithms, but prefer the SHA1?).

Thu, Oct 31, 1:08 PM · Restricted Project

Tue, Oct 29

fcharlie added a comment to T191: Server incorrectly assumes rsa-sha2-256 when client meant standard ssh-rsa.

The ssh-rsa key generated by puttygen can reproduce this error.

Tue, Oct 29, 1:36 PM · Restricted Project
ansasaki claimed T191: Server incorrectly assumes rsa-sha2-256 when client meant standard ssh-rsa.

Thanks for reporting this.

Tue, Oct 29, 11:28 AM · Restricted Project

Mon, Oct 28

slydder updated the task description for T192: Reusing a session results in timeout at user_auth_password.
Mon, Oct 28, 8:28 AM · Restricted Project
slydder updated the task description for T192: Reusing a session results in timeout at user_auth_password.
Mon, Oct 28, 8:27 AM · Restricted Project
slydder created T192: Reusing a session results in timeout at user_auth_password.
Mon, Oct 28, 8:27 AM · Restricted Project

Sun, Oct 27

aris created T191: Server incorrectly assumes rsa-sha2-256 when client meant standard ssh-rsa.
Sun, Oct 27, 11:01 PM · Restricted Project

Fri, Oct 25

asn committed rLIBSSHe89106b9f740: cpack: Ignore compule_database.json and clangd dir (authored by asn).
cpack: Ignore compule_database.json and clangd dir
Fri, Oct 25, 5:30 PM
asn committed rLIBSSHa4b95268eef8: cmake: Link compile database to source dir for clangd (authored by asn).
cmake: Link compile database to source dir for clangd
Fri, Oct 25, 5:29 PM
asn committed rLIBSSH67c0ce3d219a: cmake: Bump version to 0.9.1 (authored by asn).
cmake: Bump version to 0.9.1
Fri, Oct 25, 4:41 PM
asn committed rLIBSSHf618689c82d1: cmake: Bump library version (authored by asn).
cmake: Bump library version
Fri, Oct 25, 4:41 PM
asn committed rLIBSSHaaeaca8c6ebd: cmake: Link compile database to source dir for clangd (authored by asn).
cmake: Link compile database to source dir for clangd
Fri, Oct 25, 4:41 PM
asn committed rLIBSSH58c26f482349: packet: On failure, do not use uninitialized crypto (authored by Jakuje).
packet: On failure, do not use uninitialized crypto
Fri, Oct 25, 4:41 PM
asn committed rLIBSSHc888d9c690ed: packet_crypt: Avoid out of bounds access in debug functions (authored by Jakuje).
packet_crypt: Avoid out of bounds access in debug functions
Fri, Oct 25, 4:41 PM
asn committed rLIBSSH07df7bb4e62d: tests: Do not parse global config in torture_ssh_session() (authored by ansasaki).
tests: Do not parse global config in torture_ssh_session()
Fri, Oct 25, 4:41 PM
asn committed rLIBSSHf199bd48795b: tests: Use temporary file for known_hosts (authored by ansasaki).
tests: Use temporary file for known_hosts
Fri, Oct 25, 4:40 PM
asn committed rLIBSSHa47a291303b5: tests: Do not process config when reinitializing session (authored by ansasaki).
tests: Do not process config when reinitializing session
Fri, Oct 25, 4:40 PM
asn committed rLIBSSH50b37f299148: tests: Do not process server config during tests (authored by ansasaki).
tests: Do not process server config during tests
Fri, Oct 25, 4:40 PM
asn committed rLIBSSH5aecfb5a966d: tests: Do not parse global configuration when testing server (authored by ansasaki).
tests: Do not parse global configuration when testing server
Fri, Oct 25, 4:40 PM
asn committed rLIBSSH8a50dbc6ba33: tests: Do not parse global config in torture_ssh_session() (authored by ansasaki).
tests: Do not parse global config in torture_ssh_session()
Fri, Oct 25, 4:11 PM
asn committed rLIBSSH040aa0edfeb4: tests: Do not process server config during tests (authored by ansasaki).
tests: Do not process server config during tests
Fri, Oct 25, 4:10 PM
asn committed rLIBSSH85239c8ea04b: tests: Do not parse global configuration when testing server (authored by ansasaki).
tests: Do not parse global configuration when testing server
Fri, Oct 25, 4:10 PM
asn committed rLIBSSHf97a8b4e3f60: tests: Do not process config when reinitializing session (authored by ansasaki).
tests: Do not process config when reinitializing session
Fri, Oct 25, 4:10 PM
asn committed rLIBSSHd4fe8e1f6281: tests: Use temporary file for known_hosts (authored by ansasaki).
tests: Use temporary file for known_hosts
Fri, Oct 25, 4:10 PM
Jakuje committed rLIBSSHe9e8292370ca: packet: On failure, do not use uninitialized crypto (authored by Jakuje).
packet: On failure, do not use uninitialized crypto
Fri, Oct 25, 3:09 PM
Jakuje committed rLIBSSH5a0177def02d: packet_crypt: Avoid out of bounds access in debug functions (authored by Jakuje).
packet_crypt: Avoid out of bounds access in debug functions
Fri, Oct 25, 3:08 PM