Page MenuHomePhabricator
Feed All Stories

Mon, May 25

Jakuje added a comment to T231: ssh_channel_read() incorrectly returns -1 (SSH_ERROR).

Right. It affects only 0.9.x versions. The above commit mentions which revision introduced this issue. The commit is already backported in the stable-0.9 branch so it will be in the next 0.9.5 release

Mon, May 25, 6:56 PM
rimdenok added a comment to T231: ssh_channel_read() incorrectly returns -1 (SSH_ERROR).

It is fixed in the master.

Mon, May 25, 2:44 PM
Jakuje committed rLIBSSH39bb93a53b77: options: Do not reference non-existing function (authored by Jakuje).
options: Do not reference non-existing function
Mon, May 25, 2:00 PM
Jakuje committed rLIBSSH866e4442b529: Removed old, 10 years unused test files (authored by Jakuje).
Removed old, 10 years unused test files
Mon, May 25, 2:00 PM
Jakuje closed T227: `ssh_options_parse_config()` mentions non-existent `ssh_options_set_host()` as Resolved by committing rLIBSSH39bb93a53b77: options: Do not reference non-existing function.
Mon, May 25, 2:00 PM · Restricted Project
Jakuje added a comment to T231: ssh_channel_read() incorrectly returns -1 (SSH_ERROR).

Could it be a duplicate of an issue described and fixed in this commit [1]? It was also discussed in mailing list recently. Does it work with current master?

Mon, May 25, 12:44 PM

Fri, May 22

rimdenok updated the task description for T231: ssh_channel_read() incorrectly returns -1 (SSH_ERROR).
Fri, May 22, 5:34 PM
rimdenok updated the task description for T231: ssh_channel_read() incorrectly returns -1 (SSH_ERROR).
Fri, May 22, 3:43 PM
rimdenok renamed T231: ssh_channel_read() incorrectly returns -1 (SSH_ERROR) from ssh_channel_read() incorrectly returns SSH_ERROR to ssh_channel_read() incorrectly returns -1 (SSH_ERROR).
Fri, May 22, 3:43 PM
rimdenok updated the task description for T231: ssh_channel_read() incorrectly returns -1 (SSH_ERROR).
Fri, May 22, 3:39 PM
rimdenok created T231: ssh_channel_read() incorrectly returns -1 (SSH_ERROR).
Fri, May 22, 3:38 PM

Thu, May 21

Jakuje claimed T227: `ssh_options_parse_config()` mentions non-existent `ssh_options_set_host()`.
Thu, May 21, 1:30 PM · Restricted Project
Jakuje closed T223: libssh crashes when ecdsa pkcs #11 private keys are imported without importing ecdsa pkcs #11 public keys as Resolved.

Merged as 4e4711d2 and friends.

Thu, May 21, 11:51 AM · Restricted Project
Jakuje closed T225: Missing #include makes that compiling example fails as Resolved.

Fixed in previously mentioned commits.

Thu, May 21, 11:29 AM · Restricted Project

Wed, May 20

sahanaprasad07 committed rLIBSSH4e4711d2fbe7: unittests: updates torture_pki_ecdsa_uri test by adding negative test cases to… (authored by sahanaprasad07).
unittests: updates torture_pki_ecdsa_uri test by adding negative test cases to…
Wed, May 20, 1:59 PM
sahanaprasad07 committed rLIBSSH7de9722d23c4: src/pki_crypto.c pki_publickey_to_blob() should not be used to export public… (authored by sahanaprasad07).
src/pki_crypto.c pki_publickey_to_blob() should not be used to export public…
Wed, May 20, 1:59 PM
sahanaprasad07 committed rLIBSSH7eb6c7ee6c16: tests/torture.c: update the definition of torture_setup_tokens() to take… (authored by sahanaprasad07).
tests/torture.c: update the definition of torture_setup_tokens() to take…
Wed, May 20, 1:59 PM
sahanaprasad07 committed rLIBSSHd3f7b64579a2: tests/pkcs11/setup-softhsm-tokens.sh: updates the script to handle LOADPUBLIC… (authored by sahanaprasad07).
tests/pkcs11/setup-softhsm-tokens.sh: updates the script to handle LOADPUBLIC…
Wed, May 20, 1:59 PM

Fri, May 15

asn committed rLIBSSH641a80be7463: cmake: add _POSIX_SOURCE (authored by davidwed).
cmake: add _POSIX_SOURCE
Fri, May 15, 7:26 PM
asn closed T228: Access violation with MinGW-W64 as Resolved by committing rLIBSSHdcc0b9d7aa09: cmake: add _POSIX_SOURCE.
Fri, May 15, 7:26 PM · Restricted Project
asn committed rLIBSSHdcc0b9d7aa09: cmake: add _POSIX_SOURCE (authored by davidwed).
cmake: add _POSIX_SOURCE
Fri, May 15, 7:26 PM
davidwed updated the task description for T228: Access violation with MinGW-W64.
Fri, May 15, 11:09 AM · Restricted Project

Thu, May 14

sahanaprasad07 added a comment to T223: libssh crashes when ecdsa pkcs #11 private keys are imported without importing ecdsa pkcs #11 public keys.

Fixed in https://gitlab.com/libssh/libssh-mirror/-/merge_requests/118

Thu, May 14, 8:51 PM · Restricted Project

Mon, May 11

davidwed updated the task description for T228: Access violation with MinGW-W64.
Mon, May 11, 8:32 AM · Restricted Project
davidwed updated the task description for T228: Access violation with MinGW-W64.
Mon, May 11, 12:36 AM · Restricted Project

Thu, May 7

Jakuje closed T85: missing cipher 'none' as Resolved.

FYI, this landed as e6aee24a

Thu, May 7, 6:53 PM · Restricted Project
davidwed renamed T228: Access violation with MinGW-W64 from Access violation with MinGW64 to Access violation with MinGW-W64.
Thu, May 7, 4:52 PM · Restricted Project
davidwed renamed T228: Access violation with MinGW-W64 from Access violation with MinGW to Access violation with MinGW64.
Thu, May 7, 4:49 PM · Restricted Project
asn committed rLIBSSHb1bbd20dfa8a: cmake: Add autogenerated libssh_version.h (authored by Heiko Thiery <heiko.thiery@gmail.com>).
cmake: Add autogenerated libssh_version.h
Thu, May 7, 12:01 PM
asn committed rLIBSSHbee8ed82abbc: cmake: Add autogenerated libssh_version.h (authored by Heiko Thiery <heiko.thiery@gmail.com>).
cmake: Add autogenerated libssh_version.h
Thu, May 7, 11:59 AM

Wed, May 6

Jakuje triaged T230: OpenSSL memory sanity check as Wishlist priority.
Wed, May 6, 11:51 AM · Restricted Project

Tue, May 5

davidwed updated the task description for T228: Access violation with MinGW-W64.
Tue, May 5, 3:02 PM · Restricted Project
davidwed created T228: Access violation with MinGW-W64.
Tue, May 5, 2:57 PM · Restricted Project
asn committed rLIBSSH4149cebd64a9: fuzz: Avoid warnings from csbuild in fuzzers (authored by Jakuje).
fuzz: Avoid warnings from csbuild in fuzzers
Tue, May 5, 2:40 PM
asn committed rLIBSSH425c02cb9437: fuzz: Add instructions for corpus creation and first corpus files (authored by Jakuje).
fuzz: Add instructions for corpus creation and first corpus files
Tue, May 5, 2:40 PM
asn committed rLIBSSHad8dedd4a481: fuzz: Allow to increase log level from server fuzzer (authored by Jakuje).
fuzz: Allow to increase log level from server fuzzer
Tue, May 5, 2:40 PM
asn committed rLIBSSHe26e98e59f93: fuzz: Do not parse configuration files (authored by Jakuje).
fuzz: Do not parse configuration files
Tue, May 5, 2:40 PM
asn committed rLIBSSHae184db913ae: fuzz: Use none cipher and MAC (authored by Jakuje).
fuzz: Use none cipher and MAC
Tue, May 5, 2:40 PM
asn committed rLIBSSHb88aa98550dc: Allow example client and server to process different configuration files (authored by Jakuje).
Allow example client and server to process different configuration files
Tue, May 5, 2:40 PM
asn committed rLIBSSH08a70bb4745c: tests: Cover ssh_options_getopt with unit tests (authored by Jakuje).
tests: Cover ssh_options_getopt with unit tests
Tue, May 5, 2:40 PM
asn committed rLIBSSH3d0ecd37fe6b: options: Avoid memory leaks during modification of argv (authored by Jakuje).
options: Avoid memory leaks during modification of argv
Tue, May 5, 2:40 PM
asn committed rLIBSSH2e7ca3e8a6e1: options: Properly handle unknown options with arguments (authored by Jakuje).
options: Properly handle unknown options with arguments
Tue, May 5, 2:39 PM
asn committed rLIBSSHb90131dfe696: tests: Verify functionality of none cipher and mac (authored by Jakuje).
tests: Verify functionality of none cipher and mac
Tue, May 5, 2:39 PM
asn committed rLIBSSH4f976ce5c4a3: packet: Skip HMAC handling if none is selected (authored by Jakuje).
packet: Skip HMAC handling if none is selected
Tue, May 5, 2:39 PM
asn committed rLIBSSH239eef6322d1: packet: Check if set_*_key functions exists before calling it (authored by Jakuje).
packet: Check if set_*_key functions exists before calling it
Tue, May 5, 2:39 PM
asn committed rLIBSSHe6aee24a1e3b: Add basic support for none cipher and MACs (authored by Jakuje).
Add basic support for none cipher and MACs
Tue, May 5, 2:39 PM
asn committed rLIBSSH201fd661767f: packet: Use temporary variables to avoid long lines (authored by Jakuje).
packet: Use temporary variables to avoid long lines
Tue, May 5, 2:39 PM
asn committed rLIBSSH46499b1b9090: Drop none cipher and MAC as they are not implemented (authored by Jakuje).
Drop none cipher and MAC as they are not implemented
Tue, May 5, 2:39 PM
asn committed rLIBSSH62a0229f16cd: fuzz: Simplify definition of fuzzing targets and build them also with gcc (authored by Jakuje).
fuzz: Simplify definition of fuzzing targets and build them also with gcc
Tue, May 5, 2:39 PM
asn committed rLIBSSH5411e0821fdd: fuzz: Correctly sort members initialization to prevent GCC warnings (authored by Jakuje).
fuzz: Correctly sort members initialization to prevent GCC warnings
Tue, May 5, 2:39 PM
asn committed rLIBSSH44de453b2271: tests: Enable all CASignatureAlgorithms as SHA1 certificates are now disabled… (authored by Jakuje).
tests: Enable all CASignatureAlgorithms as SHA1 certificates are now disabled…
Tue, May 5, 2:39 PM
asn committed rLIBSSH7c2087589122: pki: Mark explicit fall through (authored by Jakuje).
pki: Mark explicit fall through
Tue, May 5, 2:39 PM
asn committed rLIBSSH0c7a772301cb: external: Do not confuse new gcc (authored by Jakuje).
external: Do not confuse new gcc
Tue, May 5, 2:39 PM
asn committed rLIBSSHc45cfce166f3: client: Properly indicate fall through (authored by Jakuje).
client: Properly indicate fall through
Tue, May 5, 2:39 PM
asn committed rLIBSSH929a6b7d501b: pki: Mark explicit fall through (authored by Jakuje).
pki: Mark explicit fall through
Tue, May 5, 2:39 PM
asn committed rLIBSSH88d676cf1a1d: external: Do not confuse new gcc (authored by Jakuje).
external: Do not confuse new gcc
Tue, May 5, 2:39 PM
asn committed rLIBSSHb93c9ae641a1: client: Properly indicate fall through (authored by Jakuje).
client: Properly indicate fall through
Tue, May 5, 2:38 PM
asn committed rLIBSSHa77d89d3ea73: session: add missing return value documentation (authored by Heiko Thiery <heiko.thiery@gmail.com>).
session: add missing return value documentation
Tue, May 5, 2:38 PM
asn committed rLIBSSH4276560680f0: channels: Avoid returning SSH_AGAIN from ssh_channel_poll_timeout() (authored by Jakuje).
channels: Avoid returning SSH_AGAIN from ssh_channel_poll_timeout()
Tue, May 5, 2:38 PM
asn committed rLIBSSHa7ce241652b2: channels: reformat (authored by Jakuje).
channels: reformat
Tue, May 5, 2:38 PM
asn committed rLIBSSH98c91e68fa8c: examples: Add missing includes (authored by Jakuje).
examples: Add missing includes
Tue, May 5, 2:38 PM
asn committed rLIBSSH1c7cfaba9cda: examples: Avoid unused parameter warnings and reformat (authored by Jakuje).
examples: Avoid unused parameter warnings and reformat
Tue, May 5, 2:38 PM
asn committed rLIBSSH078cb4c6f359: libcrypto-compat: Fix indentation and return value (authored by Jakuje).
libcrypto-compat: Fix indentation and return value
Tue, May 5, 2:38 PM
asn committed rLIBSSHd35fdfbdb417: libcrypto-compat: add extra functions (authored by Rosen Penev <rosenp@gmail.com>).
libcrypto-compat: add extra functions
Tue, May 5, 2:38 PM
asn committed rLIBSSH5972d7a98e10: libcrypto: remove deprecated API usage (authored by Rosen Penev <rosenp@gmail.com>).
libcrypto: remove deprecated API usage
Tue, May 5, 2:38 PM
asn committed rLIBSSH7ee7ff94ba31: Fix FTBFS on hurd-i386 (authored by bigon).
Fix FTBFS on hurd-i386
Tue, May 5, 2:38 PM
asn committed rLIBSSH69e97057c7ed: Correctly parse v4 subsecond timestamps (authored by StefanBruens).
Correctly parse v4 subsecond timestamps
Tue, May 5, 2:37 PM
asn committed rLIBSSHc42aab0122c7: Make the documentation reproducible (authored by bigon).
Make the documentation reproducible
Tue, May 5, 2:37 PM
asn committed rLIBSSH3025eeace355: client: Check if the library is initialized in ssh_connect() (authored by ansasaki).
client: Check if the library is initialized in ssh_connect()
Tue, May 5, 2:37 PM
asn committed rLIBSSHffb000776819: client: Reformat ssh_connect() (authored by ansasaki).
client: Reformat ssh_connect()
Tue, May 5, 2:37 PM
asn committed rLIBSSH0a450f02513d: init: Clarify the need to call ssh_{init, finalize}() (authored by ansasaki).
init: Clarify the need to call ssh_{init, finalize}()
Tue, May 5, 2:37 PM
asn committed rLIBSSHa99b8a397973: init: Introduce internal is_ssh_initialized() (authored by ansasaki).
init: Introduce internal is_ssh_initialized()
Tue, May 5, 2:37 PM

Thu, Apr 30

bonnysmith9090 updated bonnysmith9090.
Thu, Apr 30, 1:41 PM
bonnysmith9090 updated bonnysmith9090.
Thu, Apr 30, 1:41 PM

Apr 24 2020

Jakuje committed rLIBSSH99e0ad75a6d1: tests: add testcases for ssh_channel_poll_timeout() (authored by Heiko Thiery <heiko.thiery@gmail.com>).
tests: add testcases for ssh_channel_poll_timeout()
Apr 24 2020, 4:17 PM
Jakuje committed rLIBSSHe76332bbd617: session: add missing return value documentation (authored by Heiko Thiery <heiko.thiery@gmail.com>).
session: add missing return value documentation
Apr 24 2020, 4:17 PM

Apr 22 2020

Jakuje added a comment to T227: `ssh_options_parse_config()` mentions non-existent `ssh_options_set_host()`.

It is still needed as the configuration parsing requires the hostname to evaluate conditional match blocks. But the new API ssh_options_set() should be used and documentation updated accordingly. The documentation should also mention that if it is not called, it is called automatically on connect.

Apr 22 2020, 9:05 PM · Restricted Project
ansasaki created T227: `ssh_options_parse_config()` mentions non-existent `ssh_options_set_host()`.
Apr 22 2020, 11:35 AM · Restricted Project

Apr 21 2020

Jakuje closed T218: Disable ssh-rsa (sha1) keys by default as Resolved.

The previously mentioned commit disables the RSA-SHA1 and DSA algorithms by default.

Apr 21 2020, 5:18 PM · Restricted Project

Apr 20 2020

Jakuje committed rLIBSSH154765ae8ca5: config: Check null deref (authored by Jakuje).
config: Check null deref
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH6417f5a3cac8: channels: Avoid returning SSH_AGAIN from ssh_channel_poll_timeout() (authored by Jakuje).
channels: Avoid returning SSH_AGAIN from ssh_channel_poll_timeout()
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSHfe0fcbbc67e3: channels: reformat (authored by Jakuje).
channels: reformat
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSHc2f64108a152: examples: Avoid unused parameter warnings and reformat (authored by Jakuje).
examples: Avoid unused parameter warnings and reformat
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH59ac79c4dcdf: gitlab-ci: Avoid passing artifacts between completely unrelated stages (authored by Jakuje).
gitlab-ci: Avoid passing artifacts between completely unrelated stages
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH7f57717f84f0: gitlab-ci: Fix typo (authored by Jakuje).
gitlab-ci: Fix typo
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSHdb948bdac87e: tests: Enable RSA SHA1 certs for testing against older OpenSSH (authored by Jakuje).
tests: Enable RSA SHA1 certs for testing against older OpenSSH
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH6941958b4954: tests: Update coverage of config_parser (authored by Jakuje).
tests: Update coverage of config_parser
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH1ba6ef689fe7: config_parser: Allow equal sign as a separator and eat up trailing whitespace (authored by Jakuje).
config_parser: Allow equal sign as a separator and eat up trailing whitespace
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSHfecdc3cc0e6d: Disable RSA and DSA keys with sha1 by default (authored by Jakuje).
Disable RSA and DSA keys with sha1 by default
Apr 20 2020, 2:43 PM
Jakuje closed T210: Crash in libssh in canonical multipass due to certain entries in `~/.ssh/config` as Resolved by committing rLIBSSH1ba6ef689fe7: config_parser: Allow equal sign as a separator and eat up trailing whitespace.
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH04ae110c612f: pkd: Enable all hostkeys (authored by Jakuje).
pkd: Enable all hostkeys
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH9ac2d1470763: tests: Enable all host key algorithms in testing client (authored by Jakuje).
tests: Enable all host key algorithms in testing client
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSHbab2c775da62: Make the testing ping use all supported algorithms (authored by Jakuje).
Make the testing ping use all supported algorithms
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH58d53f1397c9: examples: Add missing includes (authored by Jakuje).
examples: Add missing includes
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSH945829a5dd3d: Reformat ssh_bind_accept() (authored by Jakuje).
Reformat ssh_bind_accept()
Apr 20 2020, 2:43 PM
Jakuje committed rLIBSSHeebb02fff52c: libcrypto-compat: Fix indentation and return value (authored by Jakuje).
libcrypto-compat: Fix indentation and return value
Apr 20 2020, 2:42 PM
Jakuje committed rLIBSSH70478619cec7: libcrypto-compat: add extra functions (authored by Rosen Penev <rosenp@gmail.com>).
libcrypto-compat: add extra functions
Apr 20 2020, 2:42 PM
Jakuje committed rLIBSSH54296787a79e: libcrypto: remove deprecated API usage (authored by Rosen Penev <rosenp@gmail.com>).
libcrypto: remove deprecated API usage
Apr 20 2020, 2:42 PM

Apr 16 2020

adelton added a comment to T226: Version number of LIBSSH_VERSION_MICRO for 0.9.4 and 0.8.9 release not updated.

This also breaks my python-libssh testing: https://travis-ci.org/github/adelton/python-libssh/jobs/675211702 in Fedora rawhide as I'm testing that the versions reported by the library and by the rpm match. Is there a plan to bring the LIBSSH_VERSION in sync with the library version?

Apr 16 2020, 6:40 PM · Restricted Project
Jakuje closed T174: pkd_hello fails for some host key types as Resolved.

AFAIK this was already addressed by using ssh -Q to query openssh supported algorithms and we have ubuntu 18.04 in CI to prevent similar issues in future.

Apr 16 2020, 12:41 PM · Restricted Project