Page MenuHomePhabricator
Feed Advanced Search

Tue, Dec 4

Jakuje added a comment to T109: ProxyCommand for jump host configuration broken.

@maiphi can you provide some debug log from libssh or at least the error you see? From what is covered in the test cases now, it should work with current libssh, but I do not think we will be able to establish two separate networks with the socket wrapper to reproduce the issue in the full size in the testsuite.

Tue, Dec 4, 2:20 PM · Unknown Object (Project)

Wed, Nov 28

Jakuje closed T105: HostKeyAlgorithms: Check if there is an entry in known_hosts and prefer that as Resolved.
Wed, Nov 28, 2:02 PM · Unknown Object (Project)
Jakuje closed T107: ssh_session_has_known_hosts_entry doesn't seem to check in opts.global_knownhosts as Resolved.

This should be resolved by f622c4309b0ffe4679bd1b124638fc1bcddb5758

Wed, Nov 28, 2:01 PM · Unknown Object (Project)

Tue, Nov 27

Jakuje added a comment to T122: Running the sftp_read test for the second time fails.

After getting in a bit deeper, it really looks like the sshd is really closing the socket while doing something with PAM. The last logs from sshd are these in most of the cases:

debug2: input_userauth_request: try method none [preauth]
debug3: user_specific_delay: user specific delay 0.000ms [preauth]
debug3: ensure_minimum_time_since: elapsed 0.532ms, delaying 4.863ms (requested 5.395ms) [preauth]
debug3: mm_request_receive entering
debug3: monitor_read: checking request 100
debug1: PAM: initializing for "alice"

After that the socket is closed, test fails and the test kills the sshd.

Tue, Nov 27, 4:37 PM · Unknown Object (Project)

Sun, Nov 25

Jakuje closed T108: setting knownhost option to NULL crashes, at least before connecting as Resolved.

Should be resolved by the attached commits in both master and stable 0.8 branches.

Sun, Nov 25, 12:22 PM · Unknown Object (Project)

Mon, Nov 19

Jakuje added a comment to T122: Running the sftp_read test for the second time fails.

After more hours of digging in the code, I isolated this to the two SFTP calls that cause this issue to be reproducible reliably. These are calls to ssh_channel_send_eof() and ssh_channel_free() from sftp_free() called from the cleanup of the first sftp. If I remove these two calls, the testsuite passes reproducibly.

Mon, Nov 19, 3:50 PM · Unknown Object (Project)

Fri, Nov 16

Jakuje created T122: Running the sftp_read test for the second time fails.
Fri, Nov 16, 4:37 PM · Unknown Object (Project)

Tue, Nov 13

Jakuje created T121: The server should not send the SSH_MSG_EXT_INFO message after rekeying.
Tue, Nov 13, 3:39 PM · Unknown Object (Project)

Nov 6 2018

Jakuje added a comment to T108: setting knownhost option to NULL crashes, at least before connecting.

No, this issue is still present it I am right.

Nov 6 2018, 2:29 PM · Unknown Object (Project)
Jakuje added a comment to T109: ProxyCommand for jump host configuration broken.

Probably not. I assume this is not only about configuration parser (which was fixed in several aspects recently), but instead about the way how the proxycommand is implemented in libssh (I am actually not sure how does it work there). The important are errors with ProxyCommand, but for further investigation, some debugging log will be needed:

Nov 6 2018, 2:23 PM · Unknown Object (Project)

Nov 2 2018

Jakuje committed rLIBSSH7e44ce155639: tests: Improve error reporting in auth test (authored by Jakuje).
tests: Improve error reporting in auth test
Nov 2 2018, 12:00 PM
Jakuje committed rLIBSSH5fc4d5b22af3: tests: Typo -- the flags should be checked according to the comment (authored by Jakuje).
tests: Typo -- the flags should be checked according to the comment
Nov 2 2018, 12:00 PM
Jakuje committed rLIBSSH5159cd96e8b6: knownhosts: Make sure we have both knownhosts files ready (authored by Jakuje).
knownhosts: Make sure we have both knownhosts files ready
Nov 2 2018, 12:00 PM
Jakuje committed rLIBSSH35c417312c0b: client: Reformat comment (authored by Jakuje).
client: Reformat comment
Nov 2 2018, 12:00 PM
Jakuje committed rLIBSSHe1a8b359c181: tests/pkd: Properly clean up memory (authored by Jakuje).
tests/pkd: Properly clean up memory
Nov 2 2018, 12:00 PM
Jakuje committed rLIBSSHd85bc347d327: misc: Properly check for errors returned from getpwuid_r() (authored by Jakuje).
misc: Properly check for errors returned from getpwuid_r()
Nov 2 2018, 12:00 PM
Jakuje committed rLIBSSHc8519c435ec1: session: Drop unused structure member (SSHv1) (authored by Jakuje).
session: Drop unused structure member (SSHv1)
Nov 2 2018, 12:00 PM
Jakuje committed rLIBSSH9c4baa7fd58b: misc: Reformat ssh_get_user_home_dir and ssh_file_readaccess_ok (authored by Jakuje).
misc: Reformat ssh_get_user_home_dir and ssh_file_readaccess_ok
Nov 2 2018, 12:00 PM

Oct 19 2018

Jakuje created T116: Memory leak from evp_init under OpenSSL.
Oct 19 2018, 4:49 PM · Unknown Object (Project)
Jakuje added a comment to T107: ssh_session_has_known_hosts_entry doesn't seem to check in opts.global_knownhosts.

The changes required to support also global known hosts landed in the following branch:

Oct 19 2018, 3:44 PM · Unknown Object (Project)

Oct 18 2018

Jakuje added a comment to T107: ssh_session_has_known_hosts_entry doesn't seem to check in opts.global_knownhosts.

This issue is mostly related to the parallel work on the config parsing by me and rewrite of the knownhosts api by Andreas. The global knownhosts file was a new thing at this time and therefore I am not very surprised this slipped through.

Oct 18 2018, 5:27 PM · Unknown Object (Project)
Jakuje added a comment to T105: HostKeyAlgorithms: Check if there is an entry in known_hosts and prefer that.

The following changes should settle the behavior to more sane that follows openssh and does not cause problems if there are more host keys stored in the known_hosts files:

Oct 18 2018, 4:33 PM · Unknown Object (Project)
Jakuje added a comment to T105: HostKeyAlgorithms: Check if there is an entry in known_hosts and prefer that.

This is actually implemented by the function ssh_known_hosts_get_algorithms(), but behaves a bit differently than a similar function in OpenSSH client:

Oct 18 2018, 11:57 AM · Unknown Object (Project)

Oct 9 2018

Jakuje added a comment to T98: [sftp] Add support for posix-rename@openssh.com.

This landed in 6c56c1e0d72670da274f3e77c51a7b4e078d59c6

Oct 9 2018, 2:51 PM · Unknown Object (Project)
Jakuje added a comment to T99: [sftp] Add support for hardlink@openssh.com.

This landed in 6c56c1e0d72670da274f3e77c51a7b4e078d59c6

Oct 9 2018, 2:49 PM · Unknown Object (Project)
Jakuje added a comment to T60: Server hostkey: allow ed25519 only.

If I am right, this should be fixed with c8429113faddce47db2f5cabd6f544564c2c3770

Oct 9 2018, 2:41 PM · Unknown Object (Project)

Oct 5 2018

Jakuje committed rLIBSSH1eeeace97505: cmake: Configure nss_wrapper and uid_wrapper (authored by asn).
cmake: Configure nss_wrapper and uid_wrapper
Oct 5 2018, 12:13 PM
Jakuje committed rLIBSSHbd7b509278a9: torture: Enable old host key algos for testing (authored by asn).
torture: Enable old host key algos for testing
Oct 5 2018, 12:13 PM
Jakuje committed rLIBSSH73ebcb3ab885: torture: Start sshd as root (authored by asn).
torture: Start sshd as root
Oct 5 2018, 12:13 PM
Jakuje committed rLIBSSH652acbeb2118: torture: Enable old cipher and kex algos in sshd (authored by asn).
torture: Enable old cipher and kex algos in sshd
Oct 5 2018, 12:12 PM
Jakuje committed rLIBSSH96e04d469126: torture: Create a torture_terminate_process() function (authored by asn).
torture: Create a torture_terminate_process() function
Oct 5 2018, 12:12 PM
Jakuje committed rLIBSSH2db325eb74db: torture: Restrict files to we write to our user. (authored by asn).
torture: Restrict files to we write to our user.
Oct 5 2018, 12:12 PM
Jakuje committed rLIBSSH7113074ae4cf: torture: Add torture_teardown_sshd_server(). (authored by asn).
torture: Add torture_teardown_sshd_server().
Oct 5 2018, 12:12 PM
Jakuje committed rLIBSSH9937d0b55212: torture: Add function to setup sshd server (authored by asn).
torture: Add function to setup sshd server
Oct 5 2018, 12:12 PM
Jakuje committed rLIBSSHae3e2a19c8eb: torture: Add torture_teardown_socket_dir(). (authored by asn).
torture: Add torture_teardown_socket_dir().
Oct 5 2018, 12:12 PM
Jakuje committed rLIBSSH4814c188ebf9: tests: Add ssh host keys for test environment. (authored by asn).
tests: Add ssh host keys for test environment.
Oct 5 2018, 12:12 PM
Jakuje committed rLIBSSHa317188cb7e7: cmake: Search for cwrap and sshd. (authored by asn).
cmake: Search for cwrap and sshd.
Oct 5 2018, 12:12 PM
Jakuje committed rLIBSSH3567524fb2ff: torture: Add torture_setup_socket_dir(). (authored by asn).
torture: Add torture_setup_socket_dir().
Oct 5 2018, 12:12 PM

Sep 17 2018

Jakuje added a comment to T97: libssh sftp client is using unreasonable amount of memory.

The above valgrind report was for direct comparison with the data from original report in description. In that case, we got to 50 % of memory usage since we started, which is a good progress and what was my point. The patches looked good to me as already discussed.

Sep 17 2018, 6:43 PM · Unknown Object (Project)

Sep 12 2018

Jakuje added a comment to T97: libssh sftp client is using unreasonable amount of memory.

I added my review to gitlab.

Sep 12 2018, 4:28 PM · Unknown Object (Project)

Aug 28 2018

Jakuje created T97: libssh sftp client is using unreasonable amount of memory.
Aug 28 2018, 5:14 PM · Unknown Object (Project)

Dec 24 2017

Jakuje added a comment to T80: torture_config_new test fails due to invalid session time out value caused by int pointer to long pointer cast.

Thank you for the bug report with verbose analysis of the problem. I see you are referencing that the fail was introduced by my commit, but it was just adding a test that uncovered this problem that existed for longer time (from 484564261?). Fortunately, this is not very common configuration option from my experience so there was probably not a lot harm caused so far.

Dec 24 2017, 12:16 AM