Page MenuHomePhabricator
Feed Advanced Search

Tue, Nov 5

ansasaki added a comment to T197: Putty cannot negotiate when the SSH Server adds an ED25519 key.

Could you try to apply the patch from this pull request and check if it fixes the issue for you?

Tue, Nov 5, 4:42 PM · Restricted Project

Mon, Nov 4

ansasaki added a comment to T197: Putty cannot negotiate when the SSH Server adds an ED25519 key.

The problem is that the used OpenSSL has the EVP_PKEY_ED25519 type in openssl/evp.h, but does not support the single shot EVP_DigestSign(). When I wrote the detection to switch to the OpenSSL implementation, I thought this combination would be impossible since ed25519 can only be used in single shot operations. The solution is to require both HAVE_OPENSSL_ED25519 and HAVE_OPENSSL_EVP_DIGESTSIGN to switch to OpenSSL implementation.

Mon, Nov 4, 1:08 PM · Restricted Project

Tue, Oct 29

ansasaki claimed T191: Server incorrectly assumes rsa-sha2-256 when client meant standard ssh-rsa.

Thanks for reporting this.

Tue, Oct 29, 11:28 AM · Restricted Project

Sep 30 2019

ansasaki committed rLIBSSH4f7cb6076a1d: pki_crypto: Support Ed25519 keys in PEM files (authored by ansasaki).
pki_crypto: Support Ed25519 keys in PEM files
Sep 30 2019, 5:21 PM
ansasaki committed rLIBSSH3f6820694eeb: cmake: Do not build internal ed25519 when unnecessary (authored by ansasaki).
cmake: Do not build internal ed25519 when unnecessary
Sep 30 2019, 5:21 PM
ansasaki committed rLIBSSH0da6597fe456: curve25519: Use OpenSSL X25519 implementation (authored by ansasaki).
curve25519: Use OpenSSL X25519 implementation
Sep 30 2019, 5:21 PM
ansasaki committed rLIBSSH0a13045f6893: cmake: Detect OpenSSL X25519 support (authored by ansasaki).
cmake: Detect OpenSSL X25519 support
Sep 30 2019, 5:21 PM
ansasaki committed rLIBSSHb56ffd84245c: pki: Remove unused function pki_signature_verify() (authored by ansasaki).
pki: Remove unused function pki_signature_verify()
Sep 30 2019, 5:21 PM
ansasaki committed rLIBSSHc60ac3fe027d: pki_crypto: Use OpenSSL for Ed25519 signatures (authored by ansasaki).
pki_crypto: Use OpenSSL for Ed25519 signatures
Sep 30 2019, 5:21 PM
ansasaki committed rLIBSSH84eab65edcf0: pki: Move common Ed25519 functions to pki_ed25519_common.c (authored by ansasaki).
pki: Move common Ed25519 functions to pki_ed25519_common.c
Sep 30 2019, 5:21 PM
ansasaki committed rLIBSSH7c3e37bf4c63: cmake: Detect OpenSSL support for Ed25519 (authored by ansasaki).
cmake: Detect OpenSSL support for Ed25519
Sep 30 2019, 5:21 PM
ansasaki committed rLIBSSHab9921ee6ac4: pki_mbedcrypto: Do not treat Ed25519 as a special case (authored by ansasaki).
pki_mbedcrypto: Do not treat Ed25519 as a special case
Sep 30 2019, 5:20 PM
ansasaki committed rLIBSSH9296bcd4bb0d: pki_gcrypt: Do not treat Ed25519 as a special case (authored by ansasaki).
pki_gcrypt: Do not treat Ed25519 as a special case
Sep 30 2019, 5:20 PM
ansasaki committed rLIBSSH24f39761f332: pki_crypto: Use EVP_DigestSign* and EVP_DigestVerify* (authored by ansasaki).
pki_crypto: Use EVP_DigestSign* and EVP_DigestVerify*
Sep 30 2019, 5:20 PM
ansasaki committed rLIBSSH49e8a4ef19a3: torture_pki_ed25519: Use public key to verify signatures (authored by ansasaki).
torture_pki_ed25519: Use public key to verify signatures
Sep 30 2019, 5:20 PM
ansasaki committed rLIBSSHd7e1141c1e32: gitlab-ci: Move cmake from prep to build command in csbuild (authored by ansasaki).
gitlab-ci: Move cmake from prep to build command in csbuild
Sep 30 2019, 5:20 PM
ansasaki committed rLIBSSHfd5c59847738: gitlab-ci: Turn DEBUG_CRYPTO on for standard crypto lib builds (authored by asn).
gitlab-ci: Turn DEBUG_CRYPTO on for standard crypto lib builds
Sep 30 2019, 5:20 PM
ansasaki committed rLIBSSHde4034bfe0e7: buffer: Simplify handling of the return codes (authored by Jakuje).
buffer: Simplify handling of the return codes
Sep 30 2019, 5:20 PM
ansasaki committed rLIBSSH6ccd84bae929: buffer: Avoid use of uninitialized values (authored by Jakuje).
buffer: Avoid use of uninitialized values
Sep 30 2019, 5:20 PM
ansasaki committed rLIBSSHe4c281c7ce38: dh-gex: Correctly free modulus and generator with openssl (authored by Jakuje).
dh-gex: Correctly free modulus and generator with openssl
Sep 30 2019, 5:20 PM
ansasaki committed rLIBSSH93541fe150e9: channels: Correctly reports failed channels opening (authored by Jakuje).
channels: Correctly reports failed channels opening
Sep 30 2019, 5:20 PM
ansasaki committed rLIBSSHe6ba98a0aa95: Reformat channel_open() (authored by Jakuje).
Reformat channel_open()
Sep 30 2019, 5:20 PM
ansasaki committed rLIBSSH6dcb96050170: channels: Do not use deprecated functions in the example code (authored by Jakuje).
channels: Do not use deprecated functions in the example code
Sep 30 2019, 5:20 PM
ansasaki committed rLIBSSHfcacc7fe8ce0: options: Do not attempt to expand percents in PKCS#11 URIs (authored by Jakuje).
options: Do not attempt to expand percents in PKCS#11 URIs
Sep 30 2019, 5:20 PM
ansasaki committed rLIBSSHf078f53911e9: tests: Verify the localuser match works (authored by Jakuje).
tests: Verify the localuser match works
Sep 30 2019, 5:20 PM
ansasaki committed rLIBSSH27f5bfd129f2: config: Support match localuser (authored by Jakuje).
config: Support match localuser
Sep 30 2019, 5:20 PM
ansasaki committed rLIBSSHd2af62624d49: known_hosts: Avoid using deprecated functions (even from deprecated functions) (authored by Jakuje).
known_hosts: Avoid using deprecated functions (even from deprecated functions)
Sep 30 2019, 5:19 PM
ansasaki committed rLIBSSH4a0cbe396d67: config: Make the matching case sensitive as documented in ssh_config manual… (authored by Jakuje).
config: Make the matching case sensitive as documented in ssh_config manual…
Sep 30 2019, 5:19 PM
ansasaki committed rLIBSSHa1812e9ac1e5: Skip the proxycommand test in case the netcat is not avaliable (authored by Jakuje).
Skip the proxycommand test in case the netcat is not avaliable
Sep 30 2019, 5:19 PM
ansasaki committed rLIBSSH0e3dbd6c69ac: sftp: Improve the documentation of sftp_init() and sftp_new() (authored by Jakuje).
sftp: Improve the documentation of sftp_init() and sftp_new()
Sep 30 2019, 5:19 PM

Sep 24 2019

ansasaki committed rLIBSSHa3a0529b41e5: pki_crypto: Support Ed25519 keys in PEM files (authored by ansasaki).
pki_crypto: Support Ed25519 keys in PEM files
Sep 24 2019, 4:57 PM
ansasaki committed rLIBSSH61e6b6cc59eb: cmake: Do not build internal ed25519 when unnecessary (authored by ansasaki).
cmake: Do not build internal ed25519 when unnecessary
Sep 24 2019, 4:57 PM
ansasaki committed rLIBSSHd463f67abaa1: curve25519: Use OpenSSL X25519 implementation (authored by ansasaki).
curve25519: Use OpenSSL X25519 implementation
Sep 24 2019, 4:57 PM
ansasaki committed rLIBSSH0b7f7d2cf7f2: cmake: Detect OpenSSL X25519 support (authored by ansasaki).
cmake: Detect OpenSSL X25519 support
Sep 24 2019, 4:57 PM
ansasaki committed rLIBSSH55cd04fbee7b: pki: Remove unused function pki_signature_verify() (authored by ansasaki).
pki: Remove unused function pki_signature_verify()
Sep 24 2019, 4:57 PM
ansasaki committed rLIBSSHbdcaf55b906b: pki: Move common Ed25519 functions to pki_ed25519_common.c (authored by ansasaki).
pki: Move common Ed25519 functions to pki_ed25519_common.c
Sep 24 2019, 4:57 PM
ansasaki committed rLIBSSH2a2c1c98bf41: pki_crypto: Use OpenSSL for Ed25519 signatures (authored by ansasaki).
pki_crypto: Use OpenSSL for Ed25519 signatures
Sep 24 2019, 4:56 PM
ansasaki committed rLIBSSH97adbfe0877e: pki_mbedcrypto: Do not treat Ed25519 as a special case (authored by ansasaki).
pki_mbedcrypto: Do not treat Ed25519 as a special case
Sep 24 2019, 4:56 PM
ansasaki committed rLIBSSHa0b84a8cd541: cmake: Detect OpenSSL support for Ed25519 (authored by ansasaki).
cmake: Detect OpenSSL support for Ed25519
Sep 24 2019, 4:56 PM
ansasaki committed rLIBSSH90944a36513b: pki_crypto: Use EVP_DigestSign* and EVP_DigestVerify* (authored by ansasaki).
pki_crypto: Use EVP_DigestSign* and EVP_DigestVerify*
Sep 24 2019, 4:56 PM
ansasaki committed rLIBSSH38ede2e22576: pki_gcrypt: Do not treat Ed25519 as a special case (authored by ansasaki).
pki_gcrypt: Do not treat Ed25519 as a special case
Sep 24 2019, 4:56 PM
ansasaki committed rLIBSSH7ffa3c358d72: gitlab-ci: Move cmake from prep to build command in csbuild (authored by ansasaki).
gitlab-ci: Move cmake from prep to build command in csbuild
Sep 24 2019, 4:56 PM
ansasaki committed rLIBSSH7452f0ded897: torture_pki_ed25519: Use public key to verify signatures (authored by ansasaki).
torture_pki_ed25519: Use public key to verify signatures
Sep 24 2019, 4:56 PM

Aug 22 2019

ansasaki created T171: Allow specifiying algorithms in configuration file by adding or removing algorithms from default.
Aug 22 2019, 3:58 PM
ansasaki closed T76: Support keys with line comments as Resolved.

Fixed in master by:
88d777e67823
d627cba47610

Aug 22 2019, 3:47 PM · Restricted Project
ansasaki closed T166: known_hosts: directories are not created recursively as Resolved.

This was fixed in master by 5b18bcb0ac39c3c366dd769e893af381ddb5deb2

Aug 22 2019, 3:42 PM

Aug 6 2019

ansasaki claimed T158: Use curve25519-sha256 from crypto libs if available.
Aug 6 2019, 10:45 AM · Restricted Project

Jul 29 2019

ansasaki triaged T166: known_hosts: directories are not created recursively as Normal priority.
Jul 29 2019, 2:03 PM

Jul 12 2019

ansasaki closed T156: The HostKeyAlgorithms configuration option should not override the order of the key types gathered from the know hosts file as Resolved.

The fix for this landed in master as f18a7cc17e399ae7bc92f707da3a676c52fd948e

Jul 12 2019, 1:11 PM · Restricted Project

Jul 4 2019

ansasaki committed rLIBSSH1fd68ec73221: kex: Do not ignore keys in known_hosts files (authored by ansasaki).
kex: Do not ignore keys in known_hosts files
Jul 4 2019, 3:43 PM
ansasaki committed rLIBSSHfa3caa61fdb3: knownhosts: Introduced ssh_known_hosts_get_algorithms_names() (authored by ansasaki).
knownhosts: Introduced ssh_known_hosts_get_algorithms_names()
Jul 4 2019, 3:43 PM
ansasaki committed rLIBSSHaaa978ad06eb: token: Added function to remove duplicates (authored by ansasaki).
token: Added function to remove duplicates
Jul 4 2019, 3:42 PM
ansasaki committed rLIBSSHb9530cedbeb1: knownhosts: Read knownhosts file only if found (authored by ansasaki).
knownhosts: Read knownhosts file only if found
Jul 4 2019, 3:42 PM
ansasaki committed rLIBSSH7ff0af75436e: tests: Check if known_hosts works with single unaccessible file (authored by ansasaki).
tests: Check if known_hosts works with single unaccessible file
Jul 4 2019, 3:42 PM
ansasaki committed rLIBSSHb040856ccfde: knownhosts: Fix possible memory leak (authored by ansasaki).
knownhosts: Fix possible memory leak
Jul 4 2019, 3:42 PM
ansasaki committed rLIBSSHf18a7cc17e39: kex: Do not ignore keys in known_hosts files (authored by ansasaki).
kex: Do not ignore keys in known_hosts files
Jul 4 2019, 11:10 AM
ansasaki committed rLIBSSH65a38759ca87: knownhosts: Introduced ssh_known_hosts_get_algorithms_names() (authored by ansasaki).
knownhosts: Introduced ssh_known_hosts_get_algorithms_names()
Jul 4 2019, 11:09 AM
ansasaki committed rLIBSSH548753b33895: token: Added function to remove duplicates (authored by ansasaki).
token: Added function to remove duplicates
Jul 4 2019, 11:09 AM
ansasaki committed rLIBSSHfe248414fec1: knownhosts: Fix possible memory leak (authored by ansasaki).
knownhosts: Fix possible memory leak
Jul 4 2019, 11:09 AM
ansasaki committed rLIBSSHe5a64a3d6b1b: knownhosts: Read knownhosts file only if found (authored by ansasaki).
knownhosts: Read knownhosts file only if found
Jul 4 2019, 11:09 AM
ansasaki committed rLIBSSHad68de7271e6: tests: Check if known_hosts works with single unaccessible file (authored by ansasaki).
tests: Check if known_hosts works with single unaccessible file
Jul 4 2019, 11:09 AM

Jul 3 2019

ansasaki closed T154: Add ssh_threads_get_default() to the callbacks.h as Resolved.

Closing this as the proposed patch was merged to master.

Jul 3 2019, 3:27 PM · Restricted Project

Jun 26 2019

ansasaki committed rLIBSSHd00ff451db2c: gitlab-ci: Re-enable client tests in CentOS7 (authored by ansasaki).
gitlab-ci: Re-enable client tests in CentOS7
Jun 26 2019, 5:40 PM
ansasaki committed rLIBSSHc8f49becfde6: tests/pkd: Fix elif without expression (authored by ansasaki).
tests/pkd: Fix elif without expression
Jun 26 2019, 5:40 PM
ansasaki committed rLIBSSH4b7ce75e1fe4: pki: Add workarounds for old OpenSSH (authored by ansasaki).
pki: Add workarounds for old OpenSSH
Jun 26 2019, 5:40 PM
ansasaki committed rLIBSSHabf571216062: tests: Introduce torture_client_global_requests (authored by ansasaki).
tests: Introduce torture_client_global_requests
Jun 26 2019, 5:40 PM
ansasaki committed rLIBSSHf64814b7be53: tests: Add a server test case for unknown global request (authored by ansasaki).
tests: Add a server test case for unknown global request
Jun 26 2019, 5:40 PM
ansasaki committed rLIBSSH1aef599ab10a: messages: Reject tcpip-forward requests as client (authored by ansasaki).
messages: Reject tcpip-forward requests as client
Jun 26 2019, 5:40 PM
ansasaki committed rLIBSSH3d7d3f303ed5: messages: Consume unknown global requests messages (authored by ansasaki).
messages: Consume unknown global requests messages
Jun 26 2019, 5:40 PM
ansasaki added a comment to T127: socket: non blocking connection do not try IPv4 address after failing to connect to IPv6 address.

The easiest way to reproduce this is to put something like this in /etc/hosts:

2001:db8::1 testing
192.168.0.1 testing

and then try to ./examples/ssh-client -vvvv testing. The client only tries the first address and gives up without trying the next.

Jun 26 2019, 4:51 PM · Restricted Project

Jun 14 2019

ansasaki added a comment to T154: Add ssh_threads_get_default() to the callbacks.h.

I just adjusted the documentation comment a bit, and removed the invalid warning from ssh_threads_get_pthread()

Jun 14 2019, 10:36 AM · Restricted Project

May 20 2019

ansasaki added a comment to T134: crash in nonblock-write mode of ssh_handle_key_exchange() when receiving tcp rst after 3WHS (keepalive).

Thank you for reporting this!

May 20 2019, 5:16 PM · Restricted Project
ansasaki added a comment to T145: Add ssh_threads_get_winlock() to the callbacks.h.

Thank you for your contribution!

May 20 2019, 4:50 PM · Restricted Project

May 10 2019

ansasaki created T148: PubkeyAcceptedKeyTypes is not supported in config file.
May 10 2019, 7:17 PM

Apr 29 2019

ansasaki added a comment to T141: gssapi: detect malloc failure.

Thank you for reporting this and sending you patch proposal.

Apr 29 2019, 10:24 AM · Restricted Project
ansasaki added a comment to T142: torture_proxycommand failing.

Actually the client testing is enabled in most of the builds in the CI (you can check the CI configuration in .gitlab-ci.yml file).

Apr 29 2019, 10:24 AM · Restricted Project

Dec 6 2018

ansasaki created T127: socket: non blocking connection do not try IPv4 address after failing to connect to IPv6 address.
Dec 6 2018, 4:46 PM · Restricted Project

Nov 28 2018

ansasaki committed rLIBSSHa2baf6e97bc8: tests: Include config.h in torture_pki.c (authored by ansasaki).
tests: Include config.h in torture_pki.c
Nov 28 2018, 4:41 PM
ansasaki committed rLIBSSHf9ff53b49456: tests: Include unistd.h only if available (authored by ansasaki).
tests: Include unistd.h only if available
Nov 28 2018, 4:41 PM

Nov 27 2018

ansasaki added a comment to T120: ssh_finalize() issue in 0.8.5.

Thanks for reporting this. I had some trouble to reproduce this issue since it only happens in Windows environment.

Nov 27 2018, 6:32 PM · Restricted Project

Aug 27 2018

ansasaki committed rLIBSSHf49bb1b6a3a4: cmake: Fix FindABIMap targets (authored by ansasaki).
cmake: Fix FindABIMap targets
Aug 27 2018, 4:47 PM

Aug 6 2018

ansasaki committed rLIBSSHd85827f646aa: auth: Some code style fixes (authored by ansasaki).
auth: Some code style fixes
Aug 6 2018, 10:59 AM
ansasaki committed rLIBSSH6e74c6c1dce2: auth: Improve pending call error messages (authored by ansasaki).
auth: Improve pending call error messages
Aug 6 2018, 10:59 AM

Aug 1 2018

ansasaki added a comment to T56: Bad authentication state after failed GSSAPI authentication.

Moved this to https://gitlab.com/ansasaki/libssh-mirror/merge_requests/5

Aug 1 2018, 6:35 PM · Restricted Project

Jul 17 2018

ansasaki added a comment to T56: Bad authentication state after failed GSSAPI authentication.

Proposed fix: https://github.com/ansasaki/libssh/pull/5

Jul 17 2018, 1:15 PM · Restricted Project

Jul 13 2018

ansasaki added a comment to T56: Bad authentication state after failed GSSAPI authentication.

Is there a reproducer for this?

Jul 13 2018, 4:17 PM · Restricted Project