Page MenuHomePhabricator
Feed Advanced Search

Thu, Dec 13

asn committed rLIBSSH0bd404bcbd7c: gitlab-ci: Add minimal build (authored by asn).
gitlab-ci: Add minimal build
Thu, Dec 13, 9:35 PM
asn committed rLIBSSHfded1fb9eb67: channels: Don't call ssh_channel_close() twice (authored by asn).
channels: Don't call ssh_channel_close() twice
Thu, Dec 13, 9:35 PM
asn committed rLIBSSH6cd8d4a24aa0: channels: Don't call ssh_channel_close() twice (authored by asn).
channels: Don't call ssh_channel_close() twice
Thu, Dec 13, 9:35 PM
asn added a comment to T47: sftp_write waits infinitely when connection to target server is lost.

I'm sorry, but returning an error if poll() times out is simply wrong.

Thu, Dec 13, 8:56 AM · Restricted Project
asn added a comment to T125: libssh 0.8.5 under Windows 10.

Hi Gilles,

Thu, Dec 13, 8:47 AM · Restricted Project

Mon, Dec 10

asn committed rLIBSSHc9bdb9a01ed4: tests: Do not segfault when built without ZLIB (authored by Jakuje).
tests: Do not segfault when built without ZLIB
Mon, Dec 10, 8:28 PM
asn committed rLIBSSH973da84a470f: tests: Verify we can parse the ProxyJump configuration option (authored by Jakuje).
tests: Verify we can parse the ProxyJump configuration option
Mon, Dec 10, 7:36 PM
asn committed rLIBSSH990794c58045: config: Parse ProxyJump configuration option and implement it using… (authored by Jakuje).
config: Parse ProxyJump configuration option and implement it using…
Mon, Dec 10, 7:36 PM
asn committed rLIBSSH9b1852f7281e: tests: Verify ProxyCommand works with ssh (authored by Jakuje).
tests: Verify ProxyCommand works with ssh
Mon, Dec 10, 7:36 PM
asn committed rLIBSSH055bf830dbda: tests: Use torture_server_address() in proxycommand test (authored by Jakuje).
tests: Use torture_server_address() in proxycommand test
Mon, Dec 10, 7:36 PM
asn committed rLIBSSH8c812dbfa388: tests: Verify all the options are copied over (authored by Jakuje).
tests: Verify all the options are copied over
Mon, Dec 10, 7:36 PM
asn committed rLIBSSH9128ecf397f0: options: Copy also the new options (authored by Jakuje).
options: Copy also the new options
Mon, Dec 10, 7:36 PM
asn committed rLIBSSH48aede2a312b: options: Check for null (authored by Jakuje).
options: Check for null
Mon, Dec 10, 7:36 PM
asn committed rLIBSSHa6e055c42b34: packet: Allow SSH2_MSG_EXT_INFO when authenticated (authored by ansasaki).
packet: Allow SSH2_MSG_EXT_INFO when authenticated
Mon, Dec 10, 5:53 PM
asn committed rLIBSSH32221ea9fbfc: channels: Send close if we received a remote close (authored by asn).
channels: Send close if we received a remote close
Mon, Dec 10, 5:53 PM
asn committed rLIBSSH917ba0747845: channels: Reformat ssh_channel_free() (authored by asn).
channels: Reformat ssh_channel_free()
Mon, Dec 10, 5:53 PM
asn committed rLIBSSHbcdbc11732c4: channel: Add SSH_CHANNEL_FLAG_CLOSED_LOCAL (authored by asn).
channel: Add SSH_CHANNEL_FLAG_CLOSED_LOCAL
Mon, Dec 10, 5:53 PM
asn committed rLIBSSH79289dc5069b: channel: Reformat ssh_channel_close() (authored by asn).
channel: Reformat ssh_channel_close()
Mon, Dec 10, 5:52 PM
asn committed rLIBSSHfe309ba43fb9: packet: Allow SSH2_MSG_EXT_INFO when authenticated (authored by ansasaki).
packet: Allow SSH2_MSG_EXT_INFO when authenticated
Mon, Dec 10, 5:48 PM
asn committed rLIBSSHc3067f8e7324: channels: Send close if we received a remote close (authored by asn).
channels: Send close if we received a remote close
Mon, Dec 10, 5:48 PM
asn committed rLIBSSH1d5b222cc4f1: channels: Reformat ssh_channel_free() (authored by asn).
channels: Reformat ssh_channel_free()
Mon, Dec 10, 5:48 PM
asn committed rLIBSSH13b9d268d42b: channel: Add SSH_CHANNEL_FLAG_CLOSED_LOCAL (authored by asn).
channel: Add SSH_CHANNEL_FLAG_CLOSED_LOCAL
Mon, Dec 10, 5:47 PM
asn committed rLIBSSH0ba10870d149: channel: Reformat ssh_channel_close() (authored by asn).
channel: Reformat ssh_channel_close()
Mon, Dec 10, 5:47 PM
asn added a comment to T47: sftp_write waits infinitely when connection to target server is lost.

I've pushed some changes to the master-poll branch. This should correctly return errors.

Mon, Dec 10, 10:17 AM · Restricted Project

Fri, Dec 7

asn committed rLIBSSHe4e51ccc1340: session: Check the session timeout and use it if set (authored by asn).
session: Check the session timeout and use it if set
Fri, Dec 7, 6:11 PM
asn committed rLIBSSH8daf03c5640d: session: Check the session timeout and use it if set (authored by asn).
session: Check the session timeout and use it if set
Fri, Dec 7, 6:11 PM
asn added a commit to T33: SSH_OPTIONS_TIMEOUT not used in non-blocking sockets: rLIBSSHe4e51ccc1340: session: Check the session timeout and use it if set.
Fri, Dec 7, 6:11 PM · Restricted Project
asn closed T33: SSH_OPTIONS_TIMEOUT not used in non-blocking sockets as Resolved by committing rLIBSSH8daf03c5640d: session: Check the session timeout and use it if set.
Fri, Dec 7, 6:10 PM · Restricted Project
asn committed rLIBSSHf05717d23e31: sftp: Add NULL check in sftp_fstat() (authored by ansasaki).
sftp: Add NULL check in sftp_fstat()
Fri, Dec 7, 6:10 PM
asn committed rLIBSSH8ece2abfab35: session: Use long for the timeout (authored by asn).
session: Use long for the timeout
Fri, Dec 7, 6:10 PM
asn committed rLIBSSHeaa97d20620d: sftp: Add NULL check in sftp_xstat() (authored by ansasaki).
sftp: Add NULL check in sftp_xstat()
Fri, Dec 7, 6:10 PM
asn committed rLIBSSHbda2cc69af0e: sftp: Add NULL check in sftp_opendir() (authored by ansasaki).
sftp: Add NULL check in sftp_opendir()
Fri, Dec 7, 6:10 PM
asn committed rLIBSSH83d827d7dd0e: sftp: Set sftp error when received unexpected message (authored by ansasaki).
sftp: Set sftp error when received unexpected message
Fri, Dec 7, 6:10 PM
asn committed rLIBSSH0f952959664b: sftp: Set sftp error code when fail occurs (authored by ansasaki).
sftp: Set sftp error code when fail occurs
Fri, Dec 7, 6:10 PM
asn committed rLIBSSH8e69d435efb4: channels: Set error state when closed channel is read (authored by ansasaki).
channels: Set error state when closed channel is read
Fri, Dec 7, 6:10 PM
asn committed rLIBSSHd78a29eb792f: sftp: Set error when EOF is received in sftp_packet_read() (authored by ansasaki).
sftp: Set error when EOF is received in sftp_packet_read()
Fri, Dec 7, 6:10 PM
asn committed rLIBSSHcf6f1e7a6463: tests: Cover also compression with unit tests (authored by Jakuje).
tests: Cover also compression with unit tests
Fri, Dec 7, 3:40 PM
asn committed rLIBSSH58113d489eec: connect: Fix size type for i an j in ssh_select() (authored by asn).
connect: Fix size type for i an j in ssh_select()
Fri, Dec 7, 3:36 PM
asn committed rLIBSSH21e252236018: config: Get rid of the dynamic seen array (authored by Jakuje).
config: Get rid of the dynamic seen array
Fri, Dec 7, 3:36 PM
asn committed rLIBSSHc306a693f3fb: buffer: Use size_t for argc argument in ssh_buffer_(un)pack() (authored by asn).
buffer: Use size_t for argc argument in ssh_buffer_(un)pack()
Fri, Dec 7, 3:36 PM
asn committed rLIBSSH8f887e82c75a: config: Reformat local_parse_file (authored by Jakuje).
config: Reformat local_parse_file
Fri, Dec 7, 3:36 PM
asn committed rLIBSSH993e24a361b6: config: Reformat ssh_config_parse_file (authored by Jakuje).
config: Reformat ssh_config_parse_file
Fri, Dec 7, 3:36 PM
asn committed rLIBSSHcf6f1e7a6463: tests: Cover also compression with unit tests (authored by Jakuje).
tests: Cover also compression with unit tests
Fri, Dec 7, 3:36 PM
asn committed rLIBSSH42ce98948811: tests: Cover missing parts of the config parsing (authored by Jakuje).
tests: Cover missing parts of the config parsing
Fri, Dec 7, 3:36 PM
asn committed rLIBSSH31bc83f36676: tests: Do not recreate unnecessary files for every test case (authored by Jakuje).
tests: Do not recreate unnecessary files for every test case
Fri, Dec 7, 3:36 PM

Wed, Dec 5

asn added a comment to T47: sftp_write waits infinitely when connection to target server is lost.

Well FD_ISSET() checks after select() if the fd is part of the set or not. If not we do not need to inspect it further. If we always call recv() then it doesn't make sense to call select() or poll() at all.

Wed, Dec 5, 3:03 PM · Restricted Project

Fri, Nov 30

asn committed rLIBSSH45172a70fac2: sftp: Do not overwrite errors set by channel functions (authored by asn).
sftp: Do not overwrite errors set by channel functions
Fri, Nov 30, 7:01 PM
asn committed rLIBSSH7b0c80b475d7: tests: Test calling ssh_init() after ssh_finalize() (authored by ansasaki).
tests: Test calling ssh_init() after ssh_finalize()
Fri, Nov 30, 7:01 PM
asn committed rLIBSSHd5bc9a1aceb4: libcrypto: Fix access violation in ssh_init() (authored by ansasaki).
libcrypto: Fix access violation in ssh_init()
Fri, Nov 30, 7:01 PM
asn added a commit to T120: ssh_finalize() issue in 0.8.5: rLIBSSHd5bc9a1aceb4: libcrypto: Fix access violation in ssh_init().
Fri, Nov 30, 7:01 PM · Restricted Project
asn committed rLIBSSH80d3e10b47b6: tests: Verify that signatures are sane and can not be verified by non-matching… (authored by Jakuje).
tests: Verify that signatures are sane and can not be verified by non-matching…
Fri, Nov 30, 7:01 PM
asn committed rLIBSSH455d495c7441: pki: Sanitize input to verification (authored by Jakuje).
pki: Sanitize input to verification
Fri, Nov 30, 7:00 PM
asn committed rLIBSSHb1bae1d90f61: pki: Return default RSA key type for DIGEST_AUTO (authored by Jakuje).
pki: Return default RSA key type for DIGEST_AUTO
Fri, Nov 30, 7:00 PM
asn committed rLIBSSHad4f1dbea04c: pki: Verify the provided public key has expected type (authored by Jakuje).
pki: Verify the provided public key has expected type
Fri, Nov 30, 7:00 PM
asn committed rLIBSSH5ffe695c3cc6: pki: Sanity-check signature matches base key type (authored by Jakuje).
pki: Sanity-check signature matches base key type
Fri, Nov 30, 7:00 PM
asn committed rLIBSSH230a43728802: tests: Do not require base RSA type for SHA2 extension whitelist (authored by Jakuje).
tests: Do not require base RSA type for SHA2 extension whitelist
Fri, Nov 30, 7:00 PM
asn committed rLIBSSH1df272c3cca0: packet_cb: Properly verify the signature type (authored by Jakuje).
packet_cb: Properly verify the signature type
Fri, Nov 30, 7:00 PM
asn committed rLIBSSHc3a57fe2dcfe: pki: Separate signature extraction and verification (authored by Jakuje).
pki: Separate signature extraction and verification
Fri, Nov 30, 7:00 PM
asn committed rLIBSSHa238df2436a0: pki: Set correct type for imported signatures (authored by Jakuje).
pki: Set correct type for imported signatures
Fri, Nov 30, 7:00 PM
asn committed rLIBSSHf5e8fa5c5fb3: pki: Use self-explanatory variable names (authored by Jakuje).
pki: Use self-explanatory variable names
Fri, Nov 30, 7:00 PM
asn committed rLIBSSH0a07266d9c0c: The largest ECDSA key has 521 bits (authored by Jakuje).
The largest ECDSA key has 521 bits
Fri, Nov 30, 7:00 PM
asn committed rLIBSSH953eae880f55: pki_gcrypt: Do not abort on bad signature (authored by Jakuje).
pki_gcrypt: Do not abort on bad signature
Fri, Nov 30, 6:59 PM
asn committed rLIBSSH4282f3c664b6: gitlab-ci: Fix csbuild to run latest 20 commits (authored by asn).
gitlab-ci: Fix csbuild to run latest 20 commits
Fri, Nov 30, 6:55 PM
asn committed rLIBSSHcf24048f0251: libcrypto: Fix integer comparison in evp_cipher_aead_encrypt() (authored by asn).
libcrypto: Fix integer comparison in evp_cipher_aead_encrypt()
Fri, Nov 30, 6:55 PM
asn committed rLIBSSH3784226fd85b: sftp: Do not overwrite errors set by channel functions (authored by asn).
sftp: Do not overwrite errors set by channel functions
Fri, Nov 30, 6:55 PM
asn committed rLIBSSHf427a975b8a4: tests: Fix a clang possible memory leak warning (authored by ansasaki).
tests: Fix a clang possible memory leak warning
Fri, Nov 30, 6:55 PM
asn committed rLIBSSHc41383476470: tests: Test calling ssh_init() after ssh_finalize() (authored by ansasaki).
tests: Test calling ssh_init() after ssh_finalize()
Fri, Nov 30, 6:55 PM
asn committed rLIBSSH41b0d263d6e5: libcrypto: Fix access violation in ssh_init() (authored by ansasaki).
libcrypto: Fix access violation in ssh_init()
Fri, Nov 30, 6:55 PM
asn closed T120: ssh_finalize() issue in 0.8.5 as Resolved by committing rLIBSSH41b0d263d6e5: libcrypto: Fix access violation in ssh_init().
Fri, Nov 30, 6:55 PM · Restricted Project
asn committed rLIBSSHa08a97f9c780: tests: Use UNUSED macros in torture_threads_init (authored by asn).
tests: Use UNUSED macros in torture_threads_init
Fri, Nov 30, 6:26 PM
asn committed rLIBSSHc0ae59e10220: bignum: Use UNUSED macros (authored by asn).
bignum: Use UNUSED macros
Fri, Nov 30, 6:26 PM
asn committed rLIBSSH109a203453e7: include: Add macro for unused arguments and variables (authored by asn).
include: Add macro for unused arguments and variables
Fri, Nov 30, 6:26 PM
asn committed rLIBSSHc6ca62d7e166: crypto: Use size_t for len argument in encrypt and decrpyt fn (authored by asn).
crypto: Use size_t for len argument in encrypt and decrpyt fn
Fri, Nov 30, 6:25 PM
asn committed rLIBSSHac8b9540198c: bignum: Use size_t in ssh_make_string_bn* (authored by asn).
bignum: Use size_t in ssh_make_string_bn*
Fri, Nov 30, 6:25 PM
asn committed rLIBSSH6d3672911bcd: gitlab-ci: Added builds for native Windows (authored by ansasaki).
gitlab-ci: Added builds for native Windows
Fri, Nov 30, 6:25 PM
asn committed rLIBSSH95f83c2391fa: src: Fix multiple typos (authored by Tilo Eckert <tilo.eckert@flam.de>).
src: Fix multiple typos
Fri, Nov 30, 4:34 PM
asn committed rLIBSSH130256c3487d: tests: Verify that signatures are sane and can not be verified by non-matching… (authored by Jakuje).
tests: Verify that signatures are sane and can not be verified by non-matching…
Fri, Nov 30, 4:34 PM
asn committed rLIBSSHb72c9eead6c4: pki: Sanitize input to verification (authored by Jakuje).
pki: Sanitize input to verification
Fri, Nov 30, 4:34 PM
asn committed rLIBSSHc7628fbfea9b: pki: Return default RSA key type for DIGEST_AUTO (authored by Jakuje).
pki: Return default RSA key type for DIGEST_AUTO
Fri, Nov 30, 4:34 PM
asn committed rLIBSSH783e5fd206df: pki: Verify the provided public key has expected type (authored by Jakuje).
pki: Verify the provided public key has expected type
Fri, Nov 30, 4:34 PM
asn committed rLIBSSHc79c33e22431: pki: Sanity-check signature matches base key type (authored by Jakuje).
pki: Sanity-check signature matches base key type
Fri, Nov 30, 4:34 PM
asn committed rLIBSSH968fdf4e188b: tests: Do not require base RSA type for SHA2 extension whitelist (authored by Jakuje).
tests: Do not require base RSA type for SHA2 extension whitelist
Fri, Nov 30, 4:34 PM
asn committed rLIBSSHbc91fa98eaaf: packet_cb: Properly verify the signature type (authored by Jakuje).
packet_cb: Properly verify the signature type
Fri, Nov 30, 4:34 PM
asn committed rLIBSSHd2434c69c008: pki: Separate signature extraction and verification (authored by Jakuje).
pki: Separate signature extraction and verification
Fri, Nov 30, 4:34 PM
asn committed rLIBSSH7f83a1efae6a: pki: Set correct type for imported signatures (authored by Jakuje).
pki: Set correct type for imported signatures
Fri, Nov 30, 4:34 PM
asn committed rLIBSSH46d8840f7ea8: The largest ECDSA key has 521 bits (authored by Jakuje).
The largest ECDSA key has 521 bits
Fri, Nov 30, 4:34 PM
asn committed rLIBSSHc1fdb56d23c4: pki_gcrypt: Do not abort on bad signature (authored by Jakuje).
pki_gcrypt: Do not abort on bad signature
Fri, Nov 30, 4:34 PM
asn committed rLIBSSH57bdc9cb2021: Whitespace cleanup (authored by Jakuje).
Whitespace cleanup
Fri, Nov 30, 4:34 PM
asn committed rLIBSSH7b725e6bc7ab: pki: Use self-explanatory variable names (authored by Jakuje).
pki: Use self-explanatory variable names
Fri, Nov 30, 4:34 PM
asn added a comment to T47: sftp_write waits infinitely when connection to target server is lost.

Do you know what the reason is why FD_ISSET() is called, maybe add WSAGetLastError() in that case. Does ssh_poll() return 0 in that case?

Fri, Nov 30, 8:33 AM · Restricted Project

Thu, Nov 29

asn added a comment to T47: sftp_write waits infinitely when connection to target server is lost.

I've pushed an update, however you need to check what WSAGetLastError() is reporting after the recv()!

Thu, Nov 29, 8:35 AM · Restricted Project

Wed, Nov 28

asn committed rLIBSSH312084731e8e: tests: Use temporary directories in torture_pki_ed25519.c (authored by ansasaki).
tests: Use temporary directories in torture_pki_ed25519.c
Wed, Nov 28, 4:42 PM
asn committed rLIBSSH500bf54a343a: tests: Use temporary directories in torture_pki_ecdsa.c (authored by ansasaki).
tests: Use temporary directories in torture_pki_ecdsa.c
Wed, Nov 28, 4:42 PM
asn committed rLIBSSHa56fa14fda19: tests: Use temporary directories in torture_pki_dsa.c (authored by ansasaki).
tests: Use temporary directories in torture_pki_dsa.c
Wed, Nov 28, 4:42 PM
asn committed rLIBSSHac1377148fc1: tests: Use temporary directories in torture_threads_pki_rsa.c (authored by ansasaki).
tests: Use temporary directories in torture_threads_pki_rsa.c
Wed, Nov 28, 4:42 PM
asn committed rLIBSSHf38c6fcc6ee3: tests: Use temporary directories in torture_pki_rsa.c (authored by ansasaki).
tests: Use temporary directories in torture_pki_rsa.c
Wed, Nov 28, 4:42 PM
asn committed rLIBSSH0dd2b375c770: tests: Introduce functions to change directories (authored by ansasaki).
tests: Introduce functions to change directories
Wed, Nov 28, 4:42 PM
asn committed rLIBSSH77be4ce9056e: tests: use torture_create_temp_file() in torture_knownhosts_parsing (authored by ansasaki).
tests: use torture_create_temp_file() in torture_knownhosts_parsing
Wed, Nov 28, 4:42 PM
asn committed rLIBSSH78b1f0ead38f: tests: Introduce torture_create_temp_file() (authored by ansasaki).
tests: Introduce torture_create_temp_file()
Wed, Nov 28, 4:42 PM
asn committed rLIBSSH65e16b8d9e50: tests: Introduce torture_make_temp_dir() (authored by ansasaki).
tests: Introduce torture_make_temp_dir()
Wed, Nov 28, 4:42 PM