Page MenuHomePhabricator
Feed All Stories

Today

asn committed rLIBSSHfe0331cf40c6: socket: Remove redundant code (authored by Tilo Eckert <tilo.eckert@flam.de>).
socket: Remove redundant code
Tue, Nov 20, 8:47 AM
asn committed rLIBSSH709c48eab635: socket: Fix potential buffer overrun (authored by Tilo Eckert <tilo.eckert@flam.de>).
socket: Fix potential buffer overrun
Tue, Nov 20, 8:47 AM
asn committed rLIBSSH3d56bdae372c: pki: Fix typos in documentation (authored by Tilo Eckert <tilo.eckert@flam.de>).
pki: Fix typos in documentation
Tue, Nov 20, 8:47 AM
asn committed rLIBSSH8b4de1c4771d: packet: Fix timeout on hostkey type mismatch instead of proper error (authored by Tilo Eckert <tilo.eckert@flam.de>).
packet: Fix timeout on hostkey type mismatch instead of proper error
Tue, Nov 20, 8:47 AM
asn committed rLIBSSHf369d0293268: socket: Remove redundant code (authored by Tilo Eckert <tilo.eckert@flam.de>).
socket: Remove redundant code
Tue, Nov 20, 8:47 AM
asn committed rLIBSSH0b9e07fbdc78: socket: Fix potential buffer overrun (authored by Tilo Eckert <tilo.eckert@flam.de>).
socket: Fix potential buffer overrun
Tue, Nov 20, 8:46 AM
asn committed rLIBSSHc47cdc0f9728: pki: Fix typos in documentation (authored by Tilo Eckert <tilo.eckert@flam.de>).
pki: Fix typos in documentation
Tue, Nov 20, 8:46 AM
asn committed rLIBSSH4b6eb05023f4: packet: Fix timeout on hostkey type mismatch instead of proper error (authored by Tilo Eckert <tilo.eckert@flam.de>).
packet: Fix timeout on hostkey type mismatch instead of proper error
Tue, Nov 20, 8:46 AM
asn added a comment to T47: sftp_write waits infinitely when connection to target server is lost.

Hi Sarah,

Tue, Nov 20, 8:13 AM · Restricted Project
asn committed rLIBSSH59ada799d765: packets: Fix ssh_send_keepalive() (authored by Nicolas Viennot <nicolas@viennot.biz>).
packets: Fix ssh_send_keepalive()
Tue, Nov 20, 8:05 AM
asn committed rLIBSSHbb5d46c19037: COPYING: Reformat the last paragraph (authored by asn).
COPYING: Reformat the last paragraph
Tue, Nov 20, 8:05 AM
asn committed rLIBSSH906f63ba9732: packets: Fix ssh_send_keepalive() (authored by Nicolas Viennot <nicolas@viennot.biz>).
packets: Fix ssh_send_keepalive()
Tue, Nov 20, 8:05 AM
asn committed rLIBSSH26ea4f059a56: COPYING: Reformat the last paragraph (authored by asn).
COPYING: Reformat the last paragraph
Tue, Nov 20, 8:05 AM

Yesterday

cortana63 added a comment to T33: SSH_OPTIONS_TIMEOUT not used in non-blocking sockets.

See https://bugs.libssh.org/T47 for two patches that address part of this problem.

Mon, Nov 19, 8:57 PM · Restricted Project
cortana63 added a comment to T47: sftp_write waits infinitely when connection to target server is lost.

This is still occurring as of release 0.8.4. This issue is related: https://bugs.libssh.org/T33

Mon, Nov 19, 8:56 PM · Restricted Project
Jakuje added a comment to T122: Running the sftp_read test for the second time fails.

After more hours of digging in the code, I isolated this to the two SFTP calls that cause this issue to be reproducible reliably. These are calls to ssh_channel_send_eof() and ssh_channel_free() from sftp_free() called from the cleanup of the first sftp. If I remove these two calls, the testsuite passes reproducibly.

Mon, Nov 19, 3:50 PM · Restricted Project
ehmry triaged T123: Unable to import key files with leading whitespace as Normal priority.
Mon, Nov 19, 11:01 AM · Restricted Project

Fri, Nov 16

Jakuje created T122: Running the sftp_read test for the second time fails.
Fri, Nov 16, 4:37 PM · Restricted Project

Thu, Nov 15

asn committed rLIBSSHaa56b8ca5306: tests: Fix chroot_wrapper location (authored by asn).
tests: Fix chroot_wrapper location
Thu, Nov 15, 4:46 PM
asn committed rLIBSSH3de34944ad11: tests: Ensure the ssh session fd is read-/writeable in torture_proxycommand (authored by Gundersanne).
tests: Ensure the ssh session fd is read-/writeable in torture_proxycommand
Thu, Nov 15, 4:46 PM
asn committed rLIBSSH3b46198c42b3: tests: Fix chroot_wrapper location (authored by asn).
tests: Fix chroot_wrapper location
Thu, Nov 15, 4:46 PM

Tue, Nov 13

cortana63 added a comment to T33: SSH_OPTIONS_TIMEOUT not used in non-blocking sockets.

I am seeing this issue with sftp_read(). The sftp_read() function call was getting hung when there was a disconnect. I traced it to ssh_channel_read() which isn't using the user defined timeout.

Tue, Nov 13, 4:46 PM · Restricted Project
asn added a comment to T33: SSH_OPTIONS_TIMEOUT not used in non-blocking sockets.

ssh_channel_read_timeout()

Tue, Nov 13, 4:38 PM · Restricted Project
Jakuje created T121: The server should not send the SSH_MSG_EXT_INFO message after rekeying.
Tue, Nov 13, 3:39 PM · Restricted Project
cortana63 added a comment to T33: SSH_OPTIONS_TIMEOUT not used in non-blocking sockets.

I have tested with 0.8.4. It looks like SSH_TIMEOUT_DEFAULT is always -1 even if I set SSH_OPTIONS_TIMEOUT.

Tue, Nov 13, 2:18 PM · Restricted Project
asn added a comment to T33: SSH_OPTIONS_TIMEOUT not used in non-blocking sockets.

This should be fixed with c2fc9ac956b4452066543f8d22758bb710b752b7 and ef06ef2c1bf9cab97ecf451d40c1311b2f0d4b02

Tue, Nov 13, 12:48 PM · Restricted Project
asn added a comment to T33: SSH_OPTIONS_TIMEOUT not used in non-blocking sockets.

Did you test this with libssh >= 0.8.3. Because I fixed some things.

Tue, Nov 13, 12:47 PM · Restricted Project

Fri, Nov 9

cortana63 added a comment to T33: SSH_OPTIONS_TIMEOUT not used in non-blocking sockets.

This is related to this issue discussed here: https://www.libssh.org/archive/libssh/2016-02/0000010.html

Fri, Nov 9, 10:35 PM · Restricted Project

Thu, Nov 8

asn committed rLIBSSH67f418218bd3: knownhosts: Take StrictHostKeyChecking option into account (authored by Gundersanne).
knownhosts: Take StrictHostKeyChecking option into account
Thu, Nov 8, 8:13 PM
asn committed rLIBSSH69cb3c583539: knownhosts: Take StrictHostKeyChecking option into account (authored by Gundersanne).
knownhosts: Take StrictHostKeyChecking option into account
Thu, Nov 8, 8:13 PM
asn committed rLIBSSH03c30e9c8ad3: tests: Ensure the ssh session fd is read-/writeable in torture_proxycommand (authored by Gundersanne).
tests: Ensure the ssh session fd is read-/writeable in torture_proxycommand
Thu, Nov 8, 8:13 PM
asn added a comment to T108: setting knownhost option to NULL crashes, at least before connecting.

Yes, I think that would be the correct fix.

Thu, Nov 8, 5:35 PM · Restricted Project
asn committed rLIBSSH5102b16cf131: crypto: Fix compilation for OpenSSL without deprecated APIs (authored by Rosen Penev <rosenp@gmail.com>).
crypto: Fix compilation for OpenSSL without deprecated APIs
Thu, Nov 8, 9:37 AM
asn committed rLIBSSH61cac32288fb: crypto: Fix compilation for OpenSSL without deprecated APIs (authored by Rosen Penev <rosenp@gmail.com>).
crypto: Fix compilation for OpenSSL without deprecated APIs
Thu, Nov 8, 9:37 AM

Tue, Nov 6

Gundersanne added a comment to T108: setting knownhost option to NULL crashes, at least before connecting.

options.c:610 in current master:

Tue, Nov 6, 3:35 PM · Restricted Project
Jakuje added a comment to T108: setting knownhost option to NULL crashes, at least before connecting.

No, this issue is still present it I am right.

Tue, Nov 6, 2:29 PM · Restricted Project
Jakuje added a comment to T109: ProxyCommand for jump host configuration broken.

Probably not. I assume this is not only about configuration parser (which was fixed in several aspects recently), but instead about the way how the proxycommand is implemented in libssh (I am actually not sure how does it work there). The important are errors with ProxyCommand, but for further investigation, some debugging log will be needed:

Tue, Nov 6, 2:23 PM · Restricted Project
asn assigned T108: setting knownhost option to NULL crashes, at least before connecting to Jakuje.

Jabuk, is that working with the new config parsting stuff?

Tue, Nov 6, 2:16 PM · Restricted Project
asn closed T84: sftp connect don't read ~/.ssh/config correctly as Resolved.

Fixed in libssh 0.8.1 or newer.

Tue, Nov 6, 2:15 PM · Restricted Project
asn added a project to T109: ProxyCommand for jump host configuration broken: Restricted Project.
Tue, Nov 6, 2:13 PM · Restricted Project
asn assigned T109: ProxyCommand for jump host configuration broken to Jakuje.

Jakub, didn't we already fix this?

Tue, Nov 6, 2:13 PM · Restricted Project
asn closed T118: ssh_get_user_home_dir does not check for no match as Resolved.
Tue, Nov 6, 2:09 PM
asn committed rLIBSSHdc071dc6cf1b: cmake: Refresh the CMake Config files (authored by Christophe Giboudeaux <christophe@krop.fr>).
cmake: Refresh the CMake Config files
Tue, Nov 6, 2:04 PM
asn committed rLIBSSHaa899f8ec06e: cmake: Refresh the CMake Config files (authored by Christophe Giboudeaux <christophe@krop.fr>).
cmake: Refresh the CMake Config files
Tue, Nov 6, 2:04 PM

Mon, Nov 5

asn committed rLIBSSHc88fb4c55b54: tests: Use correct assert function in torture_client_config (authored by asn).
tests: Use correct assert function in torture_client_config
Mon, Nov 5, 12:19 PM
asn committed rLIBSSH86dabfe7e424: cmake: Only check for bounded attribute on OpenBSD (authored by asn).
cmake: Only check for bounded attribute on OpenBSD
Mon, Nov 5, 12:19 PM
asn committed rLIBSSHa8ed5e31dc15: tests: Check for NULL in torture_client_config (authored by asn).
tests: Check for NULL in torture_client_config
Mon, Nov 5, 12:19 PM

Fri, Nov 2

asn committed rLIBSSH1650d8178e48: config: Avoid potential file descriptor leak (authored by Jakuje).
config: Avoid potential file descriptor leak
Fri, Nov 2, 1:26 PM
asn committed rLIBSSHa8d4fbaccb93: tests: Improve error reporting in auth test (authored by Jakuje).
tests: Improve error reporting in auth test
Fri, Nov 2, 12:18 PM
asn committed rLIBSSH56b7d2da4d51: tests: Typo -- the flags should be checked according to the comment (authored by Jakuje).
tests: Typo -- the flags should be checked according to the comment
Fri, Nov 2, 12:18 PM
asn committed rLIBSSHa4b99eedf2f0: knownhosts: Make sure we have both knownhosts files ready (authored by Jakuje).
knownhosts: Make sure we have both knownhosts files ready
Fri, Nov 2, 12:17 PM
asn committed rLIBSSH8a8498b586bf: client: Reformat comment (authored by Jakuje).
client: Reformat comment
Fri, Nov 2, 12:17 PM
asn committed rLIBSSH44b32e940e51: tests/pkd: Properly clean up memory (authored by Jakuje).
tests/pkd: Properly clean up memory
Fri, Nov 2, 12:17 PM
asn committed rLIBSSH059079581add: session: Drop unused structure member (SSHv1) (authored by Jakuje).
session: Drop unused structure member (SSHv1)
Fri, Nov 2, 12:16 PM
asn committed rLIBSSHf11be32e1182: misc: Properly check for errors returned from getpwuid_r() (authored by Jakuje).
misc: Properly check for errors returned from getpwuid_r()
Fri, Nov 2, 12:16 PM
asn committed rLIBSSHa9be4ab73e65: misc: Reformat ssh_get_user_home_dir and ssh_file_readaccess_ok (authored by Jakuje).
misc: Reformat ssh_get_user_home_dir and ssh_file_readaccess_ok
Fri, Nov 2, 12:16 PM
asn committed rLIBSSH6eb43fcbf375: tests: Verify the configuration reparsing with real client (authored by Jakuje).
tests: Verify the configuration reparsing with real client
Fri, Nov 2, 12:01 PM
asn committed rLIBSSH9aa47fef9950: tests: Adjust test that require complete config re-parsing (authored by Jakuje).
tests: Adjust test that require complete config re-parsing
Fri, Nov 2, 12:01 PM
asn committed rLIBSSHde7405f1c710: config: Preserve the seen array among invocations (authored by Jakuje).
config: Preserve the seen array among invocations
Fri, Nov 2, 12:00 PM
asn committed rLIBSSH4a95a35bc689: tests: Properly set the bob's UID also in other tests than pubkey (authored by Jakuje).
tests: Properly set the bob's UID also in other tests than pubkey
Fri, Nov 2, 12:00 PM
asn committed rLIBSSHf6b390084e77: tests: Make sure that no other configuration options will get pulled to the… (authored by Jakuje).
tests: Make sure that no other configuration options will get pulled to the…
Fri, Nov 2, 12:00 PM
asn committed rLIBSSHb7fefb05007c: options: Provide a way of disabling automatic config parsing (authored by Jakuje).
options: Provide a way of disabling automatic config parsing
Fri, Nov 2, 12:00 PM
asn committed rLIBSSH89a8a6fcf073: Process OpenSSH configuration files by default. (authored by Jakuje).
Process OpenSSH configuration files by default.
Fri, Nov 2, 12:00 PM
Jakuje committed rLIBSSH7e44ce155639: tests: Improve error reporting in auth test (authored by Jakuje).
tests: Improve error reporting in auth test
Fri, Nov 2, 12:00 PM
Jakuje committed rLIBSSH5fc4d5b22af3: tests: Typo -- the flags should be checked according to the comment (authored by Jakuje).
tests: Typo -- the flags should be checked according to the comment
Fri, Nov 2, 12:00 PM
Jakuje committed rLIBSSH5159cd96e8b6: knownhosts: Make sure we have both knownhosts files ready (authored by Jakuje).
knownhosts: Make sure we have both knownhosts files ready
Fri, Nov 2, 12:00 PM
Jakuje committed rLIBSSH35c417312c0b: client: Reformat comment (authored by Jakuje).
client: Reformat comment
Fri, Nov 2, 12:00 PM
Jakuje committed rLIBSSHe1a8b359c181: tests/pkd: Properly clean up memory (authored by Jakuje).
tests/pkd: Properly clean up memory
Fri, Nov 2, 12:00 PM
Jakuje committed rLIBSSHd85bc347d327: misc: Properly check for errors returned from getpwuid_r() (authored by Jakuje).
misc: Properly check for errors returned from getpwuid_r()
Fri, Nov 2, 12:00 PM
Jakuje committed rLIBSSHc8519c435ec1: session: Drop unused structure member (SSHv1) (authored by Jakuje).
session: Drop unused structure member (SSHv1)
Fri, Nov 2, 12:00 PM
Jakuje committed rLIBSSH9c4baa7fd58b: misc: Reformat ssh_get_user_home_dir and ssh_file_readaccess_ok (authored by Jakuje).
misc: Reformat ssh_get_user_home_dir and ssh_file_readaccess_ok
Fri, Nov 2, 12:00 PM

Thu, Nov 1

Eddie added a watcher for Kpn: Eddie.
Thu, Nov 1, 8:58 AM
Eddie changed the visibility for Kpn.
Thu, Nov 1, 8:58 AM
chcg updated the task description for T120: ssh_finalize() issue in 0.8.5.
Thu, Nov 1, 1:04 AM · Restricted Project
chcg added a comment to T120: ssh_finalize() issue in 0.8.5.

Used openssl version 1.0.2p.

Thu, Nov 1, 12:59 AM · Restricted Project
chcg created T120: ssh_finalize() issue in 0.8.5.
Thu, Nov 1, 12:55 AM · Restricted Project

Wed, Oct 31

chcg added a comment to T119: 0.7.7 win32 x86 build issue.

Seems 0.7 branch has no .gitlab-ci.yml and there is no build configured at https://gitlab.com/libssh/libssh-mirror/pipelines

Wed, Oct 31, 7:15 PM · Restricted Project
chcg added a comment to T119: 0.7.7 win32 x86 build issue.

Further info:

  • also mingw32 builds fail due to missing size_t define, see:
Wed, Oct 31, 6:28 PM · Restricted Project

Tue, Oct 30

asn closed T114: Interactive authentication is failing as Resolved.

This should be fixed with the release of libssh 0.8.5.

Tue, Oct 30, 3:44 PM
asn committed rLIBSSHe5352e302148: include: Add stddef.h for size_t (authored by asn).
include: Add stddef.h for size_t
Tue, Oct 30, 9:22 AM
asn closed T119: 0.7.7 win32 x86 build issue as Resolved by committing rLIBSSHe5352e302148: include: Add stddef.h for size_t.
Tue, Oct 30, 9:22 AM · Restricted Project

Mon, Oct 29

chcg added a comment to T119: 0.7.7 win32 x86 build issue.

As 0.8.x has a

Mon, Oct 29, 11:34 PM · Restricted Project
chcg created T119: 0.7.7 win32 x86 build issue.
Mon, Oct 29, 11:31 PM · Restricted Project
asn added a comment to T112: 0.7.6 strndup issue with visual studio.

Yes, please. Open a new bug do we need to explicitly include stddef.h in priv.h?

Mon, Oct 29, 9:13 PM · Restricted Project
chcg added a comment to T112: 0.7.6 strndup issue with visual studio.

See https://ci.appveyor.com/project/chcg/nppftp/builds/19888936. x64 builds are fine, but x86 not. Definition for size_t is missing. Seems some include is missing. Compiler issue:

Mon, Oct 29, 8:08 PM · Restricted Project
chcg added a comment to T113: 0.8.4 ssize_t comiler errors with visual studio .

Thanks, see https://ci.appveyor.com/project/ashkulz/nppftp/builds/19889010 is working now.
Unfortunately I'm not able to build the libssh project from git to verify fixes immediately.
I will further work on that.

Mon, Oct 29, 8:04 PM · Restricted Project
asn closed T117: 0.8.4 ssh server regression with interactive keyboard auth: message callback only called once as Resolved.

Fixed with libssh 0.8.5 and libssh 0.7.7.

Mon, Oct 29, 2:22 PM · Restricted Project
chipaca created T118: ssh_get_user_home_dir does not check for no match.
Mon, Oct 29, 11:28 AM
asn committed rLIBSSH64a2d37c3040: Bump version to 0.7.7 (authored by asn).
Bump version to 0.7.7
Mon, Oct 29, 11:16 AM
asn committed rLIBSSH273fb4cfc62e: Bump version to 0.8.5 (authored by asn).
Bump version to 0.8.5
Mon, Oct 29, 11:15 AM
asn committed rLIBSSHa4342b97d604: Bump SO version to 4.7.2 (authored by asn).
Bump SO version to 4.7.2
Mon, Oct 29, 11:15 AM
asn committed rLIBSSH56f7c2785248: Bump SO version to 4.7.2 (authored by asn).
Bump SO version to 4.7.2
Mon, Oct 29, 11:15 AM

Sun, Oct 28

asn committed rLIBSSHa2807474621e: libcrypto: Fix memory leak in evp_final() (authored by asn).
libcrypto: Fix memory leak in evp_final()
Sun, Oct 28, 2:35 PM
asn committed rLIBSSH963c3077a401: doc: fix up various typos and trailing whitespace (authored by Mike Frysinger <vapier@gentoo.org>).
doc: fix up various typos and trailing whitespace
Sun, Oct 28, 2:35 PM
asn committed rLIBSSH1285b37b6050: doc: fix up various typos and trailing whitespace (authored by Mike Frysinger <vapier@gentoo.org>).
doc: fix up various typos and trailing whitespace
Sun, Oct 28, 2:35 PM
asn added a commit to T116: Memory leak from evp_init under OpenSSL: rLIBSSHa2807474621e: libcrypto: Fix memory leak in evp_final().
Sun, Oct 28, 2:35 PM · Restricted Project
asn committed rLIBSSHb7de358cdc40: libcrypto: Fix memory leak in evp_final() (authored by asn).
libcrypto: Fix memory leak in evp_final()
Sun, Oct 28, 2:35 PM
asn committed rLIBSSH9d5cf209df4c: libcrypto: Fix memory leak in evp_final() (authored by asn).
libcrypto: Fix memory leak in evp_final()
Sun, Oct 28, 2:35 PM
asn closed T116: Memory leak from evp_init under OpenSSL as Resolved by committing rLIBSSH9d5cf209df4c: libcrypto: Fix memory leak in evp_final().
Sun, Oct 28, 2:34 PM · Restricted Project
asn added a commit to T116: Memory leak from evp_init under OpenSSL: rLIBSSHb7de358cdc40: libcrypto: Fix memory leak in evp_final().
Sun, Oct 28, 2:34 PM · Restricted Project