Page MenuHomePhabricator
Feed All Stories

Wed, Mar 20

chcg added a comment to T133: OpenSSL 1.1.1b compile errors.

See https://travis-ci.org/ashkulz/NppFTP/jobs/504958471, also for NppFTP with 0.8.7 this issue could be observed for mingw64 4.8.4 build with setting -DWITH_STATIC_LIB=ON for https://github.com/ashkulz/NppFTP/pull/246. The same constellation build with MSVC seems to have no such issue, see https://ci.appveyor.com/project/ashkulz/nppftp/builds/22995813

Wed, Mar 20, 7:13 PM · Restricted Project

Thu, Mar 14

adelton created T139: Calling sftp_new() on session that was not authenticated hangs.
Thu, Mar 14, 2:42 PM
adelton created T138: sftp_free() segfaults when called after ssh_disconnect().
Thu, Mar 14, 2:35 PM
adelton added a comment to T137: Difference between sftp_new() and sftp_init() is not clear.

The behaviour was observed on Fedora 29 with libssh-0.8.7-1.fc29.x86_64.

Thu, Mar 14, 2:17 PM
adelton created T137: Difference between sftp_new() and sftp_init() is not clear.
Thu, Mar 14, 2:16 PM

Wed, Mar 13

davidwed added a comment to T133: OpenSSL 1.1.1b compile errors.

All is fine, I just hadn't considered that I linked the Openssl statically :-).

Wed, Mar 13, 4:29 PM · Restricted Project
asn added a comment to T133: OpenSSL 1.1.1b compile errors.

Please open a new bug if there is an issue with libssh and openssl linking on Windows and provide details there. Thanks!

Wed, Mar 13, 10:49 AM · Restricted Project
asn committed rLIBSSHe981113ee1c2: doc: Add a note about OpenSSL linking (authored by asn).
doc: Add a note about OpenSSL linking
Wed, Mar 13, 10:37 AM
asn committed rLIBSSH144e5516149a: doc: Add a note about OpenSSL linking (authored by asn).
doc: Add a note about OpenSSL linking
Wed, Mar 13, 10:36 AM
asn committed rLIBSSH3736a0367bf3: libcrypto: Add missing includes for modes.h (authored by asn).
libcrypto: Add missing includes for modes.h
Wed, Mar 13, 10:33 AM
asn added a commit to T133: OpenSSL 1.1.1b compile errors: rLIBSSH3736a0367bf3: libcrypto: Add missing includes for modes.h.
Wed, Mar 13, 10:33 AM · Restricted Project
asn committed rLIBSSH65bc24d8a420: libcrypto: Add missing includes for modes.h (authored by asn).
libcrypto: Add missing includes for modes.h
Wed, Mar 13, 10:33 AM
asn closed T133: OpenSSL 1.1.1b compile errors as Resolved by committing rLIBSSH65bc24d8a420: libcrypto: Add missing includes for modes.h.
Wed, Mar 13, 10:33 AM · Restricted Project
asn added a comment to T133: OpenSSL 1.1.1b compile errors.

You seem to statically link openssl, that's why you need to link crypt32.dll. This means it isn't our problem. See

Wed, Mar 13, 10:31 AM · Restricted Project
asn added a comment to T133: OpenSSL 1.1.1b compile errors.

Is that only happening with static linking?

Wed, Mar 13, 10:27 AM · Restricted Project
asn added a comment to T133: OpenSSL 1.1.1b compile errors.

Why do you need to link against crypt32, can you post the error?

Wed, Mar 13, 10:24 AM · Restricted Project
davidwed added a comment to T133: OpenSSL 1.1.1b compile errors.

Your fix for the "libcrypto.c" worked, thanks :-).

Wed, Mar 13, 10:08 AM · Restricted Project
asn added a comment to T133: OpenSSL 1.1.1b compile errors.

??

Wed, Mar 13, 9:44 AM · Restricted Project

Tue, Mar 12

davidwed added a comment to T133: OpenSSL 1.1.1b compile errors.
Tue, Mar 12, 4:55 PM · Restricted Project
davidwed added a comment to T133: OpenSSL 1.1.1b compile errors.
Tue, Mar 12, 4:06 PM · Restricted Project
asn added a comment to T133: OpenSSL 1.1.1b compile errors.

https://git.libssh.org/users/asn/libssh.git/commit/?h=master-fix&id=a11e172577e6c1d7fc19503fb2854777b373131b

Tue, Mar 12, 1:15 PM · Restricted Project
asn added a comment to T133: OpenSSL 1.1.1b compile errors.

Do we need to add:

Tue, Mar 12, 1:10 PM · Restricted Project
davidwed added a comment to T133: OpenSSL 1.1.1b compile errors.

I compile the OpenSSL and the libSSH on a Windows 8.1 system with the mingw64 ( MSYS2 ).

Tue, Mar 12, 12:18 PM · Restricted Project
adelton created T136: A more elaborate way to get the remote data.
Tue, Mar 12, 10:42 AM
adelton created T135: When ~/.ssh/known_hosts is removed, I still get SSH_KNOWN_HOSTS_UNKNOWN, not SSH_KNOWN_HOSTS_NOT_FOUND.
Tue, Mar 12, 9:23 AM

Mon, Mar 11

asn committed rLIBSSHd8fc65ad7125: The SSH_LOG_ENTRY is not defined all, match the descriptions to… (authored by adelton).
The SSH_LOG_ENTRY is not defined all, match the descriptions to…
Mon, Mar 11, 4:29 PM
asn committed rLIBSSHbed7dcb3ec2c: ssh_userauth_publickey_auto requires three arguments. (authored by adelton).
ssh_userauth_publickey_auto requires three arguments.
Mon, Mar 11, 4:29 PM
asn committed rLIBSSH81d0f6b6b7ae: From the context it seems that the function being defined is authenticate_none. (authored by adelton).
From the context it seems that the function being defined is authenticate_none.
Mon, Mar 11, 4:29 PM
Jakuje added a comment to T133: OpenSSL 1.1.1b compile errors.

I just tested with Fedora 29 with the latest OpenSSL 1.1.1b (openssl-1.1.1b-2.fc29.x86_64) and I am able to build the libssh without any problem. Can you clarify on what OS are you trying to compile and you see these errors?

Mon, Mar 11, 10:22 AM · Restricted Project

Thu, Mar 7

asn committed rLIBSSHc235841436ae: Add unit test for fn that generates session keys (authored by Simo Sorce <simo@redhat.com>).
Add unit test for fn that generates session keys
Thu, Mar 7, 4:12 PM
asn committed rLIBSSH449954d99afc: Fix crypto_free zeroing of encryption keys (authored by Simo Sorce <simo@redhat.com>).
Fix crypto_free zeroing of encryption keys
Thu, Mar 7, 4:12 PM
asn committed rLIBSSHc180211c6b80: Clean up code that generates session keys (authored by Simo Sorce <simo@redhat.com>).
Clean up code that generates session keys
Thu, Mar 7, 4:12 PM
asn committed rLIBSSH104c9dca3f96: Use a common KDF function (authored by Simo Sorce <simo@redhat.com>).
Use a common KDF function
Thu, Mar 7, 4:12 PM
lzfmars updated the task description for T134: crash in nonblock-write mode of ssh_handle_key_exchange() when receiving tcp rst after 3WHS (keepalive).
Thu, Mar 7, 4:11 PM · Restricted Project
lzfmars created T134: crash in nonblock-write mode of ssh_handle_key_exchange() when receiving tcp rst after 3WHS (keepalive).
Thu, Mar 7, 4:11 PM · Restricted Project
lzfmars added a project to T134: crash in nonblock-write mode of ssh_handle_key_exchange() when receiving tcp rst after 3WHS (keepalive): Restricted Project.
Thu, Mar 7, 4:11 PM · Restricted Project

Fri, Mar 1

asn closed T128: net-libs/libssh compile issue with libressl-2.6.5 as Resolved.
Fri, Mar 1, 8:22 AM · Restricted Project

Thu, Feb 28

toralf added a comment to T128: net-libs/libssh compile issue with libressl-2.6.5.

FWIW seems that libssh-0.8.6 compiles fine here with LibreSSL-2.8.3

Thu, Feb 28, 7:51 PM · Restricted Project
Jakuje added a comment to T133: OpenSSL 1.1.1b compile errors.

Building with openssl-1.1.1a-1.fc29.x86_64 works fine so the support window is not a problem.

Thu, Feb 28, 11:57 AM · Restricted Project
asn assigned T133: OpenSSL 1.1.1b compile errors to Jakuje.

Jakub, could you check once OpenSSL 1.1.1b is in rawhide?

Thu, Feb 28, 9:22 AM · Restricted Project

Wed, Feb 27

davidwed created T133: OpenSSL 1.1.1b compile errors.
Wed, Feb 27, 11:26 PM · Restricted Project
asn added a comment to T125: libssh 0.8.5 under Windows 10.

Some time ago, we use WSAPoll() on Windows but it had a lot of issues that's why we stopped using it. I guess the best would be to move to a library which provides different event loops like libverto.

Wed, Feb 27, 8:39 AM · Restricted Project
asn added a project to T127: socket: non blocking connection do not try IPv4 address after failing to connect to IPv6 address: Restricted Project.
Wed, Feb 27, 8:36 AM · Restricted Project
asn assigned T127: socket: non blocking connection do not try IPv4 address after failing to connect to IPv6 address to ansasaki.
Wed, Feb 27, 8:36 AM · Restricted Project
asn triaged T128: net-libs/libssh compile issue with libressl-2.6.5 as Wishlist priority.
Wed, Feb 27, 8:35 AM · Restricted Project
asn committed rLIBSSHbe73335f8e1b: sftp: Document how to free memory retruned by sftp_canonicalize_path() (authored by asn).
sftp: Document how to free memory retruned by sftp_canonicalize_path()
Wed, Feb 27, 8:35 AM
asn added a commit to T129: What to do with sftp_canonicalize_path's returned pointer?: rLIBSSHbe73335f8e1b: sftp: Document how to free memory retruned by sftp_canonicalize_path().
Wed, Feb 27, 8:35 AM
asn committed rLIBSSH7c444c09d7bd: sftp: Document how to free memory retruned by sftp_canonicalize_path() (authored by asn).
sftp: Document how to free memory retruned by sftp_canonicalize_path()
Wed, Feb 27, 8:34 AM
asn closed T129: What to do with sftp_canonicalize_path's returned pointer? as Resolved by committing rLIBSSH7c444c09d7bd: sftp: Document how to free memory retruned by sftp_canonicalize_path().
Wed, Feb 27, 8:34 AM
asn added a comment to T129: What to do with sftp_canonicalize_path's returned pointer?.

Thank you very much for the bug report.

Wed, Feb 27, 8:34 AM
asn committed rLIBSSH8234df5decfd: ssh_event_dopoll can also return SSH_AGAIN (authored by Till Wimmer <g4-lisz@tonarchiv.ch>).
ssh_event_dopoll can also return SSH_AGAIN
Wed, Feb 27, 8:20 AM

Mon, Feb 25

asn committed rLIBSSH52986115b8b7: Bump version to 0.8.7 (authored by asn).
Bump version to 0.8.7
Mon, Feb 25, 10:29 AM
asn committed rLIBSSH7a49ee5ffc71: cmake: Bump API version to 4.7.4 (authored by asn).
cmake: Bump API version to 4.7.4
Mon, Feb 25, 10:29 AM
asn committed rLIBSSHc842bc2e8bea: Remove SHA384 HMAC (authored by Dirkjan Bussink <d.bussink@gmail.com>).
Remove SHA384 HMAC
Mon, Feb 25, 10:29 AM
asn committed rLIBSSH8892577296db: Use constant time comparison function for HMAC comparison (authored by Dirkjan Bussink <d.bussink@gmail.com>).
Use constant time comparison function for HMAC comparison
Mon, Feb 25, 10:29 AM
asn committed rLIBSSHac7c64a76915: pki_gcrypt: Include missing stdbool.h (authored by asn).
pki_gcrypt: Include missing stdbool.h
Mon, Feb 25, 10:29 AM
asn committed rLIBSSH47014eb2732c: pki: Fix size type for len in privatekey_string_to_buffer() (authored by asn).
pki: Fix size type for len in privatekey_string_to_buffer()
Mon, Feb 25, 10:29 AM
asn committed rLIBSSH22231061131b: connect: Fix size type for i an j in ssh_select() (authored by asn).
connect: Fix size type for i an j in ssh_select()
Mon, Feb 25, 10:29 AM
asn committed rLIBSSH4af77362b018: connector: Fallback on the socket output callback (authored by davidwed).
connector: Fallback on the socket output callback
Mon, Feb 25, 10:29 AM
asn added a commit to T132: pki_gcrypt: strict-overflow error with gcc 4.8: rLIBSSH47014eb2732c: pki: Fix size type for len in privatekey_string_to_buffer().
Mon, Feb 25, 10:29 AM
asn added a commit to T124: Connector interface does not work correctly in SSH server environment: rLIBSSH4af77362b018: connector: Fallback on the socket output callback.
Mon, Feb 25, 10:28 AM · Restricted Project
asn committed rLIBSSHf4a0fcc85eb1: connector: Don't NULL connector (in|out) channels on event remove (authored by Till Wimmer <g4-lisz@tonarchiv.ch>).
connector: Don't NULL connector (in|out) channels on event remove
Mon, Feb 25, 10:28 AM
asn committed rLIBSSH810dbd3db11f: config: Avoid buffer overflow (authored by Jakuje).
config: Avoid buffer overflow
Mon, Feb 25, 10:28 AM
asn committed rLIBSSHfa150ef8d298: options: Removed outdated param annotations of ssh_options_set() (authored by Till Wimmer <g4-lisz@tonarchiv.ch>).
options: Removed outdated param annotations of ssh_options_set()
Mon, Feb 25, 10:28 AM

Fri, Feb 22

asn committed rLIBSSH4a67c1911886: Add tests and implementation for Encrypt-then-MAC mode (authored by Dirkjan Bussink <d.bussink@gmail.com>).
Add tests and implementation for Encrypt-then-MAC mode
Fri, Feb 22, 6:21 PM
asn committed rLIBSSHe4c7912b3531: Add flag for tracking EtM HMACs (authored by Dirkjan Bussink <d.bussink@gmail.com>).
Add flag for tracking EtM HMACs
Fri, Feb 22, 6:21 PM
asn committed rLIBSSHc6608c921118: Refactor ssh_packet_hmac_verify to allow for direct buffer (authored by Dirkjan Bussink <d.bussink@gmail.com>).
Refactor ssh_packet_hmac_verify to allow for direct buffer
Fri, Feb 22, 6:21 PM
asn committed rLIBSSHf055319efe68: Select ciphers for MAC tests that need a MAC (authored by Dirkjan Bussink <d.bussink@gmail.com>).
Select ciphers for MAC tests that need a MAC
Fri, Feb 22, 6:21 PM
asn committed rLIBSSH46d15b316103: Use constant time comparison function for HMAC comparison (authored by Dirkjan Bussink <d.bussink@gmail.com>).
Use constant time comparison function for HMAC comparison
Fri, Feb 22, 6:21 PM
asn committed rLIBSSH369051a5b4fb: Remove SHA384 HMAC (authored by Dirkjan Bussink <d.bussink@gmail.com>).
Remove SHA384 HMAC
Fri, Feb 22, 6:21 PM
asn committed rLIBSSH1af10fcdb300: config: Avoid buffer overflow (authored by Jakuje).
config: Avoid buffer overflow
Fri, Feb 22, 11:41 AM
asn committed rLIBSSH8a73e481845c: pki_gcrypt: Include missing stdbool.h (authored by asn).
pki_gcrypt: Include missing stdbool.h
Fri, Feb 22, 11:01 AM
asn committed rLIBSSH7a8ed6d02b48: pki: Fix size type for len in privatekey_string_to_buffer() (authored by asn).
pki: Fix size type for len in privatekey_string_to_buffer()
Fri, Feb 22, 10:47 AM
asn committed rLIBSSHb73ffb3f91ea: connector: Fallback on the socket output callback (authored by davidwed).
connector: Fallback on the socket output callback
Fri, Feb 22, 10:47 AM
asn closed T132: pki_gcrypt: strict-overflow error with gcc 4.8 as Resolved by committing rLIBSSH7a8ed6d02b48: pki: Fix size type for len in privatekey_string_to_buffer().
Fri, Feb 22, 10:47 AM
asn closed T124: Connector interface does not work correctly in SSH server environment as Resolved by committing rLIBSSHb73ffb3f91ea: connector: Fallback on the socket output callback.
Fri, Feb 22, 10:47 AM · Restricted Project

Feb 21 2019

asn committed rLIBSSH702a6e769556: client: Add missing break, remove useless return (authored by Tilo Eckert <tilo.eckert@flam.de>).
client: Add missing break, remove useless return
Feb 21 2019, 2:08 PM
asn committed rLIBSSHeb032e0dec75: socket: Use more portable PF_UNIX instead of PF_LOCAL (authored by Tilo Eckert <tilo.eckert@flam.de>).
socket: Use more portable PF_UNIX instead of PF_LOCAL
Feb 21 2019, 2:08 PM
asn committed rLIBSSH881e1b47855f: examples: Add direct-tcpip server sample (authored by Till Wimmer <g4-lisz@tonarchiv.ch>).
examples: Add direct-tcpip server sample
Feb 21 2019, 2:08 PM
asn committed rLIBSSH17df34da9621: crypto: Use uint8_t instead of non-standard u_char (authored by Tilo Eckert <tilo.eckert@flam.de>).
crypto: Use uint8_t instead of non-standard u_char
Feb 21 2019, 2:08 PM
asn committed rLIBSSH7caf6d2ab62d: buffer: Fix regression introduced by 6c7eaa and c306a6 (authored by Tilo Eckert <tilo.eckert@flam.de>).
buffer: Fix regression introduced by 6c7eaa and c306a6
Feb 21 2019, 2:08 PM
asn committed rLIBSSH5a590dfb5f0c: examples: Fix unused parameter warnings in sshd_direct-tcpip (authored by asn).
examples: Fix unused parameter warnings in sshd_direct-tcpip
Feb 21 2019, 2:08 PM
ffontaine added a comment to T132: pki_gcrypt: strict-overflow error with gcc 4.8.

Previous patch was wrong so here is a new patch to add an option to disable Werror

Feb 21 2019, 2:07 PM
ffontaine added a comment to T132: pki_gcrypt: strict-overflow error with gcc 4.8.
Feb 21 2019, 2:07 PM
ffontaine created T132: pki_gcrypt: strict-overflow error with gcc 4.8.
Feb 21 2019, 2:07 PM
davidwed added a comment to T124: Connector interface does not work correctly in SSH server environment.

"ssh_packet_socket_controlflow_callback" is only called if you initialize a connection with ssh_connect. In server mode "ssh_packet_socket_controlflow_callback" is never called.

Feb 21 2019, 2:07 PM · Restricted Project

Feb 7 2019

aris committed rLIBSSHf890b09edbed: cmake: fix build problem on ubuntu 18.04 (authored by aris).
cmake: fix build problem on ubuntu 18.04
Feb 7 2019, 7:17 PM
Jakuje added a comment to T110: Knownhost notation with port wildcard ( [hostname]:* ) doesn't accept port 22.

Actually, man page for sshd from OpenSSH says the following:

Feb 7 2019, 6:03 PM · Restricted Project
asn assigned T110: Knownhost notation with port wildcard ( [hostname]:* ) doesn't accept port 22 to Jakuje.
Feb 7 2019, 3:17 PM · Restricted Project
asn closed T1: Key exchange fails if server doesn't send KEXINIT packet first as Resolved.

This should be fixed by b796924fea7e61a4a8813acce9e510f2359aee34

Feb 7 2019, 3:14 PM · Restricted Project
Jakuje closed T121: The server should not send the SSH_MSG_EXT_INFO message after rekeying as Resolved.

This was fixed by the previously mentioned commits that made their way into master and 0.8 branch.

Feb 7 2019, 3:08 PM · Restricted Project
asn added a project to T130: BUG?: sftp via socks5 with PROXYCOMMAND bails with read_packet(): Packet len too high (1818845806 6c69626e): Restricted Project.

Can you enable full logging and provide a log?

Feb 7 2019, 2:52 PM · Restricted Project
asn closed T131: [queestion]-[libssh]-When physical link is down(for example:the network cable is pull out by people) ,the channel can not detect broken timely as Resolved.
Feb 7 2019, 2:50 PM
asn added a comment to T131: [queestion]-[libssh]-When physical link is down(for example:the network cable is pull out by people) ,the channel can not detect broken timely.

The timeout issues should be better with 0.8. Please update. Feel free to reopen if you have the same issues with 0.9 which will be released soon.

Feb 7 2019, 2:50 PM
asn added a comment to T128: net-libs/libssh compile issue with libressl-2.6.5.

I'm sorry but we don't have support libressl. If you want support for it you need to implement the support for it.

Feb 7 2019, 2:46 PM · Restricted Project
asn closed T126: connect.c: fix strict-overflow error as Resolved.

This as been already addressed with 58113d489eecfeb266b82de7bb25d4a0526b9606

Feb 7 2019, 2:44 PM
asn committed rLIBSSHa1559505a561: cmake: Bump API version to 4.7.4 (authored by asn).
cmake: Bump API version to 4.7.4
Feb 7 2019, 2:36 PM
asn committed rLIBSSHfa6aa125a260: tests/pkd: repro rsa-sha2-{256,512} negotiation bug (authored by simonsj).
tests/pkd: repro rsa-sha2-{256,512} negotiation bug
Feb 7 2019, 2:34 PM
asn committed rLIBSSHe05e4ae9712b: pki_crypto: plug pki_signature_from_blob leaks (authored by simonsj).
pki_crypto: plug pki_signature_from_blob leaks
Feb 7 2019, 2:34 PM
asn committed rLIBSSHa4948f621278: kex: honor client preference for rsa-sha2-{256,512} host key algorithms (authored by simonsj).
kex: honor client preference for rsa-sha2-{256,512} host key algorithms
Feb 7 2019, 2:34 PM