Page MenuHomePhabricator
Create Task
Maniphest T85

missing cipher 'none'
Closed, ResolvedPublic
Actions

Description

'none' cipher is not supported by 0.7.5
'none' MAC is not supported by 0.7.5
i revised both wrapper.c and kex.c .... please add them as it is helpful in debugging

Related Objects

Event Timeline

m.nasim triaged this task as Normal priority.Feb 21 2018, 9:00 PM
m.nasim created this task.
townsend added a subscriber: townsend.Feb 27 2018, 2:55 PM

Hello,

I'm interested in trying this out, but I can't find your proposed patches anywhere. Could you make them available please?

m.nasim added a comment.Mar 13 2018, 5:19 PM
In T85#1236, @townsend wrote:

Hello,

I'm interested in trying this out, but I can't find your proposed patches anywhere. Could you make them available please?

Hello townsend,

sorry for my late feedback.
i didn't mention that i will provide a patch, i just noticed on [[ http://api.libssh.org/stable/ | this page  ]] that none cipher is supported. however, it is not there.

the patch i talked about in IRC channel, was for adding Twofish cipher. I have already submitted it in "wish list" and there is no feedback there.
my code is correct and i tested it against SecureCRT 8.3. the server is my own server using libssh.

asn lowered the priority of this task from Normal to Wishlist.Sep 4 2018, 10:24 PM
asn added a subscriber: asn.

Looking forward to a patch.

asn added a project: Restricted Project.Oct 9 2018, 2:19 PM
asn mentioned this in rLIBSSH46499b1b9090: Drop none cipher and MAC as they are not implemented.May 5 2020, 2:39 PM
Jakuje closed this task as Resolved.May 7 2020, 6:53 PM
Jakuje claimed this task.
Jakuje added a subscriber: Jakuje.

FYI, this landed as e6aee24a

I removed this from the documentation as it is clearly nothing for production. For testing, you can enable building these using -DWITH_INSECURE_NONE=ON.