cmake: Avoid setting compiler flags directly
Open, Needs TriagePublic
Actions

Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Mute Notifications
Award Token
Flag For Later

Assigned To

None

Authored By

	DDoSolitary
	Jan 23 2021, 4:41 AM

Description

Calling set_target_properties directly overrides previously set flags, so replace them with target_compile_definitions and target_link_options.

0001-cmake-Avoid-setting-compiler-flags-directly.patch2 KBDownload

Event Timeline

DDoSolitary created this task.Jan 23 2021, 4:41 AM

DDoSolitary updated the task description. (Show Details)Jan 23 2021, 4:44 AM

Looks good to me. Can you submit the patch in https://gitlab.com/libssh/libssh-mirror as a merge request with proper signoff trailers as described in the contributing guidelines?

Done: https://gitlab.com/libssh/libssh-mirror/-/merge_requests/158

cmake: Avoid setting compiler flags directlyOpen, Needs TriagePublicActions

Description

Event Timeline

cmake: Avoid setting compiler flags directly
Open, Needs TriagePublic
Actions