On Sunday, January 11th 2015 14:27:05, Michael DePaulo wrote:

Back in September, my friend Michael Frederick and I (gmail: psududemike) managed to port that patch to 0.6.3. We've been using it successfully in X2Go Client for Windows 4.0.3.0 and later.
That patch still applies to 0.6.4. I've attached the patch.

Comments are welcome.

I just signed my DCO. Mike Frederick assigned copyright of this patch to me, but if need be, he can sign the DCO also.

However, I am not sure about the DCO from the authors for the original patch. Actually, there were 2 different versions of the original patch:
0001-implement-support-for-putty-s-pageant.patch - which was superseded by:
0001-implement-support-for-putty-s-pageant-0.5.3.patch
And to make things more confusing, there were multiple versions of the 0.5.3 patch.
That ohloh.net link no longer works. But both original patches are available here.
https://projects.kde.org/projects/kdesupport/emerge/repository/revisions/master/show/portage/win32libs/libssh

The 2 authors of those patches appear to be:
Patrick Spendrin <ps//ml`gmx.de>
Patrick von Reth

So at this point, I am not sure how to proceed. Let me ask: Did those 2 authors ever submit the DCO?

and:

On Thursday, January 15th 2015 09:03:58, Andreas Schneider wrote:

Thanks for your work. Copyright doesn't need to be assigned if all people are individuals. The Certificate of Origin is only for people who send patches with Corporate Copyright!

The patch is far from being in a state that I would include it. We need to design a new API for this, similar to pki.c. With ssh-agens it is possible that you want to support ssh-agend and pagent on Windows at the same time. So we need a way to build with both and register the backend at the agent engine. We can discuss this on IRC.

On Friday, January 16th 2015 21:41:54, Michael DePaulo wrote:

Andreas Schneider wrote:

With ssh-agens it is possible that you want to support ssh-agend and pagent on Windows at the same time.

I did some research :

1. It appears that there is no actively maintained port of OpenSSH (and therefore ssh-agent) to Windows. In order to not be affected by a vulnerability, one needs to use OpenSSH 6.7p1 or later.

2. In the past, NoMachine ported SSH to Windows. But they are not maintaining it anymore. The last ported version was 5.9p1.

https://www.nomachine.com/AR11K00739
https://www.nomachine.com/NoMachine-OSS-ports

3. There is actively maintained software such as "OpenSSH for Windows", which is at 6.7p1. But they are actually OpenSSH for Cygwin with an easy Windows installer.

http://www.mls-software.com/opensshd.html

If you'd like, I can test cygwin ssh-agent 6.7p1 with native Windows libssh and see if it actually works. But I do not feel it is appropriate to maintain support for native Windows ssh-agent so long as it is unmaintained.

On Sunday, January 11th 2015 14:27:05, Michael DePaulo wrote:

Back in September, my friend Michael Frederick and I (gmail: psududemike) managed to port that patch to 0.6.3. We've been using it successfully in X2Go Client for Windows 4.0.3.0 and later.
That patch still applies to 0.6.4. I've attached the patch.

Comments are welcome.

I just signed my DCO. Mike Frederick assigned copyright of this patch to me, but if need be, he can sign the DCO also.

However, I am not sure about the DCO from the authors for the original patch. Actually, there were 2 different versions of the original patch:
0001-implement-support-for-putty-s-pageant.patch - which was superseded by:
0001-implement-support-for-putty-s-pageant-0.5.3.patch
And to make things more confusing, there were multiple versions of the 0.5.3 patch.
That ohloh.net link no longer works. But both original patches are available here.
https://projects.kde.org/projects/kdesupport/emerge/repository/revisions/master/show/portage/win32libs/libssh

The 2 authors of those patches appear to be:
Patrick Spendrin <ps//ml`gmx.de>
Patrick von Reth

So at this point, I am not sure how to proceed. Let me ask: Did those 2 authors ever submit the DCO?

and:

On Thursday, January 15th 2015 09:03:58, Andreas Schneider wrote:

Thanks for your work. Copyright doesn't need to be assigned if all people are individuals. The Certificate of Origin is only for people who send patches with Corporate Copyright!

The patch is far from being in a state that I would include it. We need to design a new API for this, similar to pki.c. With ssh-agens it is possible that you want to support ssh-agend and pagent on Windows at the same time. So we need a way to build with both and register the backend at the agent engine. We can discuss this on IRC.

On Friday, January 16th 2015 21:41:54, Michael DePaulo wrote:

Andreas Schneider wrote:

With ssh-agens it is possible that you want to support ssh-agend and pagent on Windows at the same time.

I did some research :

1. It appears that there is no actively maintained port of OpenSSH (and therefore ssh-agent) to Windows. In order to not be affected by a vulnerability, one needs to use OpenSSH 6.7p1 or later.

2. In the past, NoMachine ported SSH to Windows. But they are not maintaining it anymore. The last ported version was 5.9p1.

https://www.nomachine.com/AR11K00739
https://www.nomachine.com/NoMachine-OSS-ports

3. There is actively maintained software such as "OpenSSH for Windows", which is at 6.7p1. But they are actually OpenSSH for Cygwin with an easy Windows installer.

http://www.mls-software.com/opensshd.html

If you'd like, I can test cygwin ssh-agent 6.7p1 with native Windows libssh and see if it actually works. But I do not feel it is appropriate to maintain support for native Windows ssh-agent so long as it is unmaintained.

On Sunday, January 11th 2015 14:27:05, Michael DePaulo wrote:

Back in September, my friend Michael Frederick and I (gmail: psududemike) managed to port that patch to 0.6.3. We've been using it successfully in X2Go Client for Windows 4.0.3.0 and later.
That patch still applies to 0.6.4. I've attached the patch.

Comments are welcome.

I just signed my DCO. Mike Frederick assigned copyright of this patch to me, but if need be, he can sign the DCO also.

However, I am not sure about the DCO from the authors for the original patch. Actually, there were 2 different versions of the original patch:
0001-implement-support-for-putty-s-pageant.patch - which was superseded by:
0001-implement-support-for-putty-s-pageant-0.5.3.patch
And to make things more confusing, there were multiple versions of the 0.5.3 patch.
That ohloh.net link no longer works. But both original patches are available here.
https://projects.kde.org/projects/kdesupport/emerge/repository/revisions/master/show/portage/win32libs/libssh

The 2 authors of those patches appear to be:
Patrick Spendrin <ps//ml`gmx.de>
Patrick von Reth

So at this point, I am not sure how to proceed. Let me ask: Did those 2 authors ever submit the DCO?

and:

On Thursday, January 15th 2015 09:03:58, Andreas Schneider wrote:

Thanks for your work. Copyright doesn't need to be assigned if all people are individuals. The Certificate of Origin is only for people who send patches with Corporate Copyright!

The patch is far from being in a state that I would include it. We need to design a new API for this, similar to pki.c. With ssh-agens it is possible that you want to support ssh-agend and pagent on Windows at the same time. So we need a way to build with both and register the backend at the agent engine. We can discuss this on IRC.

On Friday, January 16th 2015 21:41:54, Michael DePaulo wrote:

Andreas Schneider wrote:

With ssh-agens it is possible that you want to support ssh-agend and pagent on Windows at the same time.

I did some research :

1. It appears that there is no actively maintained port of OpenSSH (and therefore ssh-agent) to Windows. In order to not be affected by a vulnerability, one needs to use OpenSSH 6.7p1 or later.

2. In the past, NoMachine ported SSH to Windows. But they are not maintaining it anymore. The last ported version was 5.9p1.

https://www.nomachine.com/AR11K00739
https://www.nomachine.com/NoMachine-OSS-ports

3. There is actively maintained software such as "OpenSSH for Windows", which is at 6.7p1. But they are actually OpenSSH for Cygwin with an easy Windows installer.

http://www.mls-software.com/opensshd.html

If you'd like, I can test cygwin ssh-agent 6.7p1 with native Windows libssh and see if it actually works. But I do not feel it is appropriate to maintain support for native Windows ssh-agent so long as it is unmaintained.

On Sunday, January 11th 2015 14:27:05, Michael DePaulo wrote:

Back in September, my friend Michael Frederick and I (gmail: psududemike) managed to port that patch to 0.6.3. We've been using it successfully in X2Go Client for Windows 4.0.3.0 and later.
That patch still applies to 0.6.4. I've attached the patch.

Comments are welcome.

I just signed my DCO. Mike Frederick assigned copyright of this patch to me, but if need be, he can sign the DCO also.

However, I am not sure about the DCO from the authors for the original patch. Actually, there were 2 different versions of the original patch:
0001-implement-support-for-putty-s-pageant.patch - which was superseded by:
0001-implement-support-for-putty-s-pageant-0.5.3.patch
And to make things more confusing, there were multiple versions of the 0.5.3 patch.
That ohloh.net link no longer works. But both original patches are available here.
https://projects.kde.org/projects/kdesupport/emerge/repository/revisions/master/show/portage/win32libs/libssh

The 2 authors of those patches appear to be:
Patrick Spendrin <ps//ml`gmx.de>
Patrick von Reth

So at this point, I am not sure how to proceed. Let me ask: Did those 2 authors ever submit the DCO?

and:

On Thursday, January 15th 2015 09:03:58, Andreas Schneider wrote:

Thanks for your work. Copyright doesn't need to be assigned if all people are individuals. The Certificate of Origin is only for people who send patches with Corporate Copyright!

The patch is far from being in a state that I would include it. We need to design a new API for this, similar to pki.c. With ssh-agens it is possible that you want to support ssh-agend and pagent on Windows at the same time. So we need a way to build with both and register the backend at the agent engine. We can discuss this on IRC.

On Friday, January 16th 2015 21:41:54, Michael DePaulo wrote:

Andreas Schneider wrote:

With ssh-agens it is possible that you want to support ssh-agend and pagent on Windows at the same time.

I did some research :

1. It appears that there is no actively maintained port of OpenSSH (and therefore ssh-agent) to Windows. In order to not be affected by a vulnerability, one needs to use OpenSSH 6.7p1 or later.

2. In the past, NoMachine ported SSH to Windows. But they are not maintaining it anymore. The last ported version was 5.9p1.

https://www.nomachine.com/AR11K00739
https://www.nomachine.com/NoMachine-OSS-ports

3. There is actively maintained software such as "OpenSSH for Windows", which is at 6.7p1. But they are actually OpenSSH for Cygwin with an easy Windows installer.

http://www.mls-software.com/opensshd.html

If you'd like, I can test cygwin ssh-agent 6.7p1 with native Windows libssh and see if it actually works. But I do not feel it is appropriate to maintain support for native Windows ssh-agent so long as it is unmaintained.

This probably needs some refactoring and nicer abstraction for ssh agents.

See https://stackoverflow.com/questions/12452933/putty-pageant-protocol and the current version from putty base for the patch:

https://github.com/github/putty/blob/master/windows/winpgntc.c

For those who're interested, I wrote a new patch from scratch which is based on the latest 0.9.3 release.

I agree that it is better to support multiple agent implementations at the same time. Actually the situation is rather complicated on Windows currently.

• Putty's pageant uses a message-only window and memory-mapped files. gpg4win also provides support for that.
• Cygwin has its own implementation for AF_UNIX sockets
• Microsoft now ships their own port of OpenSSH with Windows which uses the native AF_UNIX socket introduced in Windows 10. However, older versions of this port uses a global named pipe.

It would be really amazing to have all of these supported, though quite a lot of work might be needed.

This issue was moved to gitlab: https://gitlab.com/libssh/libssh-mirror/-/issues/45