Page MenuHomePhabricator

0.9.0 gcc compiler warnings deprecated-declarations
Closed, ResolvedPublic

Description

See https://travis-ci.org/ashkulz/NppFTP/jobs/560082157 (mingw 7.2 on ubuntu 18.04 bionic x64):

/home/travis/build/ashkulz/NppFTP/x64/obj/libssh/src/known_hosts.c:408:9: warning: ‘ssh_write_knownhost’ is deprecated [-Wdeprecated-declarations]
         ssh_write_knownhost(session);
         ^~~~~~~~~~~~~~~~~~~
In file included from /home/travis/build/ashkulz/NppFTP/x64/obj/libssh/include/libssh/priv.h:171:0,
                 from /home/travis/build/ashkulz/NppFTP/x64/obj/libssh/src/known_hosts.c:31:
/home/travis/build/ashkulz/NppFTP/x64/obj/libssh/include/libssh/libssh.h:558:31: note: declared here
 SSH_DEPRECATED LIBSSH_API int ssh_write_knownhost(ssh_session session);
                               ^~~~~~~~~~~~~~~~~~~
/home/travis/build/ashkulz/NppFTP/x64/obj/libssh/src/known_hosts.c: In function ‘ssh_write_knownhost’:
/home/travis/build/ashkulz/NppFTP/x64/obj/libssh/src/known_hosts.c:532:5: warning: ‘ssh_dump_knownhost’ is deprecated [-Wdeprecated-declarations]
     buffer = ssh_dump_knownhost(session);
     ^~~~~~
/home/travis/build/ashkulz/NppFTP/x64/obj/libssh/src/known_hosts.c:426:8: note: declared here
 char * ssh_dump_knownhost(ssh_session session) {
        ^~~~~~~~~~~~~~~~~~

Event Timeline

chcg renamed this task from 0.9.0 compiler warnings deprecated-declarations to 0.9.0 gcc compiler warnings deprecated-declarations.Jul 17 2019, 7:39 PM
chcg created this task.
chcg updated the task description. (Show Details)
Jakuje added a subscriber: Jakuje.EditedSep 13 2019, 1:29 PM

This should be addressed by using the new API even inside of the deprecated functions without the change of functionality. Can you try the following patch?

https://gitlab.com/jjelen/libssh-mirror/commit/30d31908

Jakuje closed this task as Resolved.Sep 16 2019, 12:56 PM
Jakuje claimed this task.