Page MenuHomePhabricator

Add ssh_threads_get_winlock() to the callbacks.h
Closed, InvalidPublic

Description

Add ssh_threads_get_winlock() to be used with ssh_threads_set_callbacks.

BTW: I have also removed the warning regarding the ssh_threads library because it is no longer needed.

Event Timeline

davidwed created this task.May 2 2019, 2:16 PM
davidwed updated the task description. (Show Details)May 2 2019, 2:19 PM

Hello,

Thank you for your contribution!

I don't know if it is a good idea to export a function that will not always be available. For pthreads, it was already exported, so we couldn't remove it to keep the API compatible.

Wouldn't be better to export ssh_threads_get_default() instead? This will always be available and will return the appropriate callbacks structure for the environment. With that in place, we can think of deprecating ssh_threads_get_pthread().

Sounds good to me.

davidwed closed this task as Invalid.Jun 13 2019, 9:27 PM