Page MenuHomePhabricator

Add ssh_message_channel_request_open_reply_accept_channel function
Open, Needs TriagePublic

Description

add ssh_message_channel_request_open_reply_accept_channel to use already existing channel as opposed to ssh_message_channel_request_open_reply_accept.

Event Timeline

davidwed created this task.Apr 20 2019, 3:07 PM

Jakuje added a subscriber: Jakuje.Thu, Apr 25, 5:21 PM

I do not know a lot about the channels code. Sadly these functions do not have any documentation to clarify that to me.

At least, if they are going to be exposed in the public API, they should get at least basic doxygen documentation. This is strictly not part of this ticket, but I would appreciate to see that in addition to the exposing the function (assuming you know what does it do when you want to use it :) ).

asn added a subscriber: asn.Mon, Apr 29, 5:42 PM

David, could you help with documentation?

asn added a comment.Mon, Apr 29, 5:42 PM

David, could you help with documentation?

davidwed added a subscriber: aris.Tue, Apr 30, 1:00 AM

I've added some basic documentation, but I think @aris could write more about it. ( He implemented the functions ) :-)

rLIBSSH6bc64c368d49: server: added channel callbacks