Page MenuHomePhabricator

pki_gcrypt: strict-overflow error with gcc 4.8
Closed, ResolvedPublic

Description

/home/buildroot/autobuild/instance-1/output/build/libssh-0.8.6/src/pki_gcrypt.c: In function 'privatekey_string_to_buffer':
/home/buildroot/autobuild/instance-1/output/build/libssh-0.8.6/src/pki_gcrypt.c:485:10: error: assuming signed overflow does not occur when simplifying conditional to constant [-Werror=strict-overflow]

while(len > 0 && strncmp(p, header_end, header_end_size) != 0) {
     ^

See:

Event Timeline

This comment was removed by ffontaine.

Previous patch was wrong so here is a new patch to add an option to disable Werror

asn added a subscriber: asn.Feb 21 2019, 3:46 PM

Thanks for your contribution but why do you hide the issue instead of fixing it?

asn added a comment.Feb 21 2019, 5:31 PM
This comment was removed by asn.