Page MenuHomePhabricator

0.7.7 win32 x86 build issue
Closed, ResolvedPublic

Description

see also T112:

See https://ci.appveyor.com/project/chcg/nppftp/builds/19888936. x64 builds are fine, but x86 not. Definition for size_t is missing. Seems some include is missing. Compiler issue:

[ 12%] Building C object src/CMakeFiles/ssh_shared.dir/ecdh.c.obj

ecdh.c

C:\projects\nppftp\_build\x86\obj\libssh\include\libssh/priv.h(47): error C2146: syntax error: missing ')' before identifier 'n' [C:\projects\nppftp\_build\NppFTP3rdPartyPrerequists.vcxproj]

C:\projects\nppftp\_build\x86\obj\libssh\include\libssh/priv.h(47): error C2081: 'size_t': name in formal parameter list illegal [C:\projects\nppftp\_build\NppFTP3rdPartyPrerequists.vcxproj]

C:\projects\nppftp\_build\x86\obj\libssh\include\libssh/priv.h(47): error C2061: syntax error: identifier 'n' [C:\projects\nppftp\_build\NppFTP3rdPartyPrerequists.vcxproj]

C:\projects\nppftp\_build\x86\obj\libssh\include\libssh/priv.h(47): error C2059: syntax error: ';' [C:\projects\nppftp\_build\NppFTP3rdPartyPrerequists.vcxproj]

C:\projects\nppftp\_build\x86\obj\libssh\include\libssh/priv.h(47): error C2059: syntax error: ')' [C:\projects\nppftp\_build\NppFTP3rdPartyPrerequists.vcxproj]

Event Timeline

chcg created this task.Oct 29 2018, 11:31 PM
chcg added a comment.Oct 29 2018, 11:34 PM

As 0.8.x has a

#include <stdlib.h>

in file priv.h. I guess that should work. I think also including stddef.h explicitly would work.

chcg added a comment.Oct 31 2018, 6:28 PM

Further info:

  • also mingw32 builds fail due to missing size_t define, see:

32bit: https://travis-ci.org/ashkulz/NppFTP/jobs/448968832
64bit: https://travis-ci.org/ashkulz/NppFTP/jobs/448968833

chcg added a comment.EditedOct 31 2018, 7:15 PM

Seems 0.7 branch has no .gitlab-ci.yml and there is no build configured at https://gitlab.com/libssh/libssh-mirror/pipelines

Under https://gitlab.com/libssh/libssh-mirror/branches just master is available, but not the stable branches 0.7 and 0.8.

With the mingw CI builds it would be possible to find win build issues before SW is released.