- 5 KB
- Mime Type
- Raw Data
Thanks you very much for the patch!
I have some comments about the code:
- For ssh_connector_fd_read() and ssh_connector_fd_write() Please use ssize_t as the return value and the variable inside.
- Also check on unix using fstat and IS_SOCK() if it is a socket!
- Use 4 spaces
- Always use brackets for if-clauses, see CVE-2014-1266
- Pass MSG_NOSIGNAL to send if the flag exists
I've did some cleanup to socket.c you can find it here:
This should be a good reference how the code should look like.