Page MenuHomePhabricator

Needs Triage (8)

High (4)

Yesterday

gcampbell512 created T114: Interactive authentication is failing.
Thu, Oct 18, 10:56 PM
Jakuje added a comment to T107: ssh_session_has_known_hosts_entry doesn't seem to check in opts.global_knownhosts.

This issue is mostly related to the parallel work on the config parsing by me and rewrite of the knownhosts api by Andreas. The global knownhosts file was a new thing at this time and therefore I am not very surprised this slipped through.

Thu, Oct 18, 5:27 PM · Unknown Object (Project)
Jakuje added a comment to T105: HostKeyAlgorithms: Check if there is an entry in known_hosts and prefer that.

The following changes should settle the behavior to more sane that follows openssh and does not cause problems if there are more host keys stored in the known_hosts files:

Thu, Oct 18, 4:33 PM · Unknown Object (Project)
asn added a comment to T105: HostKeyAlgorithms: Check if there is an entry in known_hosts and prefer that.

a) We what the same what OpenSSH does. I think the function ssh_known_hosts_get_algorithms() just gets the one from known_hosts but dosn't deal with the supported defaults.
b) The global hosts file is not supported in the new known_hosts API I totally forgot to impelment that. See T107

Thu, Oct 18, 1:23 PM · Unknown Object (Project)
Jakuje added a comment to T105: HostKeyAlgorithms: Check if there is an entry in known_hosts and prefer that.

This is actually implemented by the function ssh_known_hosts_get_algorithms(), but behaves a bit differently than a similar function in OpenSSH client:

Thu, Oct 18, 11:57 AM · Unknown Object (Project)
tbeu added inline comments to rLIBSSHf81ca6161223: misc: Add strndup implementation if not provides by the OS.
Thu, Oct 18, 10:30 AM

Wed, Oct 17

asn committed rLIBSSHf81ca6161223: misc: Add strndup implementation if not provides by the OS (authored by asn).
misc: Add strndup implementation if not provides by the OS
Wed, Oct 17, 8:25 AM
asn closed T112: 0.7.6 strndup issue with visual studio as Resolved by committing rLIBSSHf81ca6161223: misc: Add strndup implementation if not provides by the OS.
Wed, Oct 17, 8:25 AM · Unknown Object (Project)
asn added a comment to T113: 0.8.4 ssize_t comiler errors with visual studio .

Does this patch work for you? https://git.libssh.org/users/asn/libssh.git/commit/?h=master-fix&id=89e14d61a07e2c722898760555f66b809305a605

Wed, Oct 17, 8:20 AM · Unknown Object (Project)
chcg added a project to T113: 0.8.4 ssize_t comiler errors with visual studio : Unknown Object (Project).
Wed, Oct 17, 4:35 AM · Unknown Object (Project)
chcg renamed T113: 0.8.4 ssize_t comiler errors with visual studio from 0.8.4 ssize_t with visual studio to 0.8.4 ssize_t comiler errors with visual studio .
Wed, Oct 17, 4:34 AM · Unknown Object (Project)
chcg created T113: 0.8.4 ssize_t comiler errors with visual studio .
Wed, Oct 17, 4:34 AM · Unknown Object (Project)
chcg created T112: 0.7.6 strndup issue with visual studio.
Wed, Oct 17, 4:00 AM · Unknown Object (Project)

Tue, Oct 16

asn committed rLIBSSHf1d57223dbc0: CVE-2018-10933: Add tests for packet filtering (authored by ansasaki).
CVE-2018-10933: Add tests for packet filtering
Tue, Oct 16, 2:09 PM
asn committed rLIBSSHc20b360c96a0: Bump version to 0.7.6 (authored by asn).
Bump version to 0.7.6
Tue, Oct 16, 2:09 PM
asn committed rLIBSSH5e061962c59f: cpack: Fix ignore files (authored by asn).
cpack: Fix ignore files
Tue, Oct 16, 2:09 PM
asn committed rLIBSSHb9033ad56a49: CVE-2018-10933: Introduced packet filtering (authored by ansasaki).
CVE-2018-10933: Introduced packet filtering
Tue, Oct 16, 2:09 PM
asn committed rLIBSSHe5ff7aa410c2: CVE-2018-10933: Check channel state when OPEN_FAILURE arrives (authored by ansasaki).
CVE-2018-10933: Check channel state when OPEN_FAILURE arrives
Tue, Oct 16, 2:09 PM
asn committed rLIBSSH3837a0547f08: CVE-2018-10933: Check channel state when OPEN_CONFIRMATION arrives (authored by ansasaki).
CVE-2018-10933: Check channel state when OPEN_CONFIRMATION arrives
Tue, Oct 16, 2:09 PM
asn committed rLIBSSH7985acb76842: CVE-2018-10933: Set correct state after sending MIC (authored by ansasaki).
CVE-2018-10933: Set correct state after sending MIC
Tue, Oct 16, 2:09 PM
asn committed rLIBSSHacd6a1ca8a33: CVE-2018-10933: Introduce SSH_AUTH_STATE_AUTH_NONE_SENT (authored by ansasaki).
CVE-2018-10933: Introduce SSH_AUTH_STATE_AUTH_NONE_SENT
Tue, Oct 16, 2:08 PM
asn committed rLIBSSHddea46f890bd: CVE-2018-10933: Introduce SSH_AUTH_STATE_PASSWORD_AUTH_SENT (authored by ansasaki).
CVE-2018-10933: Introduce SSH_AUTH_STATE_PASSWORD_AUTH_SENT
Tue, Oct 16, 2:08 PM
asn committed rLIBSSHe5f0e711b05c: CVE-2018-10933: Introduced new auth states (authored by ansasaki).
CVE-2018-10933: Introduced new auth states
Tue, Oct 16, 2:08 PM
asn committed rLIBSSH60037f327540: Bump ABI to 4.7.1 (authored by asn).
Bump ABI to 4.7.1
Tue, Oct 16, 2:08 PM
asn committed rLIBSSHe1548a71bdac: CVE-2018-10933: Add tests for packet filtering (authored by ansasaki).
CVE-2018-10933: Add tests for packet filtering
Tue, Oct 16, 2:08 PM
asn committed rLIBSSH75be012b4a14: CVE-2018-10933: Introduced packet filtering (authored by ansasaki).
CVE-2018-10933: Introduced packet filtering
Tue, Oct 16, 2:08 PM
asn committed rLIBSSH68b0c7a93448: CVE-2018-10933: Check channel state when OPEN_FAILURE arrives (authored by ansasaki).
CVE-2018-10933: Check channel state when OPEN_FAILURE arrives
Tue, Oct 16, 2:08 PM
asn committed rLIBSSH459868c4a57d: CVE-2018-10933: Check channel state when OPEN_CONFIRMATION arrives (authored by ansasaki).
CVE-2018-10933: Check channel state when OPEN_CONFIRMATION arrives
Tue, Oct 16, 2:08 PM
asn committed rLIBSSH5d7414467d6d: CVE-2018-10933: Set correct state after sending MIC (authored by ansasaki).
CVE-2018-10933: Set correct state after sending MIC
Tue, Oct 16, 2:08 PM
asn committed rLIBSSH20981bf22962: CVE-2018-10933: Introduce SSH_AUTH_STATE_AUTH_NONE_SENT (authored by ansasaki).
CVE-2018-10933: Introduce SSH_AUTH_STATE_AUTH_NONE_SENT
Tue, Oct 16, 2:07 PM
asn committed rLIBSSH825f4ba96407: CVE-2018-10933: Introduce SSH_AUTH_STATE_PASSWORD_AUTH_SENT (authored by ansasaki).
CVE-2018-10933: Introduce SSH_AUTH_STATE_PASSWORD_AUTH_SENT
Tue, Oct 16, 2:07 PM
asn committed rLIBSSH2bddafeb709e: CVE-2018-10933: Introduced new auth states (authored by ansasaki).
CVE-2018-10933: Introduced new auth states
Tue, Oct 16, 2:07 PM
asn committed rLIBSSH09a7638575b3: CVE-2018-10933: Add tests for packet filtering (authored by ansasaki).
CVE-2018-10933: Add tests for packet filtering
Tue, Oct 16, 2:07 PM
asn committed rLIBSSH66a222a73c4d: Bump ABI to 4.7.1 (authored by asn).
Bump ABI to 4.7.1
Tue, Oct 16, 2:07 PM
asn committed rLIBSSH789df0b7d0c7: Bump version to 0.8.4 (authored by asn).
Bump version to 0.8.4
Tue, Oct 16, 2:07 PM
asn committed rLIBSSH203818608ac8: CVE-2018-10933: Introduced packet filtering (authored by ansasaki).
CVE-2018-10933: Introduced packet filtering
Tue, Oct 16, 2:07 PM
asn committed rLIBSSHf8c452cbef22: CVE-2018-10933: Check channel state when OPEN_FAILURE arrives (authored by ansasaki).
CVE-2018-10933: Check channel state when OPEN_FAILURE arrives
Tue, Oct 16, 2:07 PM
asn committed rLIBSSHadeaa69cc535: CVE-2018-10933: Check channel state when OPEN_CONFIRMATION arrives (authored by ansasaki).
CVE-2018-10933: Check channel state when OPEN_CONFIRMATION arrives
Tue, Oct 16, 2:06 PM
asn committed rLIBSSH72bce5ece7ed: CVE-2018-10933: Set correct state after sending MIC (authored by ansasaki).
CVE-2018-10933: Set correct state after sending MIC
Tue, Oct 16, 2:06 PM
asn committed rLIBSSHfcfba0d8aa15: CVE-2018-10933: Introduce SSH_AUTH_STATE_PASSWORD_AUTH_SENT (authored by ansasaki).
CVE-2018-10933: Introduce SSH_AUTH_STATE_PASSWORD_AUTH_SENT
Tue, Oct 16, 2:06 PM