This looks fine now. However it needs rebasing on master!
Needs Triage (4)
- T79 Forcing Key Exchange Methods to diffie-hellman-group14-sha1 with an additional algorithm (any of the supported) exit with a ssh_options_set error (invalid value)
- Restricted Project
- Thu, Dec 7, 10:45 PM
Tue, Dec 12
Mon, Dec 11
- Add mbedtls drbg reseeding
- Update README.mbedtls with info for ssh_key_cmp
Thu, Dec 7
Tue, Dec 5
Fri, Dec 1
Sun, Nov 26
I'm very new with phabricator, apologies if I'm using it incorrectly.
I have two questions:
Nov 17 2017
I've fixed the memory leaks and config.h issues. README.mbedtls has also been added.
However, maybe the comparison code for ECDSA could be written with what mbedTLS already provides, the private and public curve points and the group can be accessed through the ECDSA context, however a function similar to EC_POINT_cmp doesn't exist, so I will have to look further into that when I find some time as I'm not sure what effect the curve group has on point comparison. The gcrypt code just compares the private and public points.
Nov 16 2017
I'm sorry but static linking is not encouraged.
Nov 9 2017
Nov 8 2017
Nov 7 2017
Oct 29 2017
Also the SSH server might not support password auth. It is normally disabled by default.
I don't really see why you need this. We offer a callback for logging and you can implement libdispatch specific stuff in there. You can pass in the queue using the userdata pointer.
Fixed with d3834f69bc3ddaccdccf6df09c5526224ece761d
the patchset still needs several fixes especially for memory leak in error conditions. See inline comments for this!