After more hours of digging in the code, I isolated this to the two SFTP calls that cause this issue to be reproducible reliably. These are calls to ssh_channel_send_eof() and ssh_channel_free() from sftp_free() called from the cleanup of the first sftp. If I remove these two calls, the testsuite passes reproducibly.
Needs Triage (8)
Needs Triage (8)
High (4)
High (4)
- Restricted Project
- Sep 5 2018, 8:56 AM
Normal (3)
Normal (3)
- Restricted Project
- Oct 19 2018, 3:44 PM
- Restricted Project
- Oct 19 2018, 9:23 PM
- rLIBSSH libssh
- 5,547 Commits
- ·
- Restricted Project
- Thu, Nov 15, 4:36 PM
- Git
Today
Today
Mon, Nov 19, 3:50 PM · Restricted Project
Mon, Nov 19, 11:01 AM · Restricted Project
Fri, Nov 16
Fri, Nov 16
Fri, Nov 16, 4:37 PM · Restricted Project
Thu, Nov 15
Thu, Nov 15
tests: Fix chroot_wrapper location
asn committed rLIBSSH3de34944ad11: tests: Ensure the ssh session fd is read-/writeable in torture_proxycommand (authored by Gundersanne).
tests: Ensure the ssh session fd is read-/writeable in torture_proxycommand
tests: Fix chroot_wrapper location
Tue, Nov 13
Tue, Nov 13
I am seeing this issue with sftp_read(). The sftp_read() function call was getting hung when there was a disconnect. I traced it to ssh_channel_read() which isn't using the user defined timeout.
Tue, Nov 13, 4:46 PM · Restricted Project
ssh_channel_read_timeout()
Tue, Nov 13, 4:38 PM · Restricted Project
Tue, Nov 13, 3:39 PM · Restricted Project
I have tested with 0.8.4. It looks like SSH_TIMEOUT_DEFAULT is always -1 even if I set SSH_OPTIONS_TIMEOUT.
Tue, Nov 13, 2:18 PM · Restricted Project
This should be fixed with c2fc9ac956b4452066543f8d22758bb710b752b7 and ef06ef2c1bf9cab97ecf451d40c1311b2f0d4b02
Tue, Nov 13, 12:48 PM · Restricted Project
Did you test this with libssh >= 0.8.3. Because I fixed some things.
Tue, Nov 13, 12:47 PM · Restricted Project
Fri, Nov 9
Fri, Nov 9
This is related to this issue discussed here: https://www.libssh.org/archive/libssh/2016-02/0000010.html
Fri, Nov 9, 10:35 PM · Restricted Project
Thu, Nov 8
Thu, Nov 8
asn committed rLIBSSH67f418218bd3: knownhosts: Take StrictHostKeyChecking option into account (authored by Gundersanne).
knownhosts: Take StrictHostKeyChecking option into account
asn committed rLIBSSH69cb3c583539: knownhosts: Take StrictHostKeyChecking option into account (authored by Gundersanne).
knownhosts: Take StrictHostKeyChecking option into account
asn committed rLIBSSH03c30e9c8ad3: tests: Ensure the ssh session fd is read-/writeable in torture_proxycommand (authored by Gundersanne).
tests: Ensure the ssh session fd is read-/writeable in torture_proxycommand
Yes, I think that would be the correct fix.
Thu, Nov 8, 5:35 PM · Restricted Project
asn committed rLIBSSH5102b16cf131: crypto: Fix compilation for OpenSSL without deprecated APIs (authored by Rosen Penev <rosenp@gmail.com>).
crypto: Fix compilation for OpenSSL without deprecated APIs
asn committed rLIBSSH61cac32288fb: crypto: Fix compilation for OpenSSL without deprecated APIs (authored by Rosen Penev <rosenp@gmail.com>).
crypto: Fix compilation for OpenSSL without deprecated APIs
Tue, Nov 6
Tue, Nov 6
Gundersanne added a comment to T108: setting knownhost option to NULL crashes, at least before connecting.
options.c:610 in current master:
Tue, Nov 6, 3:35 PM · Restricted Project
Jakuje added a comment to T108: setting knownhost option to NULL crashes, at least before connecting.
No, this issue is still present it I am right.
Tue, Nov 6, 2:29 PM · Restricted Project
Probably not. I assume this is not only about configuration parser (which was fixed in several aspects recently), but instead about the way how the proxycommand is implemented in libssh (I am actually not sure how does it work there). The important are errors with ProxyCommand, but for further investigation, some debugging log will be needed:
Tue, Nov 6, 2:23 PM · Restricted Project
Jabuk, is that working with the new config parsting stuff?
Tue, Nov 6, 2:16 PM · Restricted Project
Fixed in libssh 0.8.1 or newer.
Tue, Nov 6, 2:15 PM · Restricted Project
Tue, Nov 6, 2:13 PM · Restricted Project
Jakub, didn't we already fix this?
Tue, Nov 6, 2:13 PM · Restricted Project
asn committed rLIBSSHdc071dc6cf1b: cmake: Refresh the CMake Config files (authored by Christophe Giboudeaux <christophe@krop.fr>).
cmake: Refresh the CMake Config files
asn committed rLIBSSHaa899f8ec06e: cmake: Refresh the CMake Config files (authored by Christophe Giboudeaux <christophe@krop.fr>).
cmake: Refresh the CMake Config files
Mon, Nov 5
Mon, Nov 5
asn committed rLIBSSHc88fb4c55b54: tests: Use correct assert function in torture_client_config (authored by asn).
tests: Use correct assert function in torture_client_config
asn committed rLIBSSH86dabfe7e424: cmake: Only check for bounded attribute on OpenBSD (authored by asn).
cmake: Only check for bounded attribute on OpenBSD
asn committed rLIBSSHa8ed5e31dc15: tests: Check for NULL in torture_client_config (authored by asn).
tests: Check for NULL in torture_client_config
Fri, Nov 2
Fri, Nov 2
asn committed rLIBSSH1650d8178e48: config: Avoid potential file descriptor leak (authored by Jakuje).
config: Avoid potential file descriptor leak
asn committed rLIBSSHa8d4fbaccb93: tests: Improve error reporting in auth test (authored by Jakuje).
tests: Improve error reporting in auth test
asn committed rLIBSSH56b7d2da4d51: tests: Typo -- the flags should be checked according to the comment (authored by Jakuje).
tests: Typo -- the flags should be checked according to the comment
asn committed rLIBSSHa4b99eedf2f0: knownhosts: Make sure we have both knownhosts files ready (authored by Jakuje).
knownhosts: Make sure we have both knownhosts files ready
client: Reformat comment
tests/pkd: Properly clean up memory
asn committed rLIBSSH059079581add: session: Drop unused structure member (SSHv1) (authored by Jakuje).
session: Drop unused structure member (SSHv1)
asn committed rLIBSSHf11be32e1182: misc: Properly check for errors returned from getpwuid_r() (authored by Jakuje).
misc: Properly check for errors returned from getpwuid_r()