Page MenuHomePhabricator

Open Tasks

Needs Triage (10)

High (4)

Active Repositories

Recent Activity

Today

Jakuje added a comment to T123: Unable to import key files with leading whitespace.

Can you provide example of such key? Do you mean private keys in PEM format or in OpenSSH format? Or public keys?

Wed, Jun 19, 3:13 PM · Restricted Project
Jakuje added a comment to T76: Support keys with line comments.

I think this got resolved over the time and the PEM files are readable including the inline comments (probably because of the removal of the SSH1 protocol, which had special conditions for the old RSA1 keys).

Wed, Jun 19, 3:09 PM · Restricted Project
Jakuje added a comment to T130: BUG?: sftp via socks5 with PROXYCOMMAND bails with read_packet(): Packet len too high (1818845806 6c69626e).

Please, check the following commits in the master-fix branch:

Wed, Jun 19, 2:31 PM · Restricted Project
Jakuje added a comment to T130: BUG?: sftp via socks5 with PROXYCOMMAND bails with read_packet(): Packet len too high (1818845806 6c69626e).

Do you have a minimal reproducer that demonstrates this issue? The following parts do not look correct:

[2019/02/21 16:35:31.187831, 3] callback_receive_banner: ssh_protocol_version_exchange: Ncat: Version 7.70 ( https://nmap.org/ncat )

a bit later is what should be coming -- the SSH identification banner:

[2019/02/21 16:40:54.932576, 3] callback_receive_banner: ssh_protocol_version_exchange: libnsock nsock_trace_handler_callback(): Callback: READ SUCCESS for EID 10 [peer unspecified] (33 bytes): SSH-2.0-1.36_sshlib GlobalSCAPE..`

I am afraid that the ncat dumps some additional data to stderr, which is unintentionally picked up by the libssh. This is caused by the code in the src/socket.c:815, where both stdout and stderr is redirected to libssh

dup2(out,1);
dup2(out,2);

You ca try to drop the second line above, which should let the stderr to be mixed up with the libssh stderr or dropped (not sure from top of my head), but it should let you move on.

Wed, Jun 19, 2:00 PM · Restricted Project
Jakuje added a comment to T151: curve25519-sha256 problems under Valgrind on i386.

The same thing works for me with the current openssh-portable master that I just built in my Fedora VM. Could this be somehow related to the Ubuntu toolchains or packages, rather than to the 32 bits itsef?

Wed, Jun 19, 1:42 PM
Jakuje added a comment to T151: curve25519-sha256 problems under Valgrind on i386.

I tried also the 0.8.7 branch as reported in the previous comment, but with the same result. Could it be an issue in valgrind or some other part of the toolchain?

Wed, Jun 19, 1:23 PM
Jakuje added a comment to T151: curve25519-sha256 problems under Valgrind on i386.

I just installed Fedora 27 i386 image (I was not successful with installing anything newer since it is secondary architecture for several releases and receives close to none testing) and current libssh master and I can not reproduce your issue.

Wed, Jun 19, 1:17 PM

Fri, Jun 14

asn committed rLIBSSHbb98413fc184: Bump version to 0.8.91 (authored by asn).
Bump version to 0.8.91
Fri, Jun 14, 3:36 PM
asn committed rLIBSSH2a8cd81e8f8a: Update ChangeLog (authored by asn).
Update ChangeLog
Fri, Jun 14, 3:36 PM
asn committed rLIBSSH3cb0a1bf023c: Bump SO version to 4.8.1 (authored by asn).
Bump SO version to 4.8.1
Fri, Jun 14, 3:31 PM
asn committed rLIBSSH2d2a4f3784bd: include: Make sure ssh_session_get_known_hosts_entry is added to the API (authored by asn).
include: Make sure ssh_session_get_known_hosts_entry is added to the API
Fri, Jun 14, 3:31 PM
asn committed rLIBSSH70dd8b0348fc: callbacks: Add ssh_threads_get_default() to the callbacks.h (authored by davidwed).
callbacks: Add ssh_threads_get_default() to the callbacks.h
Fri, Jun 14, 3:31 PM
asn committed rLIBSSHc4463ba5e7e6: tests/torture_config: Replace long long with uint64_t (authored by ansasaki).
tests/torture_config: Replace long long with uint64_t
Fri, Jun 14, 3:31 PM
asn committed rLIBSSHab25ca205d8b: channels: Do not mix integer types (authored by ansasaki).
channels: Do not mix integer types
Fri, Jun 14, 3:31 PM
asn committed rLIBSSHfba384ac5879: tests/torture_rekey: Replace long long with uint64_t (authored by ansasaki).
tests/torture_rekey: Replace long long with uint64_t
Fri, Jun 14, 3:31 PM
asn committed rLIBSSH91960409c35b: ed25519: Replace unsigned long long with uint64_t (authored by ansasaki).
ed25519: Replace unsigned long long with uint64_t
Fri, Jun 14, 3:31 PM
asn committed rLIBSSH955d6f1b1795: config: Replace long long with int64_t (authored by ansasaki).
config: Replace long long with int64_t
Fri, Jun 14, 3:30 PM
asn committed rLIBSSHb775e316fa9c: priv.h: Add macro definitions for PRIx32 and PRIx64 (authored by ansasaki).
priv.h: Add macro definitions for PRIx32 and PRIx64
Fri, Jun 14, 3:30 PM
asn committed rLIBSSH0280ff12a533: sftp: Do not mix integer types (authored by ansasaki).
sftp: Do not mix integer types
Fri, Jun 14, 3:30 PM
asn added a comment to T142: torture_proxycommand failing.

Is this using musl libc?

Fri, Jun 14, 12:04 PM · Restricted Project
asn closed T150: test torture_config (Failed) as Resolved.

Should be fixed by 1f43b52117fc97eef95e3627517cadb531b2b43e

Fri, Jun 14, 12:02 PM · Restricted Project
asn closed T152: Match exec with arguments breaks .ssh/config parse as Resolved.
Fri, Jun 14, 12:02 PM · Restricted Project
ansasaki added a comment to T154: Add ssh_threads_get_default() to the callbacks.h.

I just adjusted the documentation comment a bit, and removed the invalid warning from ssh_threads_get_pthread()

Fri, Jun 14, 10:36 AM · Restricted Project
asn assigned T154: Add ssh_threads_get_default() to the callbacks.h to ansasaki.
Fri, Jun 14, 8:01 AM · Restricted Project
asn committed rLIBSSH4fc37bb6fed9: tests: Add more reproducers for valid and invalid Match exec blocks (authored by Jakuje).
tests: Add more reproducers for valid and invalid Match exec blocks
Fri, Jun 14, 8:00 AM
asn committed rLIBSSHed8284ab0976: config: Skip the rest of the line for Match exec (authored by Jakuje).
config: Skip the rest of the line for Match exec
Fri, Jun 14, 8:00 AM
asn committed rLIBSSHdc4d4cc8d4c9: tests/torture_rekey: Do not mix integer types (authored by ansasaki).
tests/torture_rekey: Do not mix integer types
Fri, Jun 14, 8:00 AM

Thu, Jun 13

davidwed updated the task description for T154: Add ssh_threads_get_default() to the callbacks.h.
Thu, Jun 13, 10:55 PM · Restricted Project
davidwed created T154: Add ssh_threads_get_default() to the callbacks.h.
Thu, Jun 13, 10:47 PM · Restricted Project
davidwed closed T145: Add ssh_threads_get_winlock() to the callbacks.h as Invalid.
Thu, Jun 13, 9:27 PM · Restricted Project
davidwed added a comment to T145: Add ssh_threads_get_winlock() to the callbacks.h.

Sounds good to me.

Thu, Jun 13, 9:26 PM · Restricted Project
asn committed rLIBSSHf46eff79e2bb: cmake: Bump API version to 4.8.0 (authored by davidwed).
cmake: Bump API version to 4.8.0
Thu, Jun 13, 5:38 PM
asn committed rLIBSSH658a15099173: channels: Make ssh_message_channel_request_open_reply_accept_channel public (authored by davidwed).
channels: Make ssh_message_channel_request_open_reply_accept_channel public
Thu, Jun 13, 5:38 PM
asn committed rLIBSSH32eec7b41887: SSH_LOG: Adjust log level from SSH_LOG_WARNING to SSH_LOG_PROTOCOL (authored by davidwed).
SSH_LOG: Adjust log level from SSH_LOG_WARNING to SSH_LOG_PROTOCOL
Thu, Jun 13, 5:38 PM
asn closed T153: cmake: Bump API version to 4.8.0 as Resolved by committing rLIBSSHf46eff79e2bb: cmake: Bump API version to 4.8.0.
Thu, Jun 13, 5:38 PM · Restricted Project
asn committed rLIBSSH1f43b52117fc: tests: Fix the glob test on musl libc (authored by asn).
tests: Fix the glob test on musl libc
Thu, Jun 13, 5:38 PM
asn closed T144: Add ssh_message_channel_request_open_reply_accept_channel function as Resolved by committing rLIBSSH658a15099173: channels: Make ssh_message_channel_request_open_reply_accept_channel public.
Thu, Jun 13, 5:38 PM · Restricted Project
asn closed T149: Adjust log level from SSH_LOG_WARNING to SSH_LOG_PROTOCOL as Resolved by committing rLIBSSH32eec7b41887: SSH_LOG: Adjust log level from SSH_LOG_WARNING to SSH_LOG_PROTOCOL.
Thu, Jun 13, 5:38 PM · Restricted Project
asn committed rLIBSSHc0c1454298aa: session: OpenSSH is using SHA256 fingerprints now (authored by Jakuje).
session: OpenSSH is using SHA256 fingerprints now
Thu, Jun 13, 5:38 PM
asn committed rLIBSSHddece69a07a9: .gitlab-ci.yml: Add FIPS tests (authored by Jakuje).
.gitlab-ci.yml: Add FIPS tests
Thu, Jun 13, 5:38 PM