Page MenuHomePhabricator

Needs Triage (8)

High (4)

Normal (3)

Today

Jakuje added a comment to T122: Running the sftp_read test for the second time fails.

After more hours of digging in the code, I isolated this to the two SFTP calls that cause this issue to be reproducible reliably. These are calls to ssh_channel_send_eof() and ssh_channel_free() from sftp_free() called from the cleanup of the first sftp. If I remove these two calls, the testsuite passes reproducibly.

Mon, Nov 19, 3:50 PM · Restricted Project
ehmry triaged T123: Unable to import key files with leading whitespace as Normal priority.
Mon, Nov 19, 11:01 AM · Restricted Project

Fri, Nov 16

Jakuje created T122: Running the sftp_read test for the second time fails.
Fri, Nov 16, 4:37 PM · Restricted Project

Thu, Nov 15

asn committed rLIBSSHaa56b8ca5306: tests: Fix chroot_wrapper location (authored by asn).
tests: Fix chroot_wrapper location
Thu, Nov 15, 4:46 PM
asn committed rLIBSSH3de34944ad11: tests: Ensure the ssh session fd is read-/writeable in torture_proxycommand (authored by Gundersanne).
tests: Ensure the ssh session fd is read-/writeable in torture_proxycommand
Thu, Nov 15, 4:46 PM
asn committed rLIBSSH3b46198c42b3: tests: Fix chroot_wrapper location (authored by asn).
tests: Fix chroot_wrapper location
Thu, Nov 15, 4:46 PM

Tue, Nov 13

cortana63 added a comment to T33: SSH_OPTIONS_TIMEOUT not used in non-blocking sockets.

I am seeing this issue with sftp_read(). The sftp_read() function call was getting hung when there was a disconnect. I traced it to ssh_channel_read() which isn't using the user defined timeout.

Tue, Nov 13, 4:46 PM · Restricted Project
asn added a comment to T33: SSH_OPTIONS_TIMEOUT not used in non-blocking sockets.

ssh_channel_read_timeout()

Tue, Nov 13, 4:38 PM · Restricted Project
Jakuje created T121: The server should not send the SSH_MSG_EXT_INFO message after rekeying.
Tue, Nov 13, 3:39 PM · Restricted Project
cortana63 added a comment to T33: SSH_OPTIONS_TIMEOUT not used in non-blocking sockets.

I have tested with 0.8.4. It looks like SSH_TIMEOUT_DEFAULT is always -1 even if I set SSH_OPTIONS_TIMEOUT.

Tue, Nov 13, 2:18 PM · Restricted Project
asn added a comment to T33: SSH_OPTIONS_TIMEOUT not used in non-blocking sockets.

This should be fixed with c2fc9ac956b4452066543f8d22758bb710b752b7 and ef06ef2c1bf9cab97ecf451d40c1311b2f0d4b02

Tue, Nov 13, 12:48 PM · Restricted Project
asn added a comment to T33: SSH_OPTIONS_TIMEOUT not used in non-blocking sockets.

Did you test this with libssh >= 0.8.3. Because I fixed some things.

Tue, Nov 13, 12:47 PM · Restricted Project

Fri, Nov 9

cortana63 added a comment to T33: SSH_OPTIONS_TIMEOUT not used in non-blocking sockets.

This is related to this issue discussed here: https://www.libssh.org/archive/libssh/2016-02/0000010.html

Fri, Nov 9, 10:35 PM · Restricted Project

Thu, Nov 8

asn committed rLIBSSH67f418218bd3: knownhosts: Take StrictHostKeyChecking option into account (authored by Gundersanne).
knownhosts: Take StrictHostKeyChecking option into account
Thu, Nov 8, 8:13 PM
asn committed rLIBSSH69cb3c583539: knownhosts: Take StrictHostKeyChecking option into account (authored by Gundersanne).
knownhosts: Take StrictHostKeyChecking option into account
Thu, Nov 8, 8:13 PM
asn committed rLIBSSH03c30e9c8ad3: tests: Ensure the ssh session fd is read-/writeable in torture_proxycommand (authored by Gundersanne).
tests: Ensure the ssh session fd is read-/writeable in torture_proxycommand
Thu, Nov 8, 8:13 PM
asn added a comment to T108: setting knownhost option to NULL crashes, at least before connecting.

Yes, I think that would be the correct fix.

Thu, Nov 8, 5:35 PM · Restricted Project
asn committed rLIBSSH5102b16cf131: crypto: Fix compilation for OpenSSL without deprecated APIs (authored by Rosen Penev <rosenp@gmail.com>).
crypto: Fix compilation for OpenSSL without deprecated APIs
Thu, Nov 8, 9:37 AM
asn committed rLIBSSH61cac32288fb: crypto: Fix compilation for OpenSSL without deprecated APIs (authored by Rosen Penev <rosenp@gmail.com>).
crypto: Fix compilation for OpenSSL without deprecated APIs
Thu, Nov 8, 9:37 AM

Tue, Nov 6

Gundersanne added a comment to T108: setting knownhost option to NULL crashes, at least before connecting.

options.c:610 in current master:

Tue, Nov 6, 3:35 PM · Restricted Project
Jakuje added a comment to T108: setting knownhost option to NULL crashes, at least before connecting.

No, this issue is still present it I am right.

Tue, Nov 6, 2:29 PM · Restricted Project
Jakuje added a comment to T109: ProxyCommand for jump host configuration broken.

Probably not. I assume this is not only about configuration parser (which was fixed in several aspects recently), but instead about the way how the proxycommand is implemented in libssh (I am actually not sure how does it work there). The important are errors with ProxyCommand, but for further investigation, some debugging log will be needed:

Tue, Nov 6, 2:23 PM · Restricted Project
asn assigned T108: setting knownhost option to NULL crashes, at least before connecting to Jakuje.

Jabuk, is that working with the new config parsting stuff?

Tue, Nov 6, 2:16 PM · Restricted Project
asn closed T84: sftp connect don't read ~/.ssh/config correctly as Resolved.

Fixed in libssh 0.8.1 or newer.

Tue, Nov 6, 2:15 PM · Restricted Project
asn added a project to T109: ProxyCommand for jump host configuration broken: Restricted Project.
Tue, Nov 6, 2:13 PM · Restricted Project
asn assigned T109: ProxyCommand for jump host configuration broken to Jakuje.

Jakub, didn't we already fix this?

Tue, Nov 6, 2:13 PM · Restricted Project
asn closed T118: ssh_get_user_home_dir does not check for no match as Resolved.
Tue, Nov 6, 2:09 PM
asn committed rLIBSSHdc071dc6cf1b: cmake: Refresh the CMake Config files (authored by Christophe Giboudeaux <christophe@krop.fr>).
cmake: Refresh the CMake Config files
Tue, Nov 6, 2:04 PM
asn committed rLIBSSHaa899f8ec06e: cmake: Refresh the CMake Config files (authored by Christophe Giboudeaux <christophe@krop.fr>).
cmake: Refresh the CMake Config files
Tue, Nov 6, 2:04 PM

Mon, Nov 5

asn committed rLIBSSHc88fb4c55b54: tests: Use correct assert function in torture_client_config (authored by asn).
tests: Use correct assert function in torture_client_config
Mon, Nov 5, 12:19 PM
asn committed rLIBSSH86dabfe7e424: cmake: Only check for bounded attribute on OpenBSD (authored by asn).
cmake: Only check for bounded attribute on OpenBSD
Mon, Nov 5, 12:19 PM
asn committed rLIBSSHa8ed5e31dc15: tests: Check for NULL in torture_client_config (authored by asn).
tests: Check for NULL in torture_client_config
Mon, Nov 5, 12:19 PM

Fri, Nov 2

asn committed rLIBSSH1650d8178e48: config: Avoid potential file descriptor leak (authored by Jakuje).
config: Avoid potential file descriptor leak
Fri, Nov 2, 1:26 PM
asn committed rLIBSSHa8d4fbaccb93: tests: Improve error reporting in auth test (authored by Jakuje).
tests: Improve error reporting in auth test
Fri, Nov 2, 12:18 PM
asn committed rLIBSSH56b7d2da4d51: tests: Typo -- the flags should be checked according to the comment (authored by Jakuje).
tests: Typo -- the flags should be checked according to the comment
Fri, Nov 2, 12:18 PM
asn committed rLIBSSHa4b99eedf2f0: knownhosts: Make sure we have both knownhosts files ready (authored by Jakuje).
knownhosts: Make sure we have both knownhosts files ready
Fri, Nov 2, 12:17 PM
asn committed rLIBSSH8a8498b586bf: client: Reformat comment (authored by Jakuje).
client: Reformat comment
Fri, Nov 2, 12:17 PM
asn committed rLIBSSH44b32e940e51: tests/pkd: Properly clean up memory (authored by Jakuje).
tests/pkd: Properly clean up memory
Fri, Nov 2, 12:17 PM
asn committed rLIBSSH059079581add: session: Drop unused structure member (SSHv1) (authored by Jakuje).
session: Drop unused structure member (SSHv1)
Fri, Nov 2, 12:16 PM
asn committed rLIBSSHf11be32e1182: misc: Properly check for errors returned from getpwuid_r() (authored by Jakuje).
misc: Properly check for errors returned from getpwuid_r()
Fri, Nov 2, 12:16 PM