Page MenuHomePhabricator

Open Tasks

Needs Triage (15)

Active Repositories

Recent Activity

Fri, Feb 14

asn created T218: Disable ssh-rsa (sha1) keys by default.
Fri, Feb 14, 12:43 PM · Restricted Project

Thu, Feb 13

syyyr created T217: Allow specifying password callback in ssh_userauth_publickey_auto.
Thu, Feb 13, 3:12 PM
Jakuje added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

Thank you for confirmation that this combination works. But lets clarify what you do -- you are sending every X minutes the ignore or keepalive messages to keep the channel open, but even though you are getting disconnects after 30 minutes. I do not think this is anything in libssh. What are you running in the channels? Port forwarding? Some long-running commands transmitting or not transmitting data? Shells? How does this disconnect look like? Could it be the default value of $TMOUT in bash? Or something on the network layer terminating long-running connections?

Thu, Feb 13, 1:56 PM · Restricted Project
Vishalearnz added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

Thanks Jakuje , Although I am able to use the above two api's to get the status of the connection.
But even after that there is a hard reset which causes the session to be terminated after 30 mins , even though keep alive is being sent.

Thu, Feb 13, 10:34 AM · Restricted Project

Wed, Feb 12

asn committed rLIBSSH9fcb55930150: pki: Fix memory leak of blob on error (authored by asn).
pki: Fix memory leak of blob on error
Wed, Feb 12, 10:15 AM
asn committed rLIBSSH0ece6e52aaa6: pki: Use SSH_BUFFER_FREE() in ssh_pki_signature_verify() (authored by asn).
pki: Use SSH_BUFFER_FREE() in ssh_pki_signature_verify()
Wed, Feb 12, 10:15 AM
asn committed rLIBSSHa9e39a41ffb5: pki: Small code cleanup in ssh_pki_signature_verify() (authored by asn).
pki: Small code cleanup in ssh_pki_signature_verify()
Wed, Feb 12, 10:15 AM
asn committed rLIBSSHf208e4b332e2: pki: Add missing return check for ssh_buffer_pack() (authored by asn).
pki: Add missing return check for ssh_buffer_pack()
Wed, Feb 12, 10:15 AM
asn committed rLIBSSH8542f675f43f: sftp: Replace PRIdS with ANSI C99 %zu (authored by asn).
sftp: Replace PRIdS with ANSI C99 %zu
Wed, Feb 12, 9:41 AM
asn committed rLIBSSHfaedadf2eb4b: packet: Replace PRIdS with ANSI C99 %zu (authored by asn).
packet: Replace PRIdS with ANSI C99 %zu
Wed, Feb 12, 9:41 AM
asn committed rLIBSSH875b2a5b5919: include: Remove PRIdS definitions (authored by asn).
include: Remove PRIdS definitions
Wed, Feb 12, 9:41 AM
asn committed rLIBSSH702e7e4c85da: channels: Replace PRIdS with ANSI C99 %zu (authored by asn).
channels: Replace PRIdS with ANSI C99 %zu
Wed, Feb 12, 9:41 AM
fedorskvorcov closed T216: libssh 0.9.3 "DLLMain: ssh_init failed!" on Windows 10 (vcpkg) as Resolved.
Wed, Feb 12, 7:25 AM · Restricted Project
fedorskvorcov added a comment to T216: libssh 0.9.3 "DLLMain: ssh_init failed!" on Windows 10 (vcpkg).

Hello! Thank you a lot! You are absolutely right, idiotsandopensource and ansasaki! The problem is with mbedtls.lib. So need to wait when it will fixed ^3^

Wed, Feb 12, 7:23 AM · Restricted Project

Tue, Feb 11

idiotsandopensource added a comment to T216: libssh 0.9.3 "DLLMain: ssh_init failed!" on Windows 10 (vcpkg).

This is not libssh's fault. Yesterday vcpkg master changed and new master branch is broken. Only reason I know this because I was setting up vcpkg with another programmer and called it a day. Next morning I get a it no work and all our automated builds broke.

Tue, Feb 11, 10:13 PM · Restricted Project
idiotsandopensource added a comment to T216: libssh 0.9.3 "DLLMain: ssh_init failed!" on Windows 10 (vcpkg).

This is caused by a idiot programmer and I swear it must have happened in 48 hour window because THIS SHIT did not happen. I went to vcpkg to not have to explain open source stupid shit to other engineers that don't need to know about cmake pearl and other stupid shit.

Tue, Feb 11, 9:39 PM · Restricted Project
fedorskvorcov added a comment to T216: libssh 0.9.3 "DLLMain: ssh_init failed!" on Windows 10 (vcpkg).

I just use default package which coming from vcpkg. By default it's coming with mbedtls => so it's mbedcrypto.lib.
I don't use any flags cause I think that default package should work.

Tue, Feb 11, 8:01 PM · Restricted Project
ansasaki added a comment to T216: libssh 0.9.3 "DLLMain: ssh_init failed!" on Windows 10 (vcpkg).

This is probably caused by the lack of threading support in the crypto library.

Tue, Feb 11, 7:53 PM · Restricted Project
ansasaki committed rLIBSSH73f383a2e6d6: doc: Documents PKCS #11 URI support for libssh (authored by Sahana Prasad <sahana@redhat.com>).
doc: Documents PKCS #11 URI support for libssh
Tue, Feb 11, 2:27 PM
ansasaki committed rLIBSSH862b2341d714: src: updates documentation incorporate PKCS#11 URIs in import functions. (authored by Sahana Prasad <sahana@redhat.com>).
src: updates documentation incorporate PKCS#11 URIs in import functions.
Tue, Feb 11, 2:27 PM
fedorskvorcov created T216: libssh 0.9.3 "DLLMain: ssh_init failed!" on Windows 10 (vcpkg).
Tue, Feb 11, 1:33 PM · Restricted Project
Jakuje committed rLIBSSH0dd71375e7fe: pki: fix `pki_key_ecdsa_to_key_type` thread-safety (authored by simonsj).
pki: fix `pki_key_ecdsa_to_key_type` thread-safety
Tue, Feb 11, 10:45 AM
Jakuje committed rLIBSSH3664ba2800ea: pki: fix `pki_key_ecdsa_to_key_type` thread-safety (authored by simonsj).
pki: fix `pki_key_ecdsa_to_key_type` thread-safety
Tue, Feb 11, 10:45 AM
Jakuje committed rLIBSSH17b518a677c9: pki: add support for sk-ecdsa and sk-ed25519 (authored by Sebastian Kinne <skinne@google.com>).
pki: add support for sk-ecdsa and sk-ed25519
Tue, Feb 11, 10:45 AM
Jakuje triaged T215: Implement client side support for u2f keys (including tests) as Normal priority.
Tue, Feb 11, 10:44 AM · Restricted Project
simonsj added a comment to T214: pki_key_ecdsa_to_key_type helpers use thread-unsafe static local.

I've proposed https://gitlab.com/libssh/libssh-mirror/-/merge_requests/93 for fixing this by removing the static from those variables.

Tue, Feb 11, 10:44 AM
simonsj created T214: pki_key_ecdsa_to_key_type helpers use thread-unsafe static local.
Tue, Feb 11, 10:44 AM
Jakuje added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

I am sorry for a delay.

Tue, Feb 11, 10:44 AM · Restricted Project

Thu, Jan 30

asn committed rLIBSSH30d03498b46c: gitlab-ci: Improve setting Fedora to FIPS mode (authored by asn).
gitlab-ci: Improve setting Fedora to FIPS mode
Thu, Jan 30, 10:57 AM
Vishalearnz added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

In my scenario I need to handle the response i.e if for a keepalive request I donot get a correct response . I need to terminate the session .
But going by what you wrote above " no explicit action should be needed from the calling program" , I am understanding that ssh_send_keepalive() internally calls the following sequence ssh_global_request()-> ssh_handle_packets_termination()->ssh_handle_packets() .
But I need to capture the response which ssh_send_keepalive() doesnot provide me any means to get it.
Also all the other api's like
ssh_global_request(), ssh_handle_packets_termination(), ssh_handle_packets() are not exposed to external world so I cant use it inside my code.

Thu, Jan 30, 7:45 AM · Restricted Project

Wed, Jan 29

Jakuje added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

Hi @Jakuje ,
ssh_handle_packets() is not an exposed api .

Wed, Jan 29, 1:13 PM · Restricted Project
Vishalearnz added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

ssh_handle_packets() is not an exposed api . I am unable to use it , also this macro(SSH_MSG_REQUEST_FAILURE) I cant find in the codebase of libssh . So what should I use ?

Wed, Jan 29, 12:30 PM · Restricted Project
Jakuje added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

Hi,
the ssh_send_keepalive() does really only the sending. But the return value is ignored since 59ada799. But if the sending failed, the session state should be modified to reflect this if I am right. The response is handled as any other message in ssh_handle_packets() if I am right. The response is anyway SSH_MSG_REQUEST_FAILURE.

Wed, Jan 29, 11:11 AM · Restricted Project
Vishalearnz added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

I tried using ssh_send_keepalive() but it doesnot serve the purpose . Here I was monitoring the return value of the function (ssh_send_keepalive) .
I first started client and server . In my scenario server shall initiate the connection which it did and this keep alive function was set to send every 30 sec . for which the ssh_send_keepalive() was returning SSH_OK.
But when I killed the client . It was expected that the ssh_send_keepalive() should send back SSH_ERROR but instead it kept on sending back SSH_OK . This means this api is only sending the message but not monitoring the response.

Wed, Jan 29, 9:49 AM · Restricted Project

Tue, Jan 28

Jakuje added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

Please, check the RFC 4253 describing this message: https://tools.ietf.org/html/rfc4253#section-11.2

Tue, Jan 28, 9:14 PM · Restricted Project
Vishalearnz added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

Just one query .
If we are using ssh_send_ignore . Do we get response from the client for the same ?
If not then is there an api other than ssh_send_ignore which sends the message and gets back response from the client.
I need to get the response of the client (either they have received the message or not).

Tue, Jan 28, 8:25 AM · Restricted Project

Mon, Jan 27

Jakuje triaged T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0 as Wishlist priority.
Mon, Jan 27, 11:50 AM · Restricted Project
Vishalearnz added a comment to T212: ServerAliveInterval & ClientAliveInterval not present in libssh version 0.9.0.

Thanks a lot @Jakuje .
I tried as per your recommendation and it works for me.

Mon, Jan 27, 11:04 AM · Restricted Project

Thu, Jan 23

asn reassigned T2: allow external io from aris to ansasaki.
Thu, Jan 23, 1:58 PM · Restricted Project
jktjkt added a comment to T211: Regression introduced in commit e0e3636c60dd28fd358e47da2be132702ff8edc9 breaks libnetconf2.

Thanks, commit 9a10cef92086d3b22fa4acd9999cf908b7fa7e48 works.

Thu, Jan 23, 12:19 PM