Page MenuHomePhabricator

Open Tasks

Needs Triage (10)

High (5)

Active Repositories

Recent Activity

Yesterday

Jakuje claimed T169: Support multi-criteria Match like Match host `hostname` exec `statement`.

I implemented the match exec. Can you try if it works for you as expected in your use case? There are several commits adjusting the tests and as well as I had to implement new token parsing function, but my basic tests looked good. This code also does not work on windows since I am not Windows developer, but if interested, I believe there will be somebody who could implement that.

Mon, Sep 16, 6:11 PM · Unknown Object (Project)
Jakuje closed T165: 0.9.0 gcc compiler warnings deprecated-declarations as Resolved.
Mon, Sep 16, 12:56 PM · Unknown Object (Project)
Jakuje closed T137: Difference between sftp_new() and sftp_init() is not clear as Resolved.
Mon, Sep 16, 12:56 PM · Unknown Object (Project)
Jakuje closed T142: torture_proxycommand failing as Resolved.

The original issue should be resolved in master now.

Mon, Sep 16, 12:56 PM · Unknown Object (Project)
Jakuje committed rLIBSSH4900ab6ca9a0: Skip the proxycommand test in case the netcat is not avaliable (authored by Jakuje).
Skip the proxycommand test in case the netcat is not avaliable
Mon, Sep 16, 12:44 PM
Jakuje committed rLIBSSH83fa060cec0f: known_hosts: Avoid using deprecated functions (even from deprecated functions) (authored by Jakuje).
known_hosts: Avoid using deprecated functions (even from deprecated functions)
Mon, Sep 16, 12:44 PM
Jakuje committed rLIBSSH618b858e49ce: sftp: Improve the documentation of sftp_init() and sftp_new() (authored by Jakuje).
sftp: Improve the documentation of sftp_init() and sftp_new()
Mon, Sep 16, 12:44 PM
foxge triaged T176: I have upgraded libssh from 0.7.6 to 0.9.0 to use diffie-hellman-group-exchange-sha256 kex algo both in client and server, but I found that memory leak , see details as High priority.
Mon, Sep 16, 10:33 AM · Unknown Object (Project)
Jakuje added a project to T172: libssh 0.8.7 failed to build in debug mode with openssl 1.1.1c: Unknown Object (Project).
Mon, Sep 16, 9:49 AM · Unknown Object (Project)
Jakuje added a project to T175: Building v9.0.0 with gcc 7.4.0 fails.: Unknown Object (Project).
Mon, Sep 16, 9:47 AM · Unknown Object (Project)
Jakuje added a comment to T142: torture_proxycommand failing.

Aris, can you open a new bug for this, ideally with more debug information as proposed by @ansasaki?

Mon, Sep 16, 9:42 AM · Unknown Object (Project)
TheMarlboroMan created T175: Building v9.0.0 with gcc 7.4.0 fails..
Mon, Sep 16, 8:44 AM · Unknown Object (Project)

Sun, Sep 15

aris added a comment to T137: Difference between sftp_new() and sftp_init() is not clear.
In T137#2665, @adelton wrote:

I like the proposed wording, @Jakuje.
If the semantics get changed later, the documentation will change with it. But I'd prefer not waiting for the refactoring and just update the description now, as the first step.

Sun, Sep 15, 9:11 PM · Unknown Object (Project)
adelton added a comment to T137: Difference between sftp_new() and sftp_init() is not clear.

I like the proposed wording, @Jakuje.

Sun, Sep 15, 3:56 PM · Unknown Object (Project)

Fri, Sep 13

aris added a comment to T137: Difference between sftp_new() and sftp_init() is not clear.

That code is awfully old (probably 2004-2005). The idea was probably separating the SSH part and the SFTP parts. Today it makes little sense. Also both calls are synchronous and blocking. Your proposed patch describes well what it does today. Given the time I'd improve the actual implementation and move everything that handles network into sftp_init() and leave sftp_new() to memory allocation only like it's standard in the rest of the library.

Fri, Sep 13, 6:37 PM · Unknown Object (Project)
aris added a comment to T142: torture_proxycommand failing.

Hi Jakub,

Fri, Sep 13, 6:08 PM · Unknown Object (Project)
Jakuje added a comment to T142: torture_proxycommand failing.

Can you check the following patch if t addresses the issue for you?

Fri, Sep 13, 5:41 PM · Unknown Object (Project)
Jakuje added a comment to T142: torture_proxycommand failing.

I am getting exactly the same result as the OP when I remove the /usr/bin/nc, which is used in the respective failing test so I assume that this is the issue, but the error should be more properly reported and the test probably skipped in case the netcat is not in place. I will submit a patch.

Fri, Sep 13, 5:30 PM · Unknown Object (Project)
Jakuje added a comment to T142: torture_proxycommand failing.

Thank you for having a look into that. In that case, I am wondering why it did work for me and for the CI we run, but I think most of that is on Fedora, which might be a difference. Can you check whether the netcat (nc) is installed in your system?

Fri, Sep 13, 5:23 PM · Unknown Object (Project)
aris triaged T174: pkd_hello fails for some host key types as Low priority.
Fri, Sep 13, 5:22 PM
aris reopened T142: torture_proxycommand failing as "Open".

Closed it by mistake

Fri, Sep 13, 5:12 PM · Unknown Object (Project)
aris closed T142: torture_proxycommand failing as Resolved.

cc @Jakuje, git blame says you touched that code last :)

Fri, Sep 13, 5:11 PM · Unknown Object (Project)
aris added a comment to T142: torture_proxycommand failing.

I found this problem too when trying to set up the test environment on Ubuntu 18.04. The root cause is that the test calls the ssh binary from the fake root user. It fails because ssh can't find uid 0 in /etc/passwd, then fails because of missing known hosts keys and authentication keys. I don't know how that test could work elsewhere.
I made a patch that assumes it's running as root and create the missing keys. A better way would be to force the test cases to run as bob but I haven't found the proper way of doing this.

Fri, Sep 13, 5:10 PM · Unknown Object (Project)
Jakuje added a comment to T75: OpenSSH : ssh_channel_new and ssh_channel_open_session blocks when we reach MaxSessions limit.

I just tested the ssh-client from examples, which is using channel_open with sshd configured with MaxSessions 0 and it is correctly failing and not hanging for me. Can you test with current libssh master or 0.9 and provide more ellaborate reproducer?

Fri, Sep 13, 2:59 PM · Unknown Object (Project)
Jakuje added a comment to T137: Difference between sftp_new() and sftp_init() is not clear.

The file doc/sftp.dox contains the following information (not sure whether it is rendered somewhere on the web):

Fri, Sep 13, 2:47 PM · Unknown Object (Project)
TheMarlboroMan created T173: v9.0 example and cpp wrappers returning -1 on ssh_channel_read and ssh_channel_read_timeout.
Fri, Sep 13, 1:55 PM
Jakuje added a comment to T165: 0.9.0 gcc compiler warnings deprecated-declarations.

This should be addressed by using the new API even inside of the deprecated functions without the change of functionality. Can you try the following patch?

Fri, Sep 13, 1:29 PM · Unknown Object (Project)
davidwed closed T170: Add HAVE_INTTYPES_H as Wontfix.
Fri, Sep 13, 1:20 PM · Unknown Object (Project)
davidwed added a comment to T170: Add HAVE_INTTYPES_H.

I wanted to compile the lib with the bcc32 compiler ( Win32 / Borland / Embarcadero ).

Fri, Sep 13, 1:19 PM · Unknown Object (Project)
Jakuje added a comment to T170: Add HAVE_INTTYPES_H.

The modification of the libssh.h is breaking other applications (for example the applications in example directory) using this header file not defining HAVE_INTTYPES_H and HAVE_UNISTD_H themselves. Can you clarify what problem are you solving by this and on what system you do not have these header files?

Fri, Sep 13, 12:46 PM · Unknown Object (Project)
Jakuje added a comment to T172: libssh 0.8.7 failed to build in debug mode with openssl 1.1.1c.

Did you try the latest libssh 0.9 [1]. Not sure what went wrong with the old version, but the windows builds are part of CI and they should work in recent version

Fri, Sep 13, 12:04 PM · Unknown Object (Project)

Mon, Sep 9

prashanttekriwal created T172: libssh 0.8.7 failed to build in debug mode with openssl 1.1.1c.
Mon, Sep 9, 9:01 PM · Unknown Object (Project)

Thu, Aug 22

ansasaki created T171: Allow specifiying algorithms in configuration file by adding or removing algorithms from default.
Thu, Aug 22, 3:58 PM
ansasaki closed T76: Support keys with line comments as Resolved.

Fixed in master by:
88d777e67823
d627cba47610

Thu, Aug 22, 3:47 PM · Unknown Object (Project)
ansasaki closed T166: known_hosts: directories are not created recursively as Resolved.

This was fixed in master by 5b18bcb0ac39c3c366dd769e893af381ddb5deb2

Thu, Aug 22, 3:42 PM

Wed, Aug 21

davidwed updated the task description for T170: Add HAVE_INTTYPES_H.
Wed, Aug 21, 11:50 AM · Unknown Object (Project)
davidwed created T170: Add HAVE_INTTYPES_H.
Wed, Aug 21, 11:47 AM · Unknown Object (Project)

Tue, Aug 20

Jakuje added a comment to T169: Support multi-criteria Match like Match host `hostname` exec `statement`.

I think the multi-criteria matches are generally supported, but I agree that they are not tested and that should be fixed.

Tue, Aug 20, 5:48 PM · Unknown Object (Project)

Aug 12 2019

akobel triaged T169: Support multi-criteria Match like Match host `hostname` exec `statement` as Wishlist priority.
Aug 12 2019, 10:52 PM · Restricted Project

Aug 9 2019

boguslaw added a comment to T47: sftp_write waits infinitely when connection to target server is lost.

Hi guys
How the issue was ended? Is there working fix for unplug calble during file transfer?
I will be grateful for any advice :)

Aug 9 2019, 12:30 PM · Restricted Project